Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-08-30 Thread Lennert Buytenhek
D'oh. Sorry, I'm old-fashioned, and I'm used to submitting patches for inclusion by mailing them out to mailing lists. :) I created a github PR just now. Thanks! On Wed, Aug 30, 2017 at 02:31:13PM +, Paolo Lucente wrote: > Lennert, nope, not missing anything :) We are on the same page

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-08-30 Thread Paolo Lucente
Lennert, nope, not missing anything :) We are on the same page and i'm just awaiting for your PR on GitHub. Thanks Vincent as always for your input. Paolo On Wed, Aug 30, 2017 at 05:15:12PM +0300, Lennert Buytenhek wrote: > Hi Paolo, > > Well, that's how it's in the patch. Am I missing

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-08-30 Thread Lennert Buytenhek
Hi Paolo, Well, that's how it's in the patch. Am I missing something? :) Cheers, Lennert On Wed, Aug 30, 2017 at 02:14:48PM +, Paolo Lucente wrote: > Hi Lennert, > > That would indeed work too, yes. Go for it :) > > Paolo > > On Wed, Aug 30, 2017 at 05:03:10PM +0300, Lennert

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-08-30 Thread Vincent Bernat
❦ 30 août 2017 13:58 GMT, Paolo Lucente  : > Fantastic, please proceed. I guess the patch should be wrapped around > some version checking of libpcap a-la if greater or equal than current > release in master then compile the code. I did jus review configure.ac > and libpcap

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-08-30 Thread Paolo Lucente
Hi Lennert, That would indeed work too, yes. Go for it :) Paolo On Wed, Aug 30, 2017 at 05:03:10PM +0300, Lennert Buytenhek wrote: > Hi Paolo, > > Wouldn't the autoconf check for the symbol (pcap_set_protocol) be > sufficient here? > > + AC_CHECK_LIB([pcap], [pcap_set_protocol], [

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-08-30 Thread Lennert Buytenhek
Hi Paolo, Wouldn't the autoconf check for the symbol (pcap_set_protocol) be sufficient here? + AC_CHECK_LIB([pcap], [pcap_set_protocol], [ AC_DEFINE(PCAP_SET_PROTOCOL, 1) ], []) Just checking for the version number wouldn't necessarily mean that the symbol is available, because the function

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-08-30 Thread Paolo Lucente
Hi Lennert, Fantastic, please proceed. I guess the patch should be wrapped around some version checking of libpcap a-la if greater or equal than current release in master then compile the code. I did jus review configure.ac and libpcap version is not captured plus i seem to read libpcap folks

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-08-30 Thread Lennert Buytenhek
Hi again! On Mon, Jul 03, 2017 at 05:15:33PM +0300, Lennert Buytenhek wrote: > > I'd be curious what is your strategy to move this forward, especially on > > the libpcap side. If it makes any convenient to you, we can indeed merge > > the pmacct part - since it's all wrapped around that

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-07-03 Thread Lennert Buytenhek
On Mon, Jul 03, 2017 at 01:54:33AM +, Paolo Lucente wrote: > Hi Lennert, Hello, > I'm familiar with the context and the patch, on the pmacct side of the > things, looks sane. The only thing i noticed is that a default value for > config.pcap_protocol is never imposed. Thanks for the

Re: [pmacct-discussion] [RFC] Patches to allow capturing specific PF_PACKET protocols

2017-07-02 Thread Paolo Lucente
Hi Lennert, I'm familiar with the context and the patch, on the pmacct side of the things, looks sane. The only thing i noticed is that a default value for config.pcap_protocol is never imposed. I'd be curious what is your strategy to move this forward, especially on the libpcap side. If it