Branch: refs/heads/pmd/7.0.x Home: https://github.com/pmd/pmd Commit: c6b7a723be52a77b6e4ebd6fa15f0511782b8bcc https://github.com/pmd/pmd/commit/c6b7a723be52a77b6e4ebd6fa15f0511782b8bcc Author: Jeff Bartolotta <jbartolo...@salesforce.com> Date: 2020-09-17 (Thu, 17 Sep 2020)
Changed paths: M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexSharingViolationsRule.java A pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/rule/security/ApexSharingViolationsNestedClassTest.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexSharingViolations.xml Log Message: ----------- Analyze inner classes for sharing violations Fixes https://github.com/pmd/pmd/issues/2774, false positives and false negatives for ApexSharingViolationsRule. Sharing settings are not inherited by inner classes. Sharing settings need to be declared on the class that contains the Database method, DML, SOQL, or SOSL. The change inverts the direction from which nodes are found and analyzed. The previous code visited the ASTUserClass and then searched for descendant nodes that met a certain criteria. It did not visit inner ASTUserClass nodes because it didn't use rule chains or call the super's visit moethod for ASTUserClassi. The new implementation visits all nodes that correspond to Database method, DML, SOQL, or SOSL nodes and then finds the nearest ASTUserClass parent node. This ASTUserClass is examined to determine if it has declared a sharing setting as required. Commit: 47ff7b1c8b3d44947b55a25ad221c3ecdcb8176d https://github.com/pmd/pmd/commit/47ff7b1c8b3d44947b55a25ad221c3ecdcb8176d Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-18 (Fri, 18 Sep 2020) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/types/TypeTestUtil.java M pmd-java/src/test/java/net/sourceforge/pmd/lang/java/types/TypeTestUtilTest.java Log Message: ----------- Fix TypeTestUtil for arrays Commit: 7cbf14219a211bc69fb2cd70359bb389293e0bab https://github.com/pmd/pmd/commit/7cbf14219a211bc69fb2cd70359bb389293e0bab Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-18 (Fri, 18 Sep 2020) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/internal/JavaAstProcessor.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/internal/ast/AstClassSym.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/internal/ast/AstSymFactory.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/internal/ast/SymbolResolutionPass.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/table/internal/SymTableFactory.java M pmd-java/src/test/kotlin/net/sourceforge/pmd/lang/java/symbols/internal/AstSymbolTests.kt Log Message: ----------- Fix some things about annotations Commit: 0cc25f67477ecb91334344c6b0e41b6f2994ac08 https://github.com/pmd/pmd/commit/0cc25f67477ecb91334344c6b0e41b6f2994ac08 Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-18 (Fri, 18 Sep 2020) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/types/TypeTestUtil.java M pmd-java/src/test/java/net/sourceforge/pmd/lang/java/types/TypeTestUtilTest.java Log Message: ----------- Merge branch 'typeres-array-fixes' into java-sym-fixes Commit: 7caaa6e6665d315f6a6f4f0f7dde75fab74de846 https://github.com/pmd/pmd/commit/7caaa6e6665d315f6a6f4f0f7dde75fab74de846 Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-18 (Fri, 18 Sep 2020) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/UnusedAssignmentRule.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/JAccessibleElementSymbol.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symboltable/AbstractJavaScope.java M pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/bestpractices/UnusedAssignmentTest.java M pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedAssignment.xml Log Message: ----------- Update UnusedAssignmentRule Commit: ddb0acb56109cc04e67d15c4fddfd36f02aec771 https://github.com/pmd/pmd/commit/ddb0acb56109cc04e67d15c4fddfd36f02aec771 Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-18 (Fri, 18 Sep 2020) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/UnusedAssignmentRule.java M pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedAssignment.xml Log Message: ----------- Fix call chains with side effects Commit: 0753e2452b0168834db8e4f7c6252ee917c5ffe5 https://github.com/pmd/pmd/commit/0753e2452b0168834db8e4f7c6252ee917c5ffe5 Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-18 (Fri, 18 Sep 2020) Changed paths: M pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedAssignment.xml Log Message: ----------- Add test case for later Commit: dc76ec93e0a84c3bbe8dd70da23457e3480f9bca https://github.com/pmd/pmd/commit/dc76ec93e0a84c3bbe8dd70da23457e3480f9bca Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-18 (Fri, 18 Sep 2020) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/types/TypeTestUtil.java M pmd-java/src/test/java/net/sourceforge/pmd/lang/java/types/TypeTestUtilTest.java Log Message: ----------- Fix compil Commit: 46cff92e4503bafb026556c18aa7752c62db8d71 https://github.com/pmd/pmd/commit/46cff92e4503bafb026556c18aa7752c62db8d71 Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-18 (Fri, 18 Sep 2020) Changed paths: M pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedAssignment.xml Log Message: ----------- Fix todo test Commit: 7360821e8a68b5d291e46b486f1de5069e6d9b74 https://github.com/pmd/pmd/commit/7360821e8a68b5d291e46b486f1de5069e6d9b74 Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-19 (Sat, 19 Sep 2020) Changed paths: M docs/pages/7_0_0_release_notes.md Log Message: ----------- Update release notes Commit: 5429cebf380233f7569a41feb968ba7fcd30108c https://github.com/pmd/pmd/commit/5429cebf380233f7569a41feb968ba7fcd30108c Author: Jeff Bartolotta <jbartolo...@salesforce.com> Date: 2020-09-21 (Mon, 21 Sep 2020) Changed paths: M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexSharingViolations.xml Log Message: ----------- Add issue reproducers as standard rule tests Added false negative and false positive test cases that were logged with the original issue. Commit: 2f7d6d747a2946d934f7846cd763e83133fde76f https://github.com/pmd/pmd/commit/2f7d6d747a2946d934f7846cd763e83133fde76f Author: Clément Fournier <clement.fournie...@gmail.com> Date: 2020-09-22 (Tue, 22 Sep 2020) Changed paths: M README.md M docs/pages/release_notes.md M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/ast/AbstractJavaExpr.java A pmd-java/src/test/kotlin/net/sourceforge/pmd/lang/java/ast/ConstValuesKotlinTest.kt M pom.xml Log Message: ----------- Merge branch '7.0.x' into java-sym-fixes Commit: eb0f7e4f991c23e5b0a9973bfd977e12c323384b https://github.com/pmd/pmd/commit/eb0f7e4f991c23e5b0a9973bfd977e12c323384b Author: Andreas Dangel <andreas.dan...@pmd-code.org> Date: 2020-09-24 (Thu, 24 Sep 2020) Changed paths: M docs/pages/release_notes.md Log Message: ----------- [doc] Update release notes, refs #2791, fixes #2774 Commit: 250501a3d1e5be7b0aec788560452ae8ece28e46 https://github.com/pmd/pmd/commit/250501a3d1e5be7b0aec788560452ae8ece28e46 Author: Andreas Dangel <andreas.dan...@pmd-code.org> Date: 2020-09-24 (Thu, 24 Sep 2020) Changed paths: M docs/pages/release_notes.md M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexSharingViolationsRule.java A pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/rule/security/ApexSharingViolationsNestedClassTest.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexSharingViolations.xml Log Message: ----------- Merge branch 'pr-2791' into master [apex] Analyze inner classes for sharing violations #2791 Commit: f1e9a23b0123e1ad04da8f8cc98b95f549ac5872 https://github.com/pmd/pmd/commit/f1e9a23b0123e1ad04da8f8cc98b95f549ac5872 Author: Andreas Dangel <andreas.dan...@pmd-code.org> Date: 2020-09-24 (Thu, 24 Sep 2020) Changed paths: M docs/pages/release_notes.md Log Message: ----------- [doc] Update release notes - group fixes by category Commit: c0a336c869c66913594d65e7e817681c84727dcc https://github.com/pmd/pmd/commit/c0a336c869c66913594d65e7e817681c84727dcc Author: Andreas Dangel <andreas.dan...@pmd-code.org> Date: 2020-09-24 (Thu, 24 Sep 2020) Changed paths: M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/internal/JavaAstProcessor.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/internal/ast/AstClassSym.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/internal/ast/AstSymFactory.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/internal/ast/SymbolResolutionPass.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/table/internal/SymTableFactory.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/types/TypeTestUtil.java M pmd-java/src/test/kotlin/net/sourceforge/pmd/lang/java/symbols/internal/AstSymbolTests.kt Log Message: ----------- Merge branch 'pr-2793' into pmd/7.0.x [java] Fix AST symbols for annotations & records #2793 Commit: 70f1aec87b314500a06cd731188eb45099d25f5c https://github.com/pmd/pmd/commit/70f1aec87b314500a06cd731188eb45099d25f5c Author: Andreas Dangel <andreas.dan...@pmd-code.org> Date: 2020-09-24 (Thu, 24 Sep 2020) Changed paths: M docs/pages/7_0_0_release_notes.md M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/bestpractices/UnusedAssignmentRule.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symbols/JAccessibleElementSymbol.java M pmd-java/src/main/java/net/sourceforge/pmd/lang/java/symboltable/AbstractJavaScope.java M pmd-java/src/test/java/net/sourceforge/pmd/lang/java/rule/bestpractices/UnusedAssignmentTest.java M pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedAssignment.xml Log Message: ----------- Merge branch 'pr-2794' into pmd/7.0.x [java] Update UnusedAssignmentRule to PMD 7 grammar #2794 Commit: 0642293f4edf4bf6e2a4b3c3a2d227612d1f8c2c https://github.com/pmd/pmd/commit/0642293f4edf4bf6e2a4b3c3a2d227612d1f8c2c Author: Andreas Dangel <andreas.dan...@pmd-code.org> Date: 2020-09-24 (Thu, 24 Sep 2020) Changed paths: M docs/pages/release_notes.md M pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/security/ApexSharingViolationsRule.java A pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/rule/security/ApexSharingViolationsNestedClassTest.java M pmd-apex/src/test/resources/net/sourceforge/pmd/lang/apex/rule/security/xml/ApexSharingViolations.xml Log Message: ----------- Merge branch 'master' into pmd/7.0.x Compare: https://github.com/pmd/pmd/compare/818349f62201...0642293f4edf _______________________________________________ Pmd-commits mailing list Pmd-commits@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmd-commits