Sunday, March 9, 2008, 2:33:29 AM, Patrick wrote:
Also, as a general rule it's unwise to be calling FmtPageName()
on strings that are coming from page markup, as this exposes
the ability for people to view the values of variables that
perhaps they shouldn't see. This is also why page
Sunday, March 9, 2008, 11:55:17 AM, Hans wrote:
the '$'t gets replaced with 'read'
should read:
the '$t' gets replace with 'read'
Hans
___
pmwiki-devel mailing list
pmwiki-devel@pmichaud.com
http://www.pmichaud.com/mailman/listinfo/pmwiki-devel
Sunday, March 9, 2008, 2:31:43 AM, Patrick wrote:
Yes, the fact that globals leak into FmtPageName is a bit of
a pain, but I'd rather find ways to avoid the leaks than to
significantly slow down one of the most fundamental (and often called)
parts of the code.
How about 'defusing' potential
On Sun, Mar 09, 2008 at 11:55:17AM +, Hans wrote:
Sunday, March 9, 2008, 2:33:29 AM, Patrick wrote:
Also, as a general rule it's unwise to be calling FmtPageName()
on strings that are coming from page markup, as this exposes
the ability for people to view the values of variables that
On Sun, Mar 09, 2008 at 12:32:58PM +, Hans wrote:
Out of curiosity: what makes '$t' into a global?
It is hard to search the code for this.
Any variabes that aren't part of a function are global.
This would include variables that are used in the course
of initializing PmWiki or any
Sunday, March 9, 2008, 2:36:58 PM, Patrick wrote:
The way to prevent these from becoming global would be
to put all of initialization steps into separate functions
(thus making these variables local). While we could do this
for PmWiki, we'd still have global variables leaking out
via
