[pmwiki-devel] PageStore with groups in subdirectories

2015-01-11 Thread Omar Cornut
Hello again, While measuring processing cost I went looking into PageStore::ls(). We have a wiki.d/ directory with 2 files and this function cost us a fair amount of time, and called multiple times by our fancy pages. So I was considering creating subdirectories inside wiki.d/ for each group

[pmwiki-devel] Small optimisation

2015-01-11 Thread Omar Cornut
Hello, I was looking into making pmwiki faster for our website, looking for low-hanged fruits. In pmwiki.php function MarkupToHTML() This line: $markrules = BuildMarkupRules(); Can be moved outside of the loop. It happens to be constant an unmodified for the whole loop and building the rules

Re: [pmwiki-devel] PageStore with groups in subdirectories

2015-01-11 Thread Petko Yotov
You should never need to modify pmwiki.php or other core files, mostly everything can be redefined or replaced in config.php or with recipes. This way you can upgrade without losing your functions or having to re-apply your changes. Here, simply define the $WikiDir variable in config.php.

Re: [pmwiki-devel] Small optimisation

2015-01-11 Thread Petko Yotov
If the markup rules have not changed in the meantime, they are not rebuilt, the existing array is simply returned, so it shouldn't be noticeably slower. It is possible that a markup rule returns not HTML but other wiki markup that needs to be re-processed, in that case the markup rules will

Re: [pmwiki-devel] PageStore with groups in subdirectories

2015-01-11 Thread Patrick R. Michaud
On Sun, Jan 11, 2015 at 12:25:11PM +, Omar Cornut wrote: Then I noticed that PageStore via pagefile() appears to support this already. If we changed: $WikiDir = new PageStore('wiki.d/{$FullName}'); to $WikiDir = new PageStore('wiki.d/{$Group}/{$FullName}'); However this is not

Re: [pmwiki-devel] PageStore with groups in subdirectories

2015-01-11 Thread Omar Cornut
Thank you both for your answer, and sorry this ended up a purely user-side question. Using the feature appears to work very well for us and gave us a little boost ! On Sun, Jan 11, 2015 at 1:59 PM, Patrick R. Michaud pmich...@pobox.com wrote: On Sun, Jan 11, 2015 at 12:25:11PM +, Omar