Re: [pmwiki-users] warning on continue in pmwiki.php from php 7.3

2018-12-14 Thread Petko Yotov
Thanks for reporting, updated in Subversion for 2.2.112, to be released 
in the next few days.


I've seen such messages coming from an addon only, and apparently only 
once per session.


Petko

--
If you upgrade :  http://www.pmwiki.org/Upgrades


On 14/12/2018 14:51, Hans-Jürgen Godau wrote:

Hello,
on my Arch-System, which updated php to 7.3, I now receive the warnings
*Warning*: "continue" targeting switch is equivalent to "break". Did 
you

mean to use "continue 2"? in *pmwiki.php* on line *739*

*Warning*: "continue" targeting switch is equivalent to "break". Did 
you

mean to use "continue 2"? in *pmwiki.php* on line *742*

looking at the code, i saw that there is no difference in the function 
if

"continue" would be replaced by "break". That would avoid the different
meaning of "continue" in "C" and "php".
diff for pmwki.php:

739c739
< continue;
---

break;

742c742
< continue;
---

break;

Hope this helps,

jürgen


___
pmwiki-users mailing list
pmwiki-users@pmichaud.com
http://www.pmichaud.com/mailman/listinfo/pmwiki-users


[pmwiki-users] warning on continue in pmwiki.php from php 7.3

2018-12-14 Thread Hans-Jürgen Godau
Hello,
on my Arch-System, which updated php to 7.3, I now receive the warnings
*Warning*: "continue" targeting switch is equivalent to "break". Did you
mean to use "continue 2"? in *pmwiki.php* on line *739*

*Warning*: "continue" targeting switch is equivalent to "break". Did you
mean to use "continue 2"? in *pmwiki.php* on line *742*

looking at the code, i saw that there is no difference in the function if
"continue" would be replaced by "break". That would avoid the different
meaning of "continue" in "C" and "php".
diff for pmwki.php:

739c739
< continue;
---
> break;
742c742
< continue;
---
> break;
Hope this helps,

jürgen
___
pmwiki-users mailing list
pmwiki-users@pmichaud.com
http://www.pmichaud.com/mailman/listinfo/pmwiki-users