On Thu, 2014-05-15 at 11:12 +0300, Ilan Zisser wrote:
> Of course it's possible to rename the method like you suggested.
> However, I feel that this method should indeed override the base
> class' Write.
> After looking at the code for the method, I realized that it
> duplicates some of the code fr
Hi,
You're right. I missed that completely.
The reason is that i didn't compile the code. I just assumed that a
method named "Write" should override a similar method in the base
class.
Of course it's possible to rename the method like you suggested.
Ho
On Mon, 2014-05-12 at 15:15 +0300, Ilan Zisser wrote:
> I didn't see this. My revision didn't include PdfSigIncWriter.h.
> The reason for the warning is obvious, missing "virtual" before the
> method Write.
Hi,
it's not that simple, unfortunately. The problem isn't "missing"
'virtual' qu
I didn't see this. My revision didn't include PdfSigIncWriter.h.
The reason for the warning is obvious, missing "virtual" before the
method Write.
A patch is attached.
Ilan
On 5/11/2014 19:15, zyx wrote:
On Mon, 2014-05-05 at 10:20 +03
On Mon, 2014-05-05 at 10:20 +0300, Ilan Zisser wrote:
> Attached is a patch file that modifies PdfWriter.h. It makes PdfWriter
> usable as a base class.
Hi,
I applied the patch to the current trunk and there are new warnings
introduced by the change. Those are:
[ 1%] Building CXX
Hi,
Attached is a patch file that modifies PdfWriter.h. It makes
PdfWriter usable as a base class.
Ilan
On 5/5/2014 10:12, zyx wrote:
On Mon, 2014-05-05 at 10:08 +0300, Ilan Zisser wrote:
No problem. Attached.
On Sun, 2014-05-04 at 17:00 +0300, Ilan Zisser wrote:
> The modified file is attached.
Hi,
Ilan, please, do not provide whole files, provide only patches with your
changes. Replacing whole files may cause changes lost when using
different versions of the sources. If you've PoDoFo checkout
Hi,
I tried to create a subclass of PdfWriter. However, while trying to
do that, I realized that some methods of PdfWriter are not marked as
"virtual" (I'm talking about 4 methods).
The changes are just in the file PdfWrite.h. The modified file is
attached. Seems
