Re: [Podofo-users] [BRANCH] PdfObject automatic ownership handling

2020-02-18 Thread Michal Sudolsky
Hi, - Evaluate deprecation of PdfObject::GetIndirectKey() as same > functionality is now provided directly inside PdfDictionary in > a more consistent API. I think GetIndirectKey is still useful as GetDictionary will throw if object is not dictionary and better is to ignore possibly incorrect

Re: [Podofo-users] [BRANCH] PdfObject automatic ownership handling

2020-02-18 Thread Michal Sudolsky
Hi, There were added two "FIXME" comments like this: - if( rhs.m_pStream && m_pOwner ) - m_pStream = m_pOwner->CreateStream( *(rhs.m_pStream) ); + // FIXME: + // Copying stream is currently broken: + // 1) PdfVecObjects::CreateStream( const PdfStream & ) is broken as it just returns NULL + // 2)