had been there and it
caused ugly failures in runtime.
This had been discussed in the past too, my personal opinion is to get
rid of the autoptr usage in the public API (and internal API as well).
Bye,
zyx
___
Podofo-users mailing list
Pod
ever you compile to), it's just telling you something
about developer documentation, which you can safely ignore. It's at
least what your oversized screenshot shows. Maybe lower in the list are
real compiler warnings.
Bye,
zyx
___
Podofo-us
that definitely isn't, but it can work as a kind-of-example and
save your time.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
compiled with
it on, but the library user had it off (used older C++ standard for
compilation), or vice versa. Usage of -fshort-enums has the same
effect, both the library builder and the library user should use it or
not, not only one of them. If I understand it correctly.
Bye,
. The difference between overlooked
bugs and known bugs is that all the changes in the proposal add new
code, thus it should provide consistent code, not intentionally
partially broken.
Nonetheless, that's only my personal experience with patch reviews and
an off-topic for this mailing list.
branch:
https://sourceforge.net/p/podofo/code/HEAD/tree/podofo/branches/PODOFO_0_9_6_BRANCH/src/base/PdfDefines.h#l211
Do I miss anything there?
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
ss my opinion on the
change.
> I will not complain but I kindly ask you to comment the code with a
> warning so nobody will attempt to change that underlying type anymore
Right, it makes sense to add the comment there. I'm not going to add it
there myself though. Not yet at
user to decide, while there is
not much way to give a hint to the user when it makes (or rather does
not make) sense to do it. Or am I missing anything here?
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists
d it as revision 1956:
http://sourceforge.net/p/podofo/code/1956
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
not know what compiler you use and with which
options, thus maybe you just didn't see it, because your compiler
didn't generate it).
The updated change is committed as revision 1957:
http://sourceforge.net/p/podofo/code/1957
Bye,
zyx
__
er, from my point of view, because
otherwise the API lies about its intention with the stream. I know the
std::ostream variant is 'const', but I didn't change it.
Anyway, your change is committed as revision 1955:
http://sourceforge.net/p/podofo/code/1955
it need to insist on using
> auto_ptr in some places? :)
Hi,
I said:
a) remove from public API,
b) use in private API, only if needed.
It's not the same as what you object to. It doesn't matter what is used
internally, when it doesn't touch public API.
Bye,
zyx
__
gh compiler, or patch and bundle the library on your own"
isn't good option.
For those looking for nitpicks, where I say "compiler" I mean either
compiler or compiler options, and/or C++ standard being
enabled/targeted by the compiler options.
Bye,
zyx
_
th of you,
especially if it can help to fix any issue (or more), without
duplicating the code.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
lem to decrypt that object stream. Evince can open
the file with no problem, but I do not know how much it masks the
issue, if at all.
I tried to delete the part with an update from the end of the doc.pdf
and without it PoDoFo opens the file successfully. That might be a
clue.
Bye,
cument::GetAcroForm() documentation for more
information what that function can do.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
patches for those issues. I suppose you've a good
idea what to do, thus you can receive credits for those changes and
contribute to PoDoFo.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforg
On Thu, 2019-04-04 at 23:26 +0200, Francesco Pretto wrote:
> with at least zyx manifesting a possibile interest in seeing
> the layout changed.
Hi,
that's correct and still is true. I wanted to wait with the change due
to other outstanding patches, most of them being from you. It's
it, I've no problem with that. My only concern
was about pending patches, but if you believe you addressed that, then
there's no other obstacle to do it, at least from my side.
Thanks and bye,
zyx
___
Podofo-users mailing list
Pod
On Sat, 2019-04-06 at 00:18 +0200, Matthew Brincke wrote:
> zyx, you haven't committed them either perchance, just curious?
Hi,
nope, I didn't commit anything of it. The svn log can show it, but I
agree it's a pita to track which commit belongs to which mail, thus no
big deal. After
ess. There might be some
tricks how to recover from broken XRef tables, which PoDoFo doesn't
have many, if any at all.
I do not know what others opinion is.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
think that commit
messages are the place for personal opinions, really. See how Dom, the
PoDoFo maintainer, writes the commit messages. There is some pattern
the project uses for years.
Bye,
zyx
___
Podofo-users mailing list
ection, or there
is something malfunctioning.
Use `./test/unit/podofo-test --selftest` to check yourself. When I
revert the proposed patch all tests pass as expected.
Bye,
zyx
P.S.: relevant output of the podofo-test command:
EncryptTest.cpp:244:Assertion
Test name: Encry
d and how, but it definitely does work:
https://sourceforge.net/p/litepdf/code/HEAD/tree/trunk/src/litePDF.cpp#l1084
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
ion supported by the PDF standard.
I do not know whether any of the PoDoFo tools or examples provide any
such code, I'm sorry. [1]
Bye,
zyx
[1] Something similar, but not the same, is here:
https://litepdf.sourceforge.io/pagesperpage.cpp.h
code simpler.
I'm not sure of the PdfXObject instance ownership, that would need some
runtime testing.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
pper" on top of PoDoFo in this
code, thus you can look into what the litePDF does and mimic that.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
actual PDF content, but I doubt there is
anybody willing to dive into it, or at least I'm not for sure. I'm
sorry.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
e-length-of-the-array in the cycle, but it's not a question for
this change. It's for other places in the code, to do some performance
improvements.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
Hi,
On Thu, 2019-01-24 at 23:34 +0100, Matthew Brincke wrote:
> I have done the commit and it has indeed landed in
> svn r1960 [1] so that ends this discussion.
thanks, I appreciate it.
Bye,
zyx
___
Podofo-users mailin
break anything upstream. Unless, some time later, someone
decides to make Unknown -1 or anything like that. Then, hopefully, the
compiler will claim something, thus it'll be noticed.
Bye,
zyx
The used code follows. It generates compiler warnings with the switch-
es, which is for goo
r from it, but if it's
known that some test does something wrong, then the test should be
fixed. People can use tests to have an idea about what can be done and
how, not talking that the tests are meant to test the code, thus they
should be correct. Just my opinion.
Bye,
bullet-proof the code needs
to work the same in both cases (storage and comparison). And it's not
the case. That's all I wanted to show.
> @zyx: Are you still vetoing that change of Francesco's (making
> Unknown equal to 0xff in EPdfDataType)?
My complain from the past was about the compi
ong as yours:
https://sourceforge.net/p/podofo/tickets/50/
contains the relevant attachments (which it does), there is no need to
spam everyone on the list with them *again*.
Thanks and bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.so
/p/podofo/mailman/message/36667216/
rather than spam this list with more data, which you already attached
elsewhere and which you can safely reference, rather than resend.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.
e
from the times when the ticketing in the SourceForge was not used at
all.
In any case, thanks for reporting it.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
elopment files for boost would be available. That
would make Boost a real optional dependency.
By the way, PoDoFo's README covers many interesting things, from my
point of view. Good job of its author.
Bye,
zyx
___
Podofo-u
src
.
CMakeLists.txt
.
podofo-debug
Note the podofo-src and podofo-debug are at the same level. Whenever I
say "checkout" above, it can be replaced with "unpack tarball with
sources".
Bye,
zyx
[1]
https://sou
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
pilers, which
do not support vector::data(). Search for
// MSC before VC11 has no data member, same as BorlandC
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
DoFo is an Open Source project, it cannot be
hidden anywhere.
I'm sorry if I missed anything obvious in your question.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
with TIFFClose.
>
> But C++ way is much better and far less error prone.
Definitely, I agree.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
ciated, once it's approved.
Thank your for your work on this.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
you use, please?
I recall a bug about CMap generation in the past. Maybe try svn trunk
to see whether it's fixed.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
t; something on the first page. How can I re-paint on the first ?
Hi,
try to use PdfMemDocument, it allows changes in random order. The
PdfSteamedDocument writes things to the disk as soon as it can, which
means you can do only "serialized" changes, in a strict order.
Hi,
I guess you missed the tools/ directory of the sources, because it
contains an image extractor (kind of common PDF tool, I'd say).
https://sourceforge.net/p/podofo/code/HEAD/tree/podofo/trunk/tools/podofoimgextract/
Bye,
zyx
__
Unix Makefiles" \
-DCMAKE_INSTALL_PREFIX=/some/path/to/install/podofo \
-DCMAKE_BUILD_TYPE=Debug \
-DPODOFO_BUILD_SHARED=ON \
..
Even when I use:
-DPODOFO_BUILD_SHARED=OFF \
-DPODOFO_BUILD_STATIC=ON \
then it works fine here.
mework and study on your own. I'm sorry.
By the way, PDF supports watermarks, which are for these things (if I
understood correctly what you want to achieve).
Bye,
zyx
[1] https://litepdf.sourceforge.io/drawtoresource.cpp.html
___
Podofo-us
g similar with the '_Val'.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
r.
Ideas?
Thanks and bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
imilar time frame or
slightly later (I'm also kind of behind PoDoFo development at the
moment), say mid or the second half of this year's March (supposing
nothing more urgent won't step in on my side).
Thanks and bye,
zyx
___
Podofo
e been thinking of was to provide something similar to
PdfError::EnableLogging() and PdfError::EnableDebug(). That would work
fine, no?
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourcefor
hanges.
Thanks and bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
due to the default being changed
(and one really minor coding style "violence").
I didn't try to build this yet, but I do not expect any problem with
it. I'll commit this (updated) after Francesco changes land.
Thanks again and bye
is can be done separately.
I left the decision to John, if he wants to extend his patch I'm not
against it, but I'm also not forcing him to do it.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
ice it, even when re-reading the change before
committing. I mean, I do not blame anyone, I know these things happen.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
r the new version?
Do you have commit rights? If not, then share your patch, please.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
you used a different address.
Anyway, the patch looks good. I can commit it some time later, ideally
after Francesco Pretto changes.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.
I, it also
depends which standard the user of the library relies on.
An ideal solution, from my point of view, would be to stop using
auto_ptr in the public API completely. None of the two offered patches
do that.
Bye,
zyx
___
Podofo-users m
sorry), thus I hoped you'd finally merge the change
yourself too. If not, then no problem, just let me know (through the
list) and I'll do it myself.
Thanks and bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
. I didn't test it in action.
My fault.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
On Mon, 2019-11-04 at 08:53 +0100, zyx wrote:
> I can give it some smoke testing in my environment, both with
> internal PoDoFo test suite and from the litePDF side (just one
> project, which builds on top of the PoDoFo), but I cannot promise
> when it'll be. It can take a long time.
search). The patch looks fine. I'd
commit it after Francesco changes [1].
Bye,
zyx
[1] https://sourceforge.net/p/podofo/mailman/message/36667522/
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net
g "m_pParser->GetStream()" (and this
> m_pParser has its own m_pEncrypt of course).
Hi,
thanks for the patch. I do not have answers for your questions, but the
code change looks fine, thus I committed it as r2006:
http://sourceforge.net/p/podofo/code/20
On Tue, 2020-02-04 at 09:16 +0100, zyx wrote:
> An ideal solution, from my point of view, would be to stop using
> auto_ptr in the public API completely.
Hi,
I went ahead and removed usage of std::auto_ptr from the public API.
It's committed as r2007:
http://sourceforge.net/p/podof
again for your work on this.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
hus I committed it as r2005:
http://sourceforge.net/p/podofo/code/2005
It will be appreciated, if you'd like to continue with the other work
you mentioned in your original mail.
Thanks and bye,
zyx
___
Podofo-users
cut for some reason.
Having there a way to know whether password is needed is required, no
doubt. I would not drop the current call-flow though, as many library
users rely on it.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@
On Mon, 2020-03-02 at 21:32 +0100, Michal Sudolsky wrote:
> Patch attached.
Hi,
thanks for the patch, I committed it as r2002:
http://sourceforge.net/p/podofo/code/2002
Bye,
zyx
___
Podofo-users mailing list
Podofo-us
ception from MustGetIndirectKey than to crash
> due to accessing invalid memory.
Hi,
thanks for the patch, I committed it as r2003:
http://sourceforge.net/p/podofo/code/2003
Bye,
zyx
___
Podofo-users mailing li
004:
http://sourceforge.net/p/podofo/code/2004
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
/code/2000
Thank you for your work, Francesco.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
On Thu, 2020-02-27 at 20:19 +0100, John Senneker wrote:
> Good catch. Here’s the patch with that code added back.
Hi,
I committed slightly modified patch to sources as r2001:
http://sourceforge.net/p/podofo/code/2001
Thank you, John, for your work on this.
Bye,
hich you can use. Check its --help page, which gives an extensive
information about the possible arguments.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
s,
and even I didn't promise an exact date, I still feel like I failed
here. I may check the patches semi-soon, unless someone else will be
quicker. Thank you for your patience.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
own. I never understood PoDoFo as a library for
easier rendering of the PDF content.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
On Thu, 2020-09-24 at 14:11 +0200, Josef Rokos wrote:
> Hi,
> ...
Hi,
thanks for the patches. They look good, from my point of view.
I committed them as r2015 and r2016:
http://sourceforge.net/p/podofo/code/2015
http://sourceforge.net/p/podofo/code/2016
Bye,
y, std::auto_ptr() doesn't provide 'free' function, thus I
created a private class for it. Not as great as I hoped. Anyway, it's
committed as r2014:
http://sourceforge.net/p/podofo/code/2014
Thanks and bye,
zyx
___
Podofo-users mailing list
me
exhibited the issue on a Windows machine. Again, my memory is rusty.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
On Thu, 2020-08-13 at 20:57 +0200, Michal Sudolsky wrote:
> I am just curious so who is now the decision maker for podofo?
Hi,
as far as I know, it's still Dominik, the PoDoFo author.
Bye,
zyx
___
Podofo-users mailing l
. The current trunk
contains PODOFO_HAVE_UNIQUE_PTR, which should be used here;
d) what is your real name, please? It'll be used in credits for
the change.
Could you address the above concerns, update the patch and resend it,
please?
Thanks a
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
not, I might have just commit rights.
Anyway, by any chance, do you have a list of those, please? I tried to
clean up the tickets, but then I realized there's a big mess in them,
then I just gave up. I'm sorry.
Bye,
zyx
___
Podofo-users m
t; 26 [-Wformat-truncation=]
> 205 | snprintf( m_szDate, PDF_DATE_BUFFER_SIZE, "%s%s'00'",
> szDate, szZone );
This one is not claimed by clang here.
I use the same warning flags for both compilers.
Bye,
zyx
P.S.: by the way, would you mind to reply to list instead
support reply to list, to not make your life
harder? The situation of having you or me life harder is not ideal by
any means.
Thanks and bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
e
PODOFO_UNUSED_PARAM( lua )
#endif // PODOFO_HAVE_LUA
I do see unused parameter warnings from other functions, thus it is
enabled here.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
On Wed, 2019-01-23 at 14:53 -0500, 贾相堃 wrote:
> Hi,I tried to fuzz program podofopdfinfo and get the following asan
> report.
Hi,
just for the record, this had been addressed by mabri in r1969:
https://sourceforge.net/p/podofo/code/1969
Bye,
.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
The watermarks have their
intention/usage, removing them might "break" the intention. I'm not the
decision maker here, I'm just saying my personal opinion.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
tream forks of
itself. If the code is good enough it, should be proposed by the fork
owner and eventually merged back to the upstream repository instead.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://
On Tue, 2020-06-16 at 11:08 +0200, Michal Sudolsky wrote:
> Svn patch attached
Hi,
thank you both. I committed the patch as [r2013], with credits to
Ferdinand.
Bye,
zyx
[r2013] http://sourceforge.net/p/podofo/code/2
my personal opinion, I'm not the decision maker here.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
in PdfFontFactoryBase14Data.h,
which is included in the top of the PdfFontMetricsBase14.cpp.
What is the compiler you use and its version, please? This works fine
with gcc 10.1.1. Maybe it begun with certain C++ standard? Though even
that would look w
DoFo's podofosign sources
and let everyone benefit from your changes "out of the box"?
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
e/2011
Thanks and bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
I see. Once the bits will be publicly available and considered stable
you can propose a patch. Possibly making it a conditional compile,
and/or with added podofosign arguments.
Thanks and bye,
zyx
___
Podofo-users mailing list
someone
from your compiler developers to know for sure.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
he PdfPainter) you'll find a code, which adds images as
well.
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
e
CMake invocation part does.
For the reference:
https://sourceforge.net/p/podofo/code/HEAD/tree/podofo/trunk/README.html#l244
Bye,
zyx
___
Podofo-users mailing list
Podofo-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/podofo-users
401 - 500 of 603 matches
Mail list logo
