Re: [Podofo-users] Patch to handle indirect ID in trailer

2018-11-01 Thread BLANCHARD Christophe
I fully agree with that. Cordialement/Best Regards, Christophe Blanchard -Message d'origine- De : zyx Envoyé : jeudi 1 novembre 2018 11:09 À : podofo-users@lists.sourceforge.net Objet : Re: [Podofo-users] Patch to handle indirect ID in trailer On Wed, 2018-10-31 at 23:14 +0100, Matthew

Re: [Podofo-users] Patch to handle indirect ID in trailer

2018-11-01 Thread Olivier Mascia
> Le 1 nov. 2018 à 11:09, zyx a écrit : > > On Wed, 2018-10-31 at 23:14 +0100, Matthew Brincke wrote: >> IHMO yes, because if it were encrypted, an indirect ID would be >> against the PDF standard, right? I think that should be caught ... > > Hi, > even it would be against the standard,

Re: [Podofo-users] Patch to handle indirect ID in trailer

2018-11-01 Thread zyx
On Wed, 2018-10-31 at 23:14 +0100, Matthew Brincke wrote: > IHMO yes, because if it were encrypted, an indirect ID would be > against the PDF standard, right? I think that should be caught ... Hi, even it would be against the standard, PoDoFo is not a validator, it might not panic if

Re: [Podofo-users] Patch to handle indirect ID in trailer

2018-10-31 Thread Matthew Brincke
Hello Clayton, hello zyx, hello all, > On 30 October 2018 at 18:34 Clayton Wheeler wrote: > ... snip ... > the typo in that comment, but I rewrote it after a closer reading of section > 7.5.5 anyway; it implies the ID can be indirect when a PDF is unencrypted. > what the patch doesn't do is

Re: [Podofo-users] Patch to handle indirect ID in trailer

2018-10-31 Thread zyx
On Tue, 2018-10-30 at 12:34 -0500, Clayton Wheeler wrote: > Here's a fixed (and properly tested) version. Hi, thanks for the patch update. It looks fine, thus I committed it as revision 1947: http://sourceforge.net/p/podofo/code/1947 Bye, zyx

Re: [Podofo-users] Patch to handle indirect ID in trailer

2018-10-30 Thread Clayton Wheeler
Hi zyx, [re-sending this to the list, sent it as a direct reply by mistake] You're right, sorry, I only checked my last round of changes with a production build by mistake. Here's a fixed (and properly tested) version. I couldn't spot the typo in that comment, but I rewrote it after a closer

Re: [Podofo-users] Patch to handle indirect ID in trailer

2018-10-27 Thread zyx
On Thu, 2018-10-18 at 17:43 -0500, Clayton Wheeler wrote: > Does this seem sensible? Hi, the idea sounds good, but the patch doesn't compile. I guess you made some changes just before creating the patch, but you didn't compile the code, because otherwise you'd notice it. There's also a

[Podofo-users] Patch to handle indirect ID in trailer

2018-10-18 Thread Clayton Wheeler
Hello, While using PoDoFo, I've encountered some slightly non-compliant PDFs with an ID entry in the trailer stored as an indirect object, when the spec mandates that it be a direct object. (At least one of the offending files was from QuarkXPress on Mac OS X 10.3; this may not be a widespread