Re: [poppler] reconsideration about iconv() in cpp frontend

Dear Adam, Albert, Thank you very much for taking care on this. Albert Astals Cid wrote: > El dilluns, 16 d’abril de 2018, a les 19:11:01 CEST, Adam Reichold va > escriure: >> I really think that poppler::ustring defined as >> >> std::basic_string >> >> is already broken where sizeof(unsigned

[poppler] 2 commits - poppler/Link.h poppler/OutputDev.h

poppler/Link.h |4 ++-- poppler/OutputDev.h |7 ++- 2 files changed, 8 insertions(+), 3 deletions(-) New commits: commit 97aa11bf135421c1f87f2a46e2f597626f503f10 Author: Oliver Sander Date: Fri Mar 23 22:04:11 2018 +0100 Document method

Re: [poppler] 7 commits - CMakeLists.txt cpp/CMakeLists.txt poppler/GfxState.cc poppler/Link.cc poppler/Link.h qt5/src

El dilluns, 16 d’abril de 2018, a les 22:42:06 CEST, Adam Reichold va escriure: > Am 16.04.2018 um 22:21 schrieb Albert Astals Cid: > > El dilluns, 16 d’abril de 2018, a les 20:36:37 CEST, Adam Reichold va > > > > escriure: > >> Hello again, > >> > >> Am 16.04.2018 um 20:22 schrieb Albert

Re: [poppler] 7 commits - CMakeLists.txt cpp/CMakeLists.txt poppler/GfxState.cc poppler/Link.cc poppler/Link.h qt5/src

Am 16.04.2018 um 22:21 schrieb Albert Astals Cid: > El dilluns, 16 d’abril de 2018, a les 20:36:37 CEST, Adam Reichold va > escriure: >> Hello again, >> >> Am 16.04.2018 um 20:22 schrieb Albert Astals Cid: >>> El dilluns, 16 d’abril de 2018, a les 19:05:25 CEST, Adam Reichold va >>> >>>

Re: [poppler] reconsideration about iconv() in cpp frontend

El dilluns, 16 d’abril de 2018, a les 19:11:01 CEST, Adam Reichold va escriure: > Hello again, > > I really think that poppler::ustring defined as > > std::basic_string > > is already broken where sizeof(unsigned short) != 2 and hence should be > redefined to > > std::basic_string > >

[poppler] poppler/Link.cc poppler/Link.h

poppler/Link.cc | 22 +++--- poppler/Link.h |5 +++-- 2 files changed, 14 insertions(+), 13 deletions(-) New commits: commit 444d9d8de5d4f8d627084405e1583b6d6d3900c7 Author: Albert Astals Cid Date: Mon Apr 16 22:28:18 2018 +0200 Simplify

Re: [poppler] 7 commits - CMakeLists.txt cpp/CMakeLists.txt poppler/GfxState.cc poppler/Link.cc poppler/Link.h qt5/src

El dilluns, 16 d’abril de 2018, a les 20:36:37 CEST, Adam Reichold va escriure: > Hello again, > > Am 16.04.2018 um 20:22 schrieb Albert Astals Cid: > > El dilluns, 16 d’abril de 2018, a les 19:05:25 CEST, Adam Reichold va > > > > escriure: > >> Hello, > >> > >> concerning

Re: [poppler] 7 commits - CMakeLists.txt cpp/CMakeLists.txt poppler/GfxState.cc poppler/Link.cc poppler/Link.h qt5/src

Hello again, Am 16.04.2018 um 20:22 schrieb Albert Astals Cid: > El dilluns, 16 d’abril de 2018, a les 19:05:25 CEST, Adam Reichold va > escriure: >> Hello, >> >> concerning df8a4ee51e18a39f85568c4122e5edd8c03d61df, I think there is a >> problem in the "isArray" branch where a moved-from value

Re: [poppler] 7 commits - CMakeLists.txt cpp/CMakeLists.txt poppler/GfxState.cc poppler/Link.cc poppler/Link.h qt5/src

El dilluns, 16 d’abril de 2018, a les 19:05:25 CEST, Adam Reichold va escriure: > Hello, > > concerning df8a4ee51e18a39f85568c4122e5edd8c03d61df, I think there is a > problem in the "isArray" branch where a moved-from value > "seenNextActions" is used if the array contains more than one dict. I

Re: [poppler] reconsideration about iconv() in cpp frontend

Hello again, I really think that poppler::ustring defined as std::basic_string is already broken where sizeof(unsigned short) != 2 and hence should be redefined to std::basic_string without considering that an API break. This then also allows to just use these buffers acquired using

Re: [poppler] 7 commits - CMakeLists.txt cpp/CMakeLists.txt poppler/GfxState.cc poppler/Link.cc poppler/Link.h qt5/src

Hello, concerning df8a4ee51e18a39f85568c4122e5edd8c03d61df, I think there is a problem in the "isArray" branch where a moved-from value "seenNextActions" is used if the array contains more than one dict. I think this is generally undefined behavior (even though it is probably fine in this case

Re: [poppler] reconsideration about iconv() in cpp frontend

Adam Reichold wrote: >> A) use the functions in UTF.h, and change ustring class >> to fit them. >> B) rewrite the functions in UTF.h by template programming >> and have the interfaces fitting to current ustring(). >> C) write diversions of the functions in UTF.h in cpp frontend. > > I think

[poppler] 7 commits - CMakeLists.txt cpp/CMakeLists.txt poppler/GfxState.cc poppler/Link.cc poppler/Link.h qt5/src

CMakeLists.txt |7 ++ cpp/CMakeLists.txt |1 poppler/GfxState.cc|5 + poppler/Link.cc| 103 - poppler/Link.h | 54 - qt5/src/poppler-annotation.cc |