Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

El diumenge, 4 de març de 2018, a les 9:21:49 CET, Adam Reichold va escriure: > Hello Albert, > > Am 03.03.2018 um 23:26 schrieb Albert Astals Cid: > > El dissabte, 3 de març de 2018, a les 21:15:48 CET, Adam Reichold va escriure: > >> And this time around, without a bunch of typos... Sorry for

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Adam Reichold wrote: Hello mpsuzuki, Am 04.03.2018 um 06:11 schrieb suzuki toshiya: Dear Albert & Adam, I'm fine with that, but you're going to need to send a patch against poppler git not against mpsuzuki's repo if you want inclusion upstream :) Indeed, and sorry, I should add another

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Hello mpsuzuki, Am 04.03.2018 um 06:11 schrieb suzuki toshiya: > Dear Albert & Adam, > >> I'm fine with that, but you're going to need to send a patch against >> poppler git not against mpsuzuki's repo if you want inclusion upstream :) > > Indeed, and sorry, I should add another point. The

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Dear Albert & Adam, I'm fine with that, but you're going to need to send a patch against poppler git not against mpsuzuki's repo if you want inclusion upstream :) Indeed, and sorry, I should add another point. Jeroen found the textlist patch for cpp frontend causes linker error on Mac OS X,

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

El dissabte, 3 de març de 2018, a les 21:15:48 CET, Adam Reichold va escriure: > And this time around, without a bunch of typos... Sorry for the noise. Wouldn't it make more sense to have the void_t definition in the anonymous namespace in gfile.cc for now until we really need to use it

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

And this time around, without a bunch of typos... Sorry for the noise. Am 03.03.2018 um 21:03 schrieb Adam Reichold: > Hello again, > > attached is a patch against master that fixes the Clang/libc++ linking > issue with the cpp frontend's text_box_data destructor and the > non-standard

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Hello again, attached is a patch against master that fixes the Clang/libc++ linking issue with the cpp frontend's text_box_data destructor and the non-standard high-resolution mtime field name on Mac OS X. Best regards, Adam. Am 03.03.2018 um 20:18 schrieb Albert Astals Cid: > El divendres, 2

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

El divendres, 2 de març de 2018, a les 13:24:37 CET, suzuki toshiya va escriure: > Dear Adam, > > Thank you always for rewriting in C++ way! > > > If you are uncomfortable with the CMake- and preprocessor-based > > solution, you can solve such issues using templates as shown in > > > >

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Dear Adam, Thank you always for rewriting in C++ way! > If you are uncomfortable with the CMake- and preprocessor-based > solution, you can solve such issues using templates as shown in > > https://github.com/adamreichold/poppler/commit/68f46dce62ad97bdbb22bf79ac50c128d899a302 Waao, it looks

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Hello, If it works on POSIX and builds on Darwin, it looks good to me. What I would like would be else clauses in the CMake and preprocessor definitions that give proper error messages. (Or maybe use the POSIX variant as the default and only use mtimespec if as an override.) If you are

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Hi, It seems that the counterpart in macOS libc corresponding to stat.st_mtim is stat.st_mtimespec. https://opensource.apple.com/source/xnu/xnu-201.5/bsd/sys/stat.h.auto.html I wrote a patch testing st_mtim availability by CHECK_STRUCT_HAS_MEMBER() suggested by William, and also testing

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

Can you test for it in cmake? https://cmake.org/cmake/help/v3.0/module/CheckStructHasMember.html From: poppler on behalf of Jeroen Ooms Sent: Sunday, February 18, 2018 6:29 PM To: Ihar Filipau Cc:

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

On Mon, Feb 12, 2018 at 3:04 PM, Ihar Filipau wrote: > On 2/12/18, Jeroen Ooms wrote: >> On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid wrote: >>> You're never assigning to tv_nsec in there but still use it in a >>> comparison, >>>

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

On 2/12/18, Jeroen Ooms wrote: > On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid wrote: >> You're never assigning to tv_nsec in there but still use it in a >> comparison, >> that needs fixing. > > You are right. I think we should compare modification time

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid wrote: > You're never assigning to tv_nsec in there but still use it in a comparison, > that needs fixing. You are right. I think we should compare modification time only by seconds. The standard definition of 'struct stat' only

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

El diumenge, 11 de febrer de 2018, a les 13:18:51 CET, Jeroen Ooms va escriure: > Can you please help fix the patch so that we can build on osx again? I > don't fully understand the internals, the patch was only a suggestion. I don't have a access to a osx machine, so that's going to be hard.

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

El divendres, 9 de febrer de 2018, a les 21:08:39 CET, Jeroen Ooms va escriure: > After recent changes (after 0.62) the master branch no longer builds > on macos. The issue is that the statbuf struct does not have an > "st_mtim" field on macos: > > [ 0%] Building CXX object

[poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

After recent changes (after 0.62) the master branch no longer builds on macos. The issue is that the statbuf struct does not have an "st_mtim" field on macos: [ 0%] Building CXX object CMakeFiles/poppler.dir/goo/gfile.cc.o /Users/jeroen/Desktop/popplergit/goo/gfile.cc:690:34: error: no member