Re: [poppler] Do we want to enable readability-braces-around-statements ?

2022-03-03 Thread Oliver Sander
John's answer below quite exactly reflects my own opinion about this. Best, Oliver On 03.03.22 09:59, jcup...@gmail.com wrote: gcc at least (clang too I think) will warn for misleading indentation, so I think forcing braces probably won't add much extra safety. Braces for single lines adds

Re: [poppler] Do we want to enable readability-braces-around-statements ?

2022-03-03 Thread jcupitt
gcc at least (clang too I think) will warn for misleading indentation, so I think forcing braces probably won't add much extra safety. Braces for single lines adds extra visual noise and reduces the code you can see at a glance, so some people argue there's actually a small downside to using

[poppler] Do we want to enable readability-braces-around-statements ?

2022-03-02 Thread Albert Astals Cid
It forces to add a pair of {} to all if/for/while/etc https://gitlab.freedesktop.org/poppler/poppler/-/merge_requests/1091 (it fails in Qt autogenerated files for now, i can fix that if we agree we want it) I can see it being potentially annoying when CI fails because of this but on the other