Re: [poppler] reconsideration about iconv() in cpp frontend

2018-05-05 Thread Adam Reichold
Hello mpsuzuki, Am 26.04.2018 um 19:03 schrieb suzuki toshiya: > Dear Adam, > > Thank you for review & comment, and sorry for lated response. > > Adam Reichold wrote: >> I like it. Some minor remarks: >> >> * Is this the only user of iconv within Poppler? If so, we could remove >> it from the

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-26 Thread suzuki toshiya
Dear Adam, Thank you for review & comment, and sorry for lated response. Adam Reichold wrote: > I like it. Some minor remarks: > > * Is this the only user of iconv within Poppler? If so, we could remove > it from the build system as wel. OK. > * In "ustring::to_utf8": > - "utf16_end" is

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-17 Thread Adam Reichold
Hello, Am 18.04.2018 um 06:35 schrieb suzuki toshiya: > Albert Astals Cid wrote: Sure, is there any system where sizeof(unsigned short) != 2 anyway? >>> Maybe people feel "such system is out of scope", but there were: >>>

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-17 Thread suzuki toshiya
Albert Astals Cid wrote: >>> Sure, is there any system where sizeof(unsigned short) != 2 anyway? >> Maybe people feel "such system is out of scope", but there were: >> https://web.archive.org/web/20090408221917/http://www.zib.de/benger/hdf5/Dat >> atypes.html according to the description for

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-17 Thread Albert Astals Cid
El dimarts, 17 d’abril de 2018, a les 3:24:09 CEST, suzuki toshiya va escriure: > Dear Adam, Albert, > > Thank you very much for taking care on this. > > Albert Astals Cid wrote: > > El dilluns, 16 d’abril de 2018, a les 19:11:01 CEST, Adam Reichold va > > > > escriure: > >> I really think

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-16 Thread suzuki toshiya
Dear Adam, Albert, Thank you very much for taking care on this. Albert Astals Cid wrote: > El dilluns, 16 d’abril de 2018, a les 19:11:01 CEST, Adam Reichold va > escriure: >> I really think that poppler::ustring defined as >> >> std::basic_string >> >> is already broken where sizeof(unsigned

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-16 Thread Albert Astals Cid
El dilluns, 16 d’abril de 2018, a les 19:11:01 CEST, Adam Reichold va escriure: > Hello again, > > I really think that poppler::ustring defined as > > std::basic_string > > is already broken where sizeof(unsigned short) != 2 and hence should be > redefined to > > std::basic_string > >

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-16 Thread Adam Reichold
Hello again, I really think that poppler::ustring defined as std::basic_string is already broken where sizeof(unsigned short) != 2 and hence should be redefined to std::basic_string without considering that an API break. This then also allows to just use these buffers acquired using

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-16 Thread suzuki toshiya
Adam Reichold wrote: >> A) use the functions in UTF.h, and change ustring class >> to fit them. >> B) rewrite the functions in UTF.h by template programming >> and have the interfaces fitting to current ustring(). >> C) write diversions of the functions in UTF.h in cpp frontend. > > I think

Re: [poppler] reconsideration about iconv() in cpp frontend

2018-04-15 Thread Adam Reichold
Hello, Am 15.04.2018 um 05:08 schrieb suzuki toshiya: > Hi, > > Now I'm reworking with cpp-frontend encoding issue, and found that: > previous patch fixes the issue for text drawn in a PDF, but does > not fix the broken metadata if it is coded by PDFDocEncoding > (sample PDF is attached). > >

[poppler] reconsideration about iconv() in cpp frontend

2018-04-14 Thread suzuki toshiya
Hi, Now I'm reworking with cpp-frontend encoding issue, and found that: previous patch fixes the issue for text drawn in a PDF, but does not fix the broken metadata if it is coded by PDFDocEncoding (sample PDF is attached). During the rework, I'm becoming questionable about the usage of iconv()