Re: [poppler] Do we want to enable readability-braces-around-statements ?

2022-03-03 Thread jcupitt
gcc at least (clang too I think) will warn for misleading indentation, so I think forcing braces probably won't add much extra safety. Braces for single lines adds extra visual noise and reduces the code you can see at a glance, so some people argue there's actually a small downside to using

[poppler] qt5/src qt6/src

2022-03-03 Thread GitLab Mirror
qt5/src/poppler-annotation.cc |3 +++ qt5/src/poppler-link.h|5 +++-- qt5/src/poppler-page.cc |7 +-- qt6/src/poppler-link.h|5 +++-- qt6/src/poppler-page.cc |7 +-- 5 files changed, 19 insertions(+), 8 deletions(-) New commits: commit

[poppler] qt5/src qt6/src

2022-03-03 Thread GitLab Mirror
qt5/src/poppler-annotation.cc |2 ++ qt6/src/poppler-annotation.cc |2 ++ 2 files changed, 4 insertions(+) New commits: commit 1c1553142de667a10949ac17d9f9f609f1a23832 Author: Albert Astals Cid Date: Thu Mar 3 17:30:15 2022 +0100 qt: Add qWarnings for non supported scenarios

Re: [poppler] Do we want to enable readability-braces-around-statements ?

2022-03-03 Thread Oliver Sander
John's answer below quite exactly reflects my own opinion about this. Best, Oliver On 03.03.22 09:59, jcup...@gmail.com wrote: gcc at least (clang too I think) will warn for misleading indentation, so I think forcing braces probably won't add much extra safety. Braces for single lines adds