Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-04 Thread Albert Astals Cid
damreichold/poppler/builds/348193138 > >>>>>> > >>>>>> Best regards, Adam. > >>>>>> > >>>>>> Am 02.03.2018 um 03:34 schrieb suzuki toshiya: > >>>>>>> Hi, > >>>>>>>

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-04 Thread Adam Reichold
;>> >>>>>> Am 02.03.2018 um 03:34 schrieb suzuki toshiya: >>>>>>> Hi, >>>>>>> >>>>>>> It seems that the counterpart in macOS libc corresponding to >>>>>>> stat.st_mtim is stat.st_mtimespec. >>

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-04 Thread suzuki toshiya
pler on behalf of Jeroen Ooms Sent: Sunday, February 18, 2018 6:29 PM To: Ihar Filipau Cc: poppler@lists.freedesktop.org Subject: Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim>>> On Mon, Feb 12, 2018 at 3:04 PM, Ihar Filipau wrote: On 2/12/18, Jeroen Ooms

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-04 Thread Adam Reichold
ested by William, and also testing st_mtimespec too, and reflect >>>>> the result to the macro GET_MTIM_FROM_STATBUF(). >>>>> https://github.com/mpsuzuki/poppler/commit/79d00ac08d672d572a7ec310b5a27e >>>>> >>>>> b66c956e4c >>>>

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-03 Thread suzuki toshiya
M, William Bader wrote: Can you test for it in cmake? https://cmake.org/cmake/help/v3.0/module/CheckStructHasMember.html From: poppler on behalf of Jeroen Ooms Sent: Sunday, February 18, 2018 6:29 PM To: Ihar Filipau Cc: poppler@lists.freedesktop.org Subject: Re: [popp

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-03 Thread Albert Astals Cid
>>>>> I wrote a patch testing st_mtim availability by > >>>>> CHECK_STRUCT_HAS_MEMBER() > >>>>> suggested by William, and also testing st_mtimespec too, and reflect > >>>>> the result to the macro GET_MTIM_FROM_STATBUF(). > >>>>> h

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-03 Thread Adam Reichold
>>>> the result to the macro GET_MTIM_FROM_STATBUF(). >>>>> https://github.com/mpsuzuki/poppler/commit/79d00ac08d672d572a7ec310b5a27e >>>>> b66c956e4c >>>>> >>>>> Building on travis-ci.org finishes successfully. Yet I'm >

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-03 Thread Adam Reichold
10b5a27e >>>> b66c956e4c >>>> >>>> Building on travis-ci.org finishes successfully. Yet I'm >>>> unsure such macro is following to the coding style of poppler. >>>> Also if anybody has a testing code to evaluate the code works >

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-03 Thread Albert Astals Cid
testing code to evaluate the code works > >> well (do you have to make 2 file with nsec difference of the > >> timestamp?). Please give me comment... > >> > >> Regards, > >> mpsuzuki > >> > >> On 2/19/2018 1:42 PM, William Bader wrote: &

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-02 Thread suzuki toshiya
in cmake? >>> https://cmake.org/cmake/help/v3.0/module/CheckStructHasMember.html >>> >>> ________ >>> From: poppler on behalf of Jeroen >>> Ooms >>> Sent: Sunday, February 18, 2018 6:29 PM >>> To: Ihar Filipau >

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-02 Thread Adam Reichold
oms >> Sent: Sunday, February 18, 2018 6:29 PM >> To: Ihar Filipau >> Cc: poppler@lists.freedesktop.org >> Subject: Re: [poppler] gfile.cc fails to build on macos due to >> statbuf.st_mtim >> >> On Mon, Feb 12, 2018 at 3:04 PM, Ihar Filipau wrote: >>

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-03-01 Thread suzuki toshiya
v3.0/module/CheckStructHasMember.html > > > From: poppler on behalf of Jeroen > Ooms > Sent: Sunday, February 18, 2018 6:29 PM > To: Ihar Filipau > Cc: poppler@lists.freedesktop.org > Subject: Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mti

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-02-18 Thread William Bader
fails to build on macos due to statbuf.st_mtim On Mon, Feb 12, 2018 at 3:04 PM, Ihar Filipau wrote: > On 2/12/18, Jeroen Ooms wrote: >> On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid wrote: >>> You're never assigning to tv_nsec in there but still use it in a >>

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-02-18 Thread Jeroen Ooms
On Mon, Feb 12, 2018 at 3:04 PM, Ihar Filipau wrote: > On 2/12/18, Jeroen Ooms wrote: >> On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid wrote: >>> You're never assigning to tv_nsec in there but still use it in a >>> comparison, >>> that needs fixing. >> >> You are right. I think we should c

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-02-12 Thread Ihar Filipau
On 2/12/18, Jeroen Ooms wrote: > On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid wrote: >> You're never assigning to tv_nsec in there but still use it in a >> comparison, >> that needs fixing. > > You are right. I think we should compare modification time only by > seconds. The standard defin

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-02-12 Thread Jeroen Ooms
On Sun, Feb 11, 2018 at 12:11 PM, Albert Astals Cid wrote: > You're never assigning to tv_nsec in there but still use it in a comparison, > that needs fixing. You are right. I think we should compare modification time only by seconds. The standard definition of 'struct stat' only specifies st_cti

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-02-11 Thread Albert Astals Cid
El diumenge, 11 de febrer de 2018, a les 13:18:51 CET, Jeroen Ooms va escriure: > Can you please help fix the patch so that we can build on osx again? I > don't fully understand the internals, the patch was only a suggestion. I don't have a access to a osx machine, so that's going to be hard. Ch

Re: [poppler] gfile.cc fails to build on macos due to statbuf.st_mtim

2018-02-11 Thread Albert Astals Cid
El divendres, 9 de febrer de 2018, a les 21:08:39 CET, Jeroen Ooms va escriure: > After recent changes (after 0.62) the master branch no longer builds > on macos. The issue is that the statbuf struct does not have an > "st_mtim" field on macos: > > [ 0%] Building CXX object CMakeFiles/poppler.di