Re: [UPDATE] textproc/pdfgrep

2017-03-15 Thread Theo Buehler
On Mon, Mar 06, 2017 at 06:18:15PM +0100, Reinhold Straub wrote: > Hi all, > > pdfgrep has been updated to v. 2.0.1 > > It has a new option: --cache, which needs additional dependencies and some > modification to the pledge(2) syscalls. > > Most of our previous patches have been accepted

Re: [UPDATE] textproc/pdfgrep

2017-03-15 Thread Jeremie Courreges-Anglas
Theo Buehler writes: > On Tue, Mar 14, 2017 at 12:14:42PM +0100, Jeremie Courreges-Anglas wrote: >> Theo Buehler writes: >> >> > On Tue, Mar 14, 2017 at 09:35:37AM +0100, Reinhold Straub wrote: >> >> ok? >> >> >> >> On 06.03.17 18:18, Reinhold Straub

Re: [UPDATE] textproc/pdfgrep

2017-03-14 Thread Theo Buehler
On Tue, Mar 14, 2017 at 09:29:48PM +, Stuart Henderson wrote: > How about killing the wpath pledge if --cache is not used? > It already does that. It's not visible in the diff, but we have: 694 if (options.use_cache) { [...] 704 } else { 705

Re: [UPDATE] textproc/pdfgrep

2017-03-14 Thread Stuart Henderson
How about killing the wpath pledge if --cache is not used? I was a bit confused as to why it needs gcrypt for a caching option... turns out it uses it to SHA1 the contents of the pdf.

Re: [UPDATE] textproc/pdfgrep

2017-03-14 Thread Theo Buehler
On Tue, Mar 14, 2017 at 12:14:42PM +0100, Jeremie Courreges-Anglas wrote: > Theo Buehler writes: > > > On Tue, Mar 14, 2017 at 09:35:37AM +0100, Reinhold Straub wrote: > >> ok? > >> > >> On 06.03.17 18:18, Reinhold Straub wrote: > >> > Hi all, > >> > > >> > pdfgrep has been

Re: [UPDATE] textproc/pdfgrep

2017-03-14 Thread Jeremie Courreges-Anglas
Theo Buehler writes: > On Tue, Mar 14, 2017 at 09:35:37AM +0100, Reinhold Straub wrote: >> ok? >> >> On 06.03.17 18:18, Reinhold Straub wrote: >> > Hi all, >> > >> > pdfgrep has been updated to v. 2.0.1 >> > >> > It has a new option: --cache, which needs additional

Re: [UPDATE] textproc/pdfgrep

2017-03-14 Thread Theo Buehler
On Tue, Mar 14, 2017 at 09:35:37AM +0100, Reinhold Straub wrote: > ok? > > On 06.03.17 18:18, Reinhold Straub wrote: > > Hi all, > > > > pdfgrep has been updated to v. 2.0.1 > > > > It has a new option: --cache, which needs additional dependencies and some > > modification to the pledge(2)

Re: [UPDATE] textproc/pdfgrep

2017-03-14 Thread Reinhold Straub
ok? On 06.03.17 18:18, Reinhold Straub wrote: Hi all, pdfgrep has been updated to v. 2.0.1 It has a new option: --cache, which needs additional dependencies and some modification to the pledge(2) syscalls. Most of our previous patches have been accepted upstream. Regards, Reinhold Straub

[UPDATE] textproc/pdfgrep

2017-03-06 Thread Reinhold Straub
Hi all, pdfgrep has been updated to v. 2.0.1 It has a new option: --cache, which needs additional dependencies and some modification to the pledge(2) syscalls. Most of our previous patches have been accepted upstream. Regards, Reinhold Straub Index: pdfgrep/Makefile

Re: [UPDATE] textproc/pdfgrep

2016-01-15 Thread Dmitrij D. Czarkoff
One test still fails for me: Running ./pdfgrep.tests/regex.exp ... FAIL: Empty pattern -- error from pdfgrep Indeed, when pdfgrep is called with argument "", instead of matching every line it exits with error pdfgrep: empty (sub)expression This happens because our regex(3) doesn't allow

Re: [UPDATE] textproc/pdfgrep

2016-01-15 Thread Stuart Henderson
On 2016/01/15 13:21, Dmitrij D. Czarkoff wrote: > This happens because our regex(3) doesn't allow empty patterns. As far > as I can tell, this behavior is undesirable in something called "*grep", > so I added a quirk for this particular use case. Agreed.

Re: [UPDATE] textproc/pdfgrep

2016-01-15 Thread Stuart Henderson
On 2016/01/15 10:04, Reinhold Straub wrote: > Hi, > > pdfgrep has a testsuite based on devel/dejagnu now. Unfortunately, some > patches are necessary to make tests work on OpenBSD. > > I put pledge(2) calls into the source code, too. Nice. I think the combination of PCRE and (often untrusted)

Re: [UPDATE] textproc/pdfgrep

2016-01-15 Thread Theo Buehler
> + int main(int argc, char** argv) > + { > ++if (pledge("stdio rpath ioctl", NULL) == -1) { > ++fprintf ( stderr, "pdfgrep: pledge\n" ); > ++exit ( 1 ); > ++} This ioctl pledge feels wrong. I only have a lousy internet connection and no gcc 4.9 installed, so I

Re: [UPDATE] textproc/pdfgrep

2016-01-15 Thread Stuart Henderson
On 2016/01/15 13:36, Theo Buehler wrote: > > + int main(int argc, char** argv) > > + { > > ++ if (pledge("stdio rpath ioctl", NULL) == -1) { > > ++ fprintf ( stderr, "pdfgrep: pledge\n" ); > > ++ exit ( 1 ); > > ++ } > > This ioctl pledge feels wrong. I only have a lousy

Re: [UPDATE] textproc/pdfgrep

2016-01-15 Thread Dmitrij D. Czarkoff
Stuart Henderson said: > On 2016/01/15 13:36, Theo Buehler wrote: > > > + int main(int argc, char** argv) > > > + { > > > ++if (pledge("stdio rpath ioctl", NULL) == -1) { > > > ++fprintf ( stderr, "pdfgrep: pledge\n" ); > > > ++exit ( 1 ); > > > ++}

Re: [UPDATE] textproc/pdfgrep

2016-01-15 Thread Stuart Henderson
On 2016/01/15 14:42, Dmitrij D. Czarkoff wrote: > Stuart Henderson said: > > On 2016/01/15 13:36, Theo Buehler wrote: > > > > + int main(int argc, char** argv) > > > > + { > > > > ++ if (pledge("stdio rpath ioctl", NULL) == -1) { > > > > ++ fprintf ( stderr, "pdfgrep: pledge\n"

[UPDATE] textproc/pdfgrep

2016-01-15 Thread Reinhold Straub
Hi, pdfgrep has a testsuite based on devel/dejagnu now. Unfortunately, some patches are necessary to make tests work on OpenBSD. I put pledge(2) calls into the source code, too. Regards, Reinhold Straub Index: Makefile === RCS

Re: [UPDATE] textproc/pdfgrep

2016-01-15 Thread Jiri B
On Fri, Jan 15, 2016 at 10:04:36AM +0100, Reinhold Straub wrote: > Hi, > > pdfgrep has a testsuite based on devel/dejagnu now. Unfortunately, some > patches are necessary to make tests work on OpenBSD. > > I put pledge(2) calls into the source code, too. So where are patches? Did you forget to

Re: [UPDATE] textproc/pdfgrep

2015-08-25 Thread Jérémie Courrèges-Anglas
Reinhold Straub demarc...@web.de writes: Hi, Hi, there is a new version of pdfgrep. Works for me, committed. Minor nit: indentation should use tabs, not spaces. Thanks, -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE

[UPDATE] textproc/pdfgrep

2015-08-25 Thread Reinhold Straub
Hi, there is a new version of pdfgrep. -- Reinhold Straub demarc...@web.de pdfgrep.diff Description: Binary data

[UPDATE] textproc/pdfgrep

2015-06-20 Thread Reinhold Straub
Hi, pdfgrep is hosted on a different server now. Index: Makefile === RCS file: /cvs/ports/textproc/pdfgrep/Makefile,v retrieving revision 1.1.1.1 diff -u -p -r1.1.1.1 Makefile --- Makefile24 Mar 2015 09:57:04 - 1.1.1.1

Re: [UPDATE] textproc/pdfgrep

2015-06-20 Thread Jérémie Courrèges-Anglas
Reinhold Straub demarc...@web.de writes: Hi, pdfgrep is hosted on a different server now. Committed, thanks. For the record the diff didn't apply (whitespace change; copy/paste?) and lacked a REVISION bump (since HOMEPAGE changed). -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC