Re: [update] math/cgal + cad/openscad revision

2023-10-29 Thread Klemens Nanni
10/29/23 20:02, Renato Aguiar пишет: > The math/cgal update is indeed required for updating > cad/prusaslicer. I managed to get a working port for > cad/prusaslicer 2.6.1 by using this diff. > > However, I haven't yet tried to build cad/prusaslicer 2.5.2 > (currently in ports tree) with

Re: [update] math/cgal + cad/openscad revision

2023-10-29 Thread Renato Aguiar
On Sun, Oct 29 2023, Klemens Nanni wrote: If cad/openscad (and cad/prusaslicer most likely as well) require new version to build in the future, I'd add a version spec to the dependency: BUILD_DEPENDS +=math/cgal>=5.6v0 Have you looked into enabling tests for cgal? Would be nice to

Re: [update] math/cgal + cad/openscad revision

2023-10-29 Thread Klemens Nanni
Your diffs apply now, but cad/prusaslicer still has CGAL in WANTLIB. Diff below configures, but fails to build, so you need to handle that before updating math/cgal. If cad/openscad (and cad/prusaslicer most likely as well) require new version to build in the future, I'd add a version spec to the

Re: [update] math/cgal + cad/openscad revision

2023-10-29 Thread Johannes Thyssen Tishman
Oct 23, 2023 07:57:35 Johannes Thyssen Tishman : > Oct 15, 2023 00:10:08 Johannes Thyssen Tishman : > >> Hi Klemens. Thanks for the feedback. >> >>> The existing CMakeLists.txt no longer applies, but it looks like >>> you no longer needed it, perhaps forgot to 'cvs rm -f' it? >> >> Yup,

Re: [update] math/cgal + cad/openscad revision

2023-10-22 Thread Johannes Thyssen Tishman
Oct 15, 2023 00:10:08 Johannes Thyssen Tishman : > Hi Klemens. Thanks for the feedback. > >> The existing CMakeLists.txt no longer applies, but it looks like >> you no longer needed it, perhaps forgot to 'cvs rm -f' it? > > Yup, thanks. > >>> -MASTER_SITES = >>>

Re: [update] math/cgal + cad/openscad revision

2023-10-14 Thread Johannes Thyssen Tishman
Hi Klemens. Thanks for the feedback. > The existing CMakeLists.txt no longer applies, but it looks like > you no longer needed it, perhaps forgot to 'cvs rm -f' it? Yup, thanks. > > -MASTER_SITES = > > https://github.com/CGAL/cgal/releases/download/releases%2FCGAL-4.14.2/ > >

Re: [update] math/cgal + cad/openscad revision

2023-10-13 Thread Klemens Nanni
This does not apply, feedback inline, new diff with that at the end. I don't use cgal or openscad, though, and this needs another look. The existing CMakeLists.txt no longer applies, but it looks like you no longer needed it, perhaps forgot to 'cvs rm -f' it? Otherwise, looks like the first

Re: [update] math/cgal + cad/openscad revision

2023-10-11 Thread Johannes Thyssen Tishman
Oct 11, 2023 17:01:11 Ian Darwin : > Sorry I missed that - could you please re-send me the patch? Hi Ian. All good. Please find both diffs attached. Thanks Johannes > Thanks > Ian > > On Wed, Oct 11, 2023 at 04:27:04PM +0200, Johannes Thyssen Tishman wrote: >> *ping* >> >> Johannes Thyssen

Re: [update] math/cgal + cad/openscad revision

2023-10-11 Thread Johannes Thyssen Tishman
*ping* Johannes Thyssen Tishman wrote: > *ping* > > Sep 17, 2023 22:08:53 Johannes Thyssen Tishman : > > > Apologies for the poor formatting. I had 'textwidth' set to 80 > > characters. Fixed below. > > > > Johannes Thyssen Tishman wrote: > >> Hello everyone, > >> > >> attached is both an

Re: [update] math/cgal + cad/openscad revision

2023-09-25 Thread Johannes Thyssen Tishman
*ping* Sep 17, 2023 22:08:53 Johannes Thyssen Tishman : > Apologies for the poor formatting. I had 'textwidth' set to 80 > characters. Fixed below. > > Johannes Thyssen Tishman wrote: >> Hello everyone, >> >> attached is both an update for CGAL from version 4.14.2 to the latest >> 5.6 and a

Re: [update] math/cgal + cad/openscad revision

2023-09-17 Thread Johannes Thyssen Tishman
Apologies for the poor formatting. I had 'textwidth' set to 80 characters. Fixed below. Johannes Thyssen Tishman wrote: > Hello everyone, > > attached is both an update for CGAL from version 4.14.2 to the latest > 5.6 and a revision to OpenSCAD to work with the CGAL update. Note that > these