Re: rsync: update to 3.2.2

2020-08-18 Thread Stuart Henderson
On 2020/07/23 16:31, Klemens Nanni wrote: > Lots of fixes and enhancements: > https://download.samba.org/pub/rsync/NEWS#3.2.2 I use rsync flags including this: --rsh 'ssh -o ControlPersist=5m -o ControlMaster=auto -o VisualHostKey=no' My script is lazy and sets --rsh for everything including

Re: rsync: update to 3.2.2

2020-08-09 Thread Christian Weisgerber
On 2020-08-04, Klemens Nanni wrote: > I also looked at iconv but rsync configures and builds with it even when > --disable-iconv gets passed, this smells like some configure* bug. 3.2.2p0 now does not pick up iconv. I quickly looked over configure.ac, and as far as I can tell (1) detection

Re: rsync: update to 3.2.2

2020-08-04 Thread Stuart Henderson
On 2020/08/04 18:07, Christian Weisgerber wrote: > On 2020-07-30, Klemens Nanni wrote: > > > Any OKs for this diff which updates and brings in all the support? > > I haven't gotten around to really looking at this... but since it's > committed now: > > This changed rsync from a self-contained

Re: rsync: update to 3.2.2

2020-08-04 Thread Klemens Nanni
On Tue, Aug 04, 2020 at 06:07:35PM -, Christian Weisgerber wrote: > On 2020-07-30, Klemens Nanni wrote: > > > Any OKs for this diff which updates and brings in all the support? > > I haven't gotten around to really looking at this... but since it's > committed now: > > This changed rsync

Re: rsync: update to 3.2.2

2020-08-04 Thread Christian Weisgerber
Stuart Henderson: > > Wow, that's crazy. Can we have a "bloated" flavor instead so > > everyone is not subjected to this nonsense? > > Or a "weak_hash" flavour for MD5 fans. xxHash is explicitly a NON-cryptographic hash. It's selling point is that it is much faster than MD5. -- Christian

Re: rsync: update to 3.2.2

2020-08-04 Thread Theo de Raadt
Stuart Henderson wrote: > On 2020/08/04 12:30, Todd C. Miller wrote: > > On Tue, 04 Aug 2020 12:19:49 -0600, "Theo de Raadt" wrote: > > > > > This is totally ridiculous. > > > > > > Who is served by all these extra features? Didn't it work before? > > > Is it suddenly MANDATORY to have all

Re: rsync: update to 3.2.2

2020-08-04 Thread Stuart Henderson
On 2020/08/04 12:30, Todd C. Miller wrote: > On Tue, 04 Aug 2020 12:19:49 -0600, "Theo de Raadt" wrote: > > > This is totally ridiculous. > > > > Who is served by all these extra features? Didn't it work before? > > Is it suddenly MANDATORY to have all these features? > > Wow, that's crazy.

Re: rsync: update to 3.2.2

2020-08-04 Thread Theo de Raadt
Todd C. Miller wrote: > On Tue, 04 Aug 2020 12:19:49 -0600, "Theo de Raadt" wrote: > > > This is totally ridiculous. > > > > Who is served by all these extra features? Didn't it work before? > > Is it suddenly MANDATORY to have all these features? > > Wow, that's crazy. Can we have a

Re: rsync: update to 3.2.2

2020-08-04 Thread Todd C . Miller
On Tue, 04 Aug 2020 12:19:49 -0600, "Theo de Raadt" wrote: > This is totally ridiculous. > > Who is served by all these extra features? Didn't it work before? > Is it suddenly MANDATORY to have all these features? Wow, that's crazy. Can we have a "bloated" flavor instead so everyone is not

Re: rsync: update to 3.2.2

2020-08-04 Thread Theo de Raadt
This is totally ridiculous. Who is served by all these extra features? Didn't it work before? Is it suddenly MANDATORY to have all these features? Christian Weisgerber wrote: > On 2020-07-30, Klemens Nanni wrote: > > > Any OKs for this diff which updates and brings in all the support? > >

Re: rsync: update to 3.2.2

2020-08-04 Thread Christian Weisgerber
On 2020-07-30, Klemens Nanni wrote: > Any OKs for this diff which updates and brings in all the support? I haven't gotten around to really looking at this... but since it's committed now: This changed rsync from a self-contained port that you could quickly compile on a clean box to something

Re: rsync: update to 3.2.2

2020-07-31 Thread Kurt Mosiejczuk
On Thu, Jul 30, 2020 at 11:21:41PM +0200, Klemens Nanni wrote: > On Fri, Jul 24, 2020 at 02:55:50PM +0200, Klemens Nanni wrote: > > Tests on amd64 still pass: > > 31 passed > > 9 skipped > > Feedback? OK? > Any OKs for this diff which updates and brings in all the support? It

Re: rsync: update to 3.2.2

2020-07-30 Thread Klemens Nanni
On Fri, Jul 24, 2020 at 02:55:50PM +0200, Klemens Nanni wrote: > Tests on amd64 still pass: > > 31 passed > 9 skipped > > Feedback? OK? Any OKs for this diff which updates and brings in all the support? Index: Makefile

Re: rsync: update to 3.2.2

2020-07-24 Thread Klemens Nanni
On Fri, Jul 24, 2020 at 11:21:53AM +0100, Stuart Henderson wrote: > On 2020/07/24 00:04, Antoine Jacoutot wrote: > > IMHO these don’t warrant a FLAVOR and should be on by default. > > +1 Sure, the simpler the better. Tests on amd64 still pass: 31 passed 9 skipped Feedback? OK?

Re: rsync: update to 3.2.2

2020-07-24 Thread Stuart Henderson
On 2020/07/24 00:04, Antoine Jacoutot wrote: > IMHO these don’t warrant a FLAVOR and should be on by default. +1

Re: rsync: update to 3.2.2

2020-07-23 Thread Antoine Jacoutot
IMHO these don’t warrant a FLAVOR and should be on by default. Your best bet for minimum dependency is openrsync. — Antoine > On 23 Jul 2020, at 16:59, Marc Espie wrote: > > On Thu, Jul 23, 2020 at 04:31:00PM +0200, Klemens Nanni wrote: >> Lots of fixes and enhancements: >>

Re: rsync: update to 3.2.2

2020-07-23 Thread Klemens Nanni
On Thu, Jul 23, 2020 at 04:59:16PM +0200, Marc Espie wrote: > stuff like zstd or lz4 would probably want a flavor as well. Fine with me - we can sort this out later.

Re: rsync: update to 3.2.2

2020-07-23 Thread Marc Espie
On Thu, Jul 23, 2020 at 04:31:00PM +0200, Klemens Nanni wrote: > Lots of fixes and enhancements: > https://download.samba.org/pub/rsync/NEWS#3.2.2 > > zlib patches have been merged, rest of the patches/ diff is just churn. > > For now, I've conservatively disabled lz4, zstd and xxhash support to