On Tue, Mar 6, 2012 at 8:49 AM, David Coppa dco...@gmail.com wrote:
On Tue, Mar 6, 2012 at 3:38 AM, Piotr Sikora piotr.sik...@frickle.com wrote:
Attached patch fixes this, but to be honest I would consider completely
dropping our fix from the port .
me too would prefer the latter.
Can you
On 06/03/12 2:49 AM, David Coppa wrote:
On Tue, Mar 6, 2012 at 3:38 AM, Piotr Sikorapiotr.sik...@frickle.com wrote:
Attached patch fixes this, but to be honest I would consider completely
dropping our fix from the port .
me too would prefer the latter.
Other opinions?
Drop the patches.
On 2012/03/06 03:11, Brad Smith wrote:
On 06/03/12 2:49 AM, David Coppa wrote:
On Tue, Mar 6, 2012 at 3:38 AM, Piotr Sikorapiotr.sik...@frickle.com
wrote:
Attached patch fixes this, but to be honest I would consider completely
dropping our fix from the port .
me too would prefer the
On Tue, Mar 6, 2012 at 11:06 AM, Stuart Henderson s...@spacehopper.org wrote:
On 2012/03/06 03:11, Brad Smith wrote:
On 06/03/12 2:49 AM, David Coppa wrote:
On Tue, Mar 6, 2012 at 3:38 AM, Piotr Sikorapiotr.sik...@frickle.com
wrote:
Attached patch fixes this, but to be honest I would
Hi,
Drop the patches.
OKs?
I was thinking more about dropping only the smart patches (see: attached
patch), because changing sprintf() to snprintf() shouldn't hurt, but I'm OK
with both choices.
Best regards,
Piotr Sikora piotr.sik...@frickle.com
lua-5.1.4p4-cleanup.patch
On 06/03/12 9:14 AM, Piotr Sikora wrote:
Hi,
Drop the patches.
OKs?
I was thinking more about dropping only the smart patches (see:
attached patch), because changing sprintf() to snprintf() shouldn't
hurt, but I'm OK with both choices.
Local patches of these kind are frowned upon. Work
Hi,
I was thinking more about dropping only the smart patches (see:
attached patch), because changing sprintf() to snprintf() shouldn't
hurt, but I'm OK with both choices.
Local patches of these kind are frowned upon. Work with the upstream
community to get the patches integrated.
Then
Hey,
this bug was introduced 6 years ago when replacing unsafe strcpy(),
strcat() and sprintf() calls with their safe counterparts, the irony.
Original (a.k.a. unsafe) code:
size_t len = strcspn(source, \n\r);
bufflen -= sizeof( [string \...\] );
...
if (source[len] != '\0') {
Our
On Tue, Mar 6, 2012 at 3:38 AM, Piotr Sikora piotr.sik...@frickle.com wrote:
Attached patch fixes this, but to be honest I would consider completely
dropping our fix from the port .
me too would prefer the latter.
Other opinions?
Best regards,
Piotr Sikora piotr.sik...@frickle.com
ciao,