Re: enable -fstack-clash-protection in llvm ports

2023-09-15 Thread Landry Breuil
Le Thu, Sep 14, 2023 at 05:53:53PM +0200, Mark Kettenis a écrit : > > From: Theo de Raadt > > Date: Thu, 14 Sep 2023 01:02:14 -0600 (MDT) > > > > I do not think this should be enabled. > > Our stacks work differently. > > We don't put shit near the bottom of the main stack, because we > >

Re: enable -fstack-clash-protection in llvm ports

2023-09-14 Thread Theo de Raadt
Mark Kettenis wrote: > > From: Theo de Raadt > > Date: Thu, 14 Sep 2023 01:02:14 -0600 (MDT) > > > > I do not think this should be enabled. > > Our stacks work differently. > > We don't put shit near the bottom of the main stack, because we > > reserve the space. > > For pthread stacks, we

Re: enable -fstack-clash-protection in llvm ports

2023-09-14 Thread Mark Kettenis
> From: Theo de Raadt > Date: Thu, 14 Sep 2023 01:02:14 -0600 (MDT) > > I do not think this should be enabled. > Our stacks work differently. > We don't put shit near the bottom of the main stack, because we > reserve the space. > For pthread stacks, we allocate them randomly also so you cannot

Re: enable -fstack-clash-protection in llvm ports

2023-09-14 Thread Theo de Raadt
I do not think this should be enabled. Our stacks work differently. We don't put shit near the bottom of the main stack, because we reserve the space. For pthread stacks, we allocate them randomly also so you cannot determistically trash a specific object. This change also make very small stacks

enable -fstack-clash-protection in llvm ports

2023-09-11 Thread Landry Breuil
hi, currently building mozillas, i get tons of this on stderr: warning: clang-13: warning: argument unused during compilation: '-fstack-clash-protection' [-Wunused-command-line-argument] filed an upstream issue about it (https://bugzilla.mozilla.org/show_bug.cgi?id=1852202) to realize its an