Salut Renaud,
merci for volunteering to maintain exim.
Renaud Allard wrote on Tue, Apr 17, 2018 at 02:55:56PM +0200:
> On 04/17/2018 02:52 PM, Stuart Henderson wrote:
>> Honestly I would leave the srandom bits in. No major objection, but they
>> don't hurt and it will save you maintenance
On 2018/04/17 15:01, Renaud Allard wrote:
>
>
> On 04/17/2018 01:34 PM, Renaud Allard wrote:
>
>
> Sorry, I made a stupid mistake, forgetting the _uniform
> Here is a better one:
This would have been easier to spot from reading the diff if it didn't
have srandom parts ;-)
On 04/17/2018 01:34 PM, Renaud Allard wrote:
Sorry, I made a stupid mistake, forgetting the _uniform
Here is a better one:
Index: mail/exim//patches/patch-src_spam_c
===
RCS file: mail/exim//patches/patch-src_spam_c
diff -N
On 04/17/2018 02:52 PM, Stuart Henderson wrote:
+-static BOOL srandomed = FALSE;
+
+ /* speedup, if we have only 1 server */
+ if (num_servers == 1)
+ return (spamds[0]->is_failed ? -1 : 0);
+
+-/* init ranmod */
+-if (!srandomed)
Honestly I would leave the srandom bits in. No major
On 2018/04/17 13:34, Renaud Allard wrote:
>
>
> On 04/17/2018 01:26 PM, Stuart Henderson wrote:
>
> > > I'm not going to object strongly, but this occurs twice:
> > >
> > > for (rnd = arc4random() % weights, i = 0; i < num_servers; i++)
> > >
> > > The expression
> > >
On 04/17/2018 01:26 PM, Stuart Henderson wrote:
I'm not going to object strongly, but this occurs twice:
for (rnd = arc4random() % weights, i = 0; i < num_servers; i++)
The expression
arc4random() % weights;
is subject to modulus bias. Use
On 2018/04/17 13:10, Theo Buehler wrote:
> On Tue, Apr 17, 2018 at 12:58:09PM +0200, Renaud Allard wrote:
> >
> >
> > On 04/17/2018 11:34 AM, Theo Buehler wrote:
> > > On Tue, Apr 17, 2018 at 11:18:50AM +0200, Renaud Allard wrote:
> > > > Hello,
> > > >
> > > > This patch for exim replaces all
On Tue, Apr 17, 2018 at 12:58:09PM +0200, Renaud Allard wrote:
>
>
> On 04/17/2018 11:34 AM, Theo Buehler wrote:
> > On Tue, Apr 17, 2018 at 11:18:50AM +0200, Renaud Allard wrote:
> > > Hello,
> > >
> > > This patch for exim replaces all calls to rand() and random() to the
> > > secure
> > >
On 04/17/2018 11:34 AM, Theo Buehler wrote:
On Tue, Apr 17, 2018 at 11:18:50AM +0200, Renaud Allard wrote:
Hello,
This patch for exim replaces all calls to rand() and random() to the secure
OpenBSD version, making the compiler less unhappy.
After a discussion with one of the exim devs, this
On Tue, Apr 17, 2018 at 11:18:50AM +0200, Renaud Allard wrote:
> Hello,
>
> This patch for exim replaces all calls to rand() and random() to the secure
> OpenBSD version, making the compiler less unhappy.
> After a discussion with one of the exim devs, this change would not have
> been accepted
Hello,
This patch for exim replaces all calls to rand() and random() to the
secure OpenBSD version, making the compiler less unhappy.
After a discussion with one of the exim devs, this change would not have
been accepted in mainstream exim because there is no "need" to use a
crypto secure
11 matches
Mail list logo
