Re: net/btpd patch

2010-01-02 Thread Nicholas Marriott
This looks good and works for me, these are longstanding and annoying bugs, and upstream seems to be unresponsive at the moment, so I'd like to add this (although obviously the package would go to p1 now). ok anyone? On Wed, Dec 23, 2009 at 06:55:38PM -0800, Aaron Stellman wrote: > As discussed

Re: net/btpd patch

2009-12-23 Thread Aaron Stellman
As discussed with NicM, here are two fixes to btpd port: * make sure we don't pass NULL to freeaddrinfo() * calculate offset before req->rbuf.buf is potentially reallocated, and thus prevent from using a dangling pointer when making offset calculation the 2nd patch has been submitted to upstream m

Re: net/btpd patch

2009-11-19 Thread Nicholas Marriott
Hi A friend and I hit this a while ago but we got no useful response to a fix from upstream either, so fixing it is good with me. However, I don't think your fix is correct. We want to call freeaddrinfo only if the getaddrinfo call succeeds (returns 0). If it doesn't return 0 (error), res should

net/btpd patch

2009-11-18 Thread Aaron Stellman
Tried contacting upstream, but no response from there. This patch prevents NULL being passed to freeaddrinfo() Index: Makefile === RCS file: /cvs/ports/net/btpd/Makefile,v retrieving revision 1.6 diff -N -u -p Makefile --- Makefile