Rather than providing a run-time option, dino turns stuff like sound
notifications into a build-time option/loadable module.

In a simple cwm(1) setup without DE or so handling notifications in a
unified manner, I've sometimes missed a message.

Is sound (if you enable notifications inside dino) something other dino
users would want?

Anyone using dino under gnome, xfce or so?  Do notifications already
have a sound?  Would this play two (one from dino, one from DE) sounds
on new message?

PS: I see arch linux packaging such modules/features separately, but
going MULTI_PACKAGES here seems overkill here.


(Inside the WANTLIB churn, the only addition is 'canberra'.)

Index: Makefile
===================================================================
RCS file: /cvs/ports/net/dino/Makefile,v
retrieving revision 1.20
diff -u -p -r1.20 Makefile
--- Makefile    24 Apr 2023 11:41:23 -0000      1.20
+++ Makefile    10 Jun 2023 18:11:11 -0000
@@ -2,7 +2,7 @@ COMMENT=        XMPP desktop client
 VERSION=       0.4.2
 DISTNAME=      dino-${VERSION}
 CATEGORIES=    net x11
-REVISION=      0
+REVISION=      1
 
 SHARED_LIBS += crypto-vala               0.0 # 0.0
 SHARED_LIBS += dino                      2.0 # 0.0
@@ -24,7 +24,8 @@ BUILD_DEPENDS=        devel/gettext,-tools \
 RUN_DEPENDS=   devel/desktop-file-utils \
                multimedia/gstreamer1/plugins-good \
                x11/gtk+4,-guic
-LIB_DEPENDS=   devel/libgee \
+LIB_DEPENDS=   audio/libcanberra,-main \
+               devel/libgee \
                devel/libsoup3 \
                graphics/libqrencode \
                multimedia/gstreamer1/plugins-base \
@@ -38,14 +39,18 @@ LIB_DEPENDS=        devel/libgee \
                x11/gnome/libadwaita \
                x11/gtk+4
 
-WANTLIB += adwaita-1 c cairo cairo-gobject gcrypt gdk_pixbuf-2.0 gee-0.8
-WANTLIB += gio-2.0 glib-2.0 gmodule-2.0 gnutls gobject-2.0 gpgme
-WANTLIB += graphene-1.0 gstapp-1.0 gstaudio-1.0 gstbase-1.0 gstreamer-1.0
-WANTLIB += gstrtp-1.0 gstvideo-1.0 gtk-4 harfbuzz icudata icuuc
-WANTLIB += intl m nice pango-1.0 pangocairo-1.0 qrencode signal-protocol-c
-WANTLIB += soup-3.0 sqlite3 srtp2
+WANTLIB += adwaita-1 c cairo cairo-gobject canberra gcrypt gdk_pixbuf-2.0
+WANTLIB += gee-0.8 gio-2.0 glib-2.0 gmodule-2.0 gnutls gobject-2.0
+WANTLIB += gpgme graphene-1.0 gstapp-1.0 gstaudio-1.0 gstbase-1.0
+WANTLIB += gstreamer-1.0 gstrtp-1.0 gstvideo-1.0 gtk-4 harfbuzz
+WANTLIB += icudata icuuc intl m nice pango-1.0 pangocairo-1.0
+WANTLIB += qrencode signal-protocol-c soup-3.0 sqlite3 srtp2
+
+
+CONFIGURE_ARGS =       -DBUILD_TESTS=ON \
+                       -DUSE_SOUP3=yes \
+                       -DENABLED_PLUGINS=notification-sound
 
-CONFIGURE_ARGS =       -DBUILD_TESTS=ON -DUSE_SOUP3=yes
 
 MODCMAKE_LDFLAGS =             -L${LOCALBASE}/lib
 
Index: pkg/PLIST
===================================================================
RCS file: /cvs/ports/net/dino/pkg/PLIST,v
retrieving revision 1.6
diff -u -p -r1.6 PLIST
--- pkg/PLIST   2 Mar 2023 07:34:26 -0000       1.6
+++ pkg/PLIST   10 Jun 2023 18:05:15 -0000
@@ -8,6 +8,7 @@ lib/dino/
 lib/dino/plugins/
 @so lib/dino/plugins/http-files.so
 @so lib/dino/plugins/ice.so
+@so lib/dino/plugins/notification-sound.so
 @so lib/dino/plugins/omemo.so
 @so lib/dino/plugins/openpgp.so
 @so lib/dino/plugins/rtp.so

Reply via email to