Re: p7zip: add support for more archs

2015-11-13 Thread Jérémie Courrèges-Anglas
Christian Weisgerber writes: > On 2015-11-11, Jérémie Courrèges-Anglas wrote: > >> Right now p7zip fails to build on several archs, because of the rather >> lame approach to endianness taken by this port. This patch should allow >> to build p7zip on all

Re: p7zip: add support for more archs

2015-11-12 Thread Jérémie Courrèges-Anglas
Stuart Henderson writes: > On 2015/11/11 22:19, Josh Grosse wrote: >> On Wed, Nov 11, 2015 at 09:45:22PM -0500, Josh Grosse wrote: >> > Fixing the code may be the correct solution, but it is beyond me, as >> > I don't have the technical skills to deal with the portability

Re: p7zip: add support for more archs

2015-11-12 Thread Stuart Henderson
On 2015/11/11 22:19, Josh Grosse wrote: > On Wed, Nov 11, 2015 at 09:45:22PM -0500, Josh Grosse wrote: > > Fixing the code may be the correct solution, but it is beyond me, as > > I don't have the technical skills to deal with the portability issues > > that were raised and to my understanding

Re: p7zip: add support for more archs

2015-11-12 Thread Christian Weisgerber
On 2015-11-11, Jérémie Courrèges-Anglas wrote: > Right now p7zip fails to build on several archs, because of the rather > lame approach to endianness taken by this port. This patch should allow > to build p7zip on all archs supported by OpenBSD. Have you considered getting the

Re: p7zip: add support for more archs

2015-11-11 Thread Josh Grosse
On Thu, Nov 12, 2015 at 02:02:50AM +0100, J??r??mie Courr??ges-Anglas wrote: > Back to your concern: I don't think it's a reasonable approach to ask > for tests on all architectures before introducing a change in a port. > If we did that, the ports tree would be ridiculously small and lagging >

Re: p7zip: add support for more archs

2015-11-11 Thread Josh Grosse
On Thu, Nov 12, 2015 at 12:34:03AM +0100, J??r??mie Courr??ges-Anglas wrote: > > Right now p7zip fails to build on several archs, because of the rather > lame approach to endianness taken by this port. This patch should allow > to build p7zip on all archs supported by OpenBSD. > > ok? jca@,

Re: p7zip: add support for more archs

2015-11-11 Thread Theo de Raadt
> On Thu, Nov 12, 2015 at 02:02:50AM +0100, J??r??mie Courr??ges-Anglas wrote: > > > Back to your concern: I don't think it's a reasonable approach to ask > > for tests on all architectures before introducing a change in a port. > > If we did that, the ports tree would be ridiculously small and

Re: p7zip: add support for more archs

2015-11-11 Thread Jérémie Courrèges-Anglas
Josh Grosse writes: > On Thu, Nov 12, 2015 at 12:34:03AM +0100, J??r??mie Courr??ges-Anglas wrote: >> >> Right now p7zip fails to build on several archs, because of the rather >> lame approach to endianness taken by this port. This patch should allow >> to build p7zip

Re: p7zip: add support for more archs

2015-11-11 Thread Josh Grosse
On Wed, Nov 11, 2015 at 07:26:14PM -0700, Theo de Raadt wrote: > I really don't tell the ports people what to do. > > But... I also don't think they should be martyrs. Naddy said, after seeing an alignment error on Alpha: [1] "How about actually fixing the code rather than slapping on a list

Re: p7zip: add support for more archs

2015-11-11 Thread Josh Grosse
On Wed, Nov 11, 2015 at 09:45:22PM -0500, Josh Grosse wrote: > Fixing the code may be the correct solution, but it is beyond me, as > I don't have the technical skills to deal with the portability issues > that were raised and to my understanding still exist. I've had an out-of-band discussion

p7zip: add support for more archs

2015-11-11 Thread Jérémie Courrèges-Anglas
Right now p7zip fails to build on several archs, because of the rather lame approach to endianness taken by this port. This patch should allow to build p7zip on all archs supported by OpenBSD. ok? Index: Makefile === RCS file: