On Wed, Feb 03, 2016 at 05:30:39PM -0800, Doug Hogan wrote:
> Some feedback below.
>
> > diff --git a/src/main.c b/src/main.c
> > index 4d0e623..1551c0d 100644
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -35,6 +35,12 @@ int main(int argc, char **argv) {
> > int workers_len;
> > int
On Wed, Feb 03, 2016 at 06:02:55PM +0100, Florian Stinglmayr wrote:
> Michael's patch is very nice and should definitely make it in.
>
> Yet after speaking with upstream the other day it was made very clear to
> me that upstream wants the patch in their repository. Since my upstream
> patch
On Fri, Jan 29, 2016 at 04:13:20PM -0500, Michael McConville wrote:
> Sorry for disappearing.
>
> Thanks for pointing out the VCS popen. Below is a draft that
> incorporates your suggestions. Let me know if it's too fine-grained. My
> thought was that it's ideal to drop exec as early as possible.
On Fri, Jan 29, 2016 at 04:13:20PM -0500, Michael McConville wrote:
> Sorry for disappearing.
>
> Thanks for pointing out the VCS popen. Below is a draft that
> incorporates your suggestions. Let me know if it's too fine-grained. My
> thought was that it's ideal to drop exec as early as possible.
Sorry for disappearing.
Thanks for pointing out the VCS popen. Below is a draft that
incorporates your suggestions. Let me know if it's too fine-grained. My
thought was that it's ideal to drop exec as early as possible.
Index: Makefile
On Sat, Jan 16, 2016 at 08:37:16PM -0500, Michael McConville wrote:
> Also, yet another tweak. deraadt@ pointed out that I should use the
> local err clone (die()) rather than including err.h.
Comments inline.
> Index: Makefile
>
Michael McConville wrote:
> Florian Stinglmayr wrote:
> > On Sat, Jan 16, 2016 at 04:09:20PM -0500, Michael McConville wrote:
> > > This works for me. It unconditionally vforks at some point so, unlike
> > > grep, it needs proc. Also, the --pager flag lets the user specify a
> > > pager to display
Michael McConville wrote:
> Michael McConville wrote:
> > Florian Stinglmayr wrote:
> > > On Sat, Jan 16, 2016 at 04:09:20PM -0500, Michael McConville wrote:
> > > > This works for me. It unconditionally vforks at some point so, unlike
> > > > grep, it needs proc. Also, the --pager flag lets the
Florian Stinglmayr wrote:
> On Sat, Jan 16, 2016 at 04:09:20PM -0500, Michael McConville wrote:
> > This works for me. It unconditionally vforks at some point so, unlike
> > grep, it needs proc. Also, the --pager flag lets the user specify a
> > pager to display the output in, so it needs exec in
On Sat, Jan 16, 2016 at 04:09:20PM -0500, Michael McConville wrote:
> This works for me. It unconditionally vforks at some point so, unlike
> grep, it needs proc. Also, the --pager flag lets the user specify a
> pager to display the output in, so it needs exec in that case.
>
>
Thanks a lot. Here
Michael McConville wrote:
> This works for me. It unconditionally vforks at some point so, unlike
> grep, it needs proc. Also, the --pager flag lets the user specify a
> pager to display the output in, so it needs exec in that case.
And bump REVISION, of course. :-)
I'm going to look into
This works for me. It unconditionally vforks at some point so, unlike
grep, it needs proc. Also, the --pager flag lets the user specify a
pager to display the output in, so it needs exec in that case.
Index: patches/patch-src_options_c
12 matches
Mail list logo
