Re: NEW: x11/fff
On Wed Jul 15, 2020 at 10:40:41AM -, Dimitri Karamazov wrote:
> On Tue, July 14, 2020 07:46, Bjorn Ketelaars wrote:
> >
> > OK bket@ with the nit below.
> >
> >
> >
> > diff --git Makefile Makefile index 8d940f3aa63..68051a2c860 100644 ---
> > Makefile
> > +++ Makefile
> > @@ -18,9 +18,9 @@ RUN_DEPENDS = converters/libiconv \
> > devel/xdg-utils \ shells/bash
> >
> > +FAKE_FLAGS = DESTDIR= MANDIR="${DESTDIR}${PREFIX}/man"
> > +
> > NO_BUILD = Yes
> > NO_TEST = Yes
> >
> >
> > -FAKE_FLAGS = DESTDIR= MANDIR=${DESTDIR}${PREFIX}/man
> > -
> > .include
> >
> >
> Reattached with the changes from bket@
>
> Ok?
With s/#MIT/# MIT/ OK rsadowski@
Re: NEW: x11/fff
On Tue, July 14, 2020 07:46, Bjorn Ketelaars wrote:
>
> OK bket@ with the nit below.
>
>
>
> diff --git Makefile Makefile index 8d940f3aa63..68051a2c860 100644 ---
> Makefile
> +++ Makefile
> @@ -18,9 +18,9 @@ RUN_DEPENDS = converters/libiconv \
> devel/xdg-utils \ shells/bash
>
> +FAKE_FLAGS = DESTDIR= MANDIR="${DESTDIR}${PREFIX}/man"
> +
> NO_BUILD =Yes
> NO_TEST = Yes
>
>
> -FAKE_FLAGS = DESTDIR= MANDIR=${DESTDIR}${PREFIX}/man
> -
> .include
>
>
Reattached with the changes from bket@
Ok?
fff.tar.gz
Description: application/gzip
Re: NEW: x11/fff
On Mon 06/07/2020 07:53, deserter...@danwin1210.me wrote:
> On Mon, July 6, 2020 4:53 am, Bjorn Ketelaars wrote:
> >
> > Hi,
> >
> >
> > Couple of comments:
> > - I think CATEGORIES=sysutils is better. nnn and ranger are also there.
> > - No need to set HOMEPAGE as this is done by the GH_* magic. Have a look
> > at infrastructure/mk/bsd.port.mk. However, if fff has a homepage other than
> > the one on GitHUb than you could use HOMEPAGE - Please sort RUN_DEPENDS
> > - Instead of using do-install you could set FAKE_FLAGS and have Makefile
> > handle the rest. Something like the line below works FAKE_FLAGS=DESTDIR=
> > MANDIR="${DESTDIR}${PREFIX}/man
> > - No need to set CONFIGURE_STYLE as there is nothing to override
> >
> >
> Hey, Thanks for the feedback!
>
> I've have made the appropriate changes and reattached the tarball.
OK bket@ with the nit below.
diff --git Makefile Makefile
index 8d940f3aa63..68051a2c860 100644
--- Makefile
+++ Makefile
@@ -18,9 +18,9 @@ RUN_DEPENDS = converters/libiconv \
devel/xdg-utils \
shells/bash
+FAKE_FLAGS = DESTDIR= MANDIR="${DESTDIR}${PREFIX}/man"
+
NO_BUILD = Yes
NO_TEST = Yes
-FAKE_FLAGS = DESTDIR= MANDIR=${DESTDIR}${PREFIX}/man
-
.include
Re: NEW: x11/fff
On Mon, July 6, 2020 4:53 am, Bjorn Ketelaars wrote:
>
> Hi,
>
>
> Couple of comments:
> - I think CATEGORIES=sysutils is better. nnn and ranger are also there.
> - No need to set HOMEPAGE as this is done by the GH_* magic. Have a look
> at infrastructure/mk/bsd.port.mk. However, if fff has a homepage other than
> the one on GitHUb than you could use HOMEPAGE - Please sort RUN_DEPENDS
> - Instead of using do-install you could set FAKE_FLAGS and have Makefile
> handle the rest. Something like the line below works FAKE_FLAGS=DESTDIR=
> MANDIR="${DESTDIR}${PREFIX}/man
> - No need to set CONFIGURE_STYLE as there is nothing to override
>
>
Hey, Thanks for the feedback!
I've have made the appropriate changes and reattached the tarball.
fff.tar.gz
Description: application/gzip
Re: NEW: x11/fff
On Sun 05/07/2020 23:15, deserter...@danwin1210.me wrote:
> This is port consist of a fast fucking file manager, it is simply a
> bash script which does the job of copying, moving, deleting and
> navigating easier particularly for small task.
>
> Any comments?
Hi,
Couple of comments:
- I think CATEGORIES=sysutils is better. nnn and ranger are also there.
- No need to set HOMEPAGE as this is done by the GH_* magic. Have a look
at infrastructure/mk/bsd.port.mk. However, if fff has a homepage other
than the one on GitHUb than you could use HOMEPAGE
- Please sort RUN_DEPENDS
- Instead of using do-install you could set FAKE_FLAGS and have Makefile
handle the rest. Something like the line below works
FAKE_FLAGS=DESTDIR= MANDIR="${DESTDIR}${PREFIX}/man
- No need to set CONFIGURE_STYLE as there is nothing to override
NEW: x11/fff
This is port consist of a fast fucking file manager, it is simply a bash script which does the job of copying, moving, deleting and navigating easier particularly for small task. Any comments? fff.tar.gz Description: application/gzip
