Re: [update] databases/redis-5.0.7

2020-02-10 Thread Kurt Mosiejczuk
On Sun, Feb 09, 2020 at 09:31:51PM +, Stuart Henderson wrote: > On 2020/02/09 22:02, Theo Buehler wrote: > > On Sun, Feb 09, 2020 at 08:58:13PM +, Stuart Henderson wrote: > > > > I ran the tests a bunch of times last night. At first I was thinking it > > > > was only the first test run

Re: [update] databases/redis-5.0.7

2020-02-09 Thread Stuart Henderson
On 2020/02/09 22:02, Theo Buehler wrote: > On Sun, Feb 09, 2020 at 08:58:13PM +, Stuart Henderson wrote: > > > I ran the tests a bunch of times last night. At first I was thinking it > > > was only the first test run that would fail, but it seems to actually > > > be an intermittent failure. I

Re: [update] databases/redis-5.0.7

2020-02-09 Thread Theo Buehler
On Sun, Feb 09, 2020 at 08:58:13PM +, Stuart Henderson wrote: > > I ran the tests a bunch of times last night. At first I was thinking it > > was only the first test run that would fail, but it seems to actually > > be an intermittent failure. I got a failure and then 3 passes and then > > a

Re: [update] databases/redis-5.0.7

2020-02-09 Thread Stuart Henderson
> I ran the tests a bunch of times last night. At first I was thinking it > was only the first test run that would fail, but it seems to actually > be an intermittent failure. I got a failure and then 3 passes and then > a failure. I may try running the original tests multitple times to see > if

Re: [update] databases/redis-5.0.7

2020-02-09 Thread Kurt Mosiejczuk
On Sun, Feb 09, 2020 at 03:25:48PM +0100, Theo Buehler wrote: > On Sat, Feb 08, 2020 at 03:22:52PM -0500, Kurt Mosiejczuk wrote: > > On Sat, Feb 08, 2020 at 07:26:31PM +0100, Theo Buehler wrote: > > > I can add arm64 to sthen's table. Builds & works ok: > > > i386 builds OK

Re: [update] databases/redis-5.0.7

2020-02-09 Thread Theo Buehler
On Sat, Feb 08, 2020 at 03:22:52PM -0500, Kurt Mosiejczuk wrote: > On Sat, Feb 08, 2020 at 07:26:31PM +0100, Theo Buehler wrote: > > I can add arm64 to sthen's table. Builds & works ok: > > > i386builds OK tests OK > > macppc builds OK tests OK > > amd64

Re: [update] databases/redis-5.0.7

2020-02-08 Thread Theo Buehler
On Sat, Feb 08, 2020 at 03:22:52PM -0500, Kurt Mosiejczuk wrote: > On Sat, Feb 08, 2020 at 07:26:31PM +0100, Theo Buehler wrote: > > I can add arm64 to sthen's table. Builds & works ok: > > > i386builds OK tests OK > > macppc builds OK tests OK > > amd64

Re: [update] databases/redis-5.0.7

2020-02-08 Thread Kurt Mosiejczuk
On Sat, Feb 08, 2020 at 07:26:31PM +0100, Theo Buehler wrote: > I can add arm64 to sthen's table. Builds & works ok: > i386 builds OK tests OK > macppcbuilds OK tests OK > amd64 builds OK tests OK > arm64 builds OK tests OK > armv7

Re: [update] databases/redis-5.0.7

2020-02-08 Thread Theo Buehler
I can add arm64 to sthen's table. Builds & works ok: i386builds OK tests OK macppc builds OK tests OK amd64 builds OK tests OK arm64 builds OK tests OK armv7 runtime/tests fail (no regression, in-tree fail too)

Re: [update] databases/redis-5.0.7

2020-02-08 Thread Theo Buehler
On Fri, Feb 07, 2020 at 10:58:45PM +, Stuart Henderson wrote: > A sparc64 test would be good but I'm feeling positive about the update.. If anyone could test on sparc64 that would indeed be great. If tests should fail, please also run tests for the version in tree, so we know whether it

Re: [update] databases/redis-5.0.7

2020-02-07 Thread Stuart Henderson
On 2020/02/07 16:43, Daniel Jakots wrote: > On Fri, 7 Feb 2020 16:34:10 -0500, Daniel Jakots wrote: > > > On Thu, 6 Feb 2020 19:00:19 +0100, Charlene Wendling > > wrote: > > > > > Below is the original diff with an additional patch to fix that. I > > > did run the tests and it's still fine.

Re: [update] databases/redis-5.0.7

2020-02-07 Thread Daniel Jakots
On Fri, 7 Feb 2020 16:34:10 -0500, Daniel Jakots wrote: > On Thu, 6 Feb 2020 19:00:19 +0100, Charlene Wendling > wrote: > > > Below is the original diff with an additional patch to fix that. I > > did run the tests and it's still fine. > > Tested this diff as it seems to be the latest full

Re: [update] databases/redis-5.0.7

2020-02-07 Thread Daniel Jakots
On Thu, 6 Feb 2020 19:00:19 +0100, Charlene Wendling wrote: > Below is the original diff with an additional patch to fix that. I did > run the tests and it's still fine. Tested this diff as it seems to be the latest full diff. It works fine for me. ok danj@ Cheers, Daniel

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Theo Buehler
On Thu, Feb 06, 2020 at 03:21:23PM +0100, Theo Buehler wrote: [...] > I have successfully built this version on amd64, i386 and macppc and ran > the test suite successfully multiple times on each of these platforms. My BeagleBoneBlack finally managed to update the ports tree and build Redis. It

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Theo Buehler
On Thu, Feb 06, 2020 at 07:44:28PM +0100, Klemens Nanni wrote: > On Thu, Feb 06, 2020 at 07:36:42PM +0100, Theo Buehler wrote: > > I don't understand. How does this work with the 4.0.14 port? The things > > you ifdef out are already there. > Sorry, that was a patch against 5.0.3, not 4.0.14

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Klemens Nanni
On Thu, Feb 06, 2020 at 07:36:42PM +0100, Theo Buehler wrote: > I don't understand. How does this work with the 4.0.14 port? The things > you ifdef out are already there. Sorry, that was a patch against 5.0.3, not 4.0.14 in-tree.

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Theo Buehler
On Thu, Feb 06, 2020 at 07:24:18PM +0100, Klemens Nanni wrote: > On Thu, Feb 06, 2020 at 07:18:48PM +0100, Klemens Nanni wrote: > > sparc64 does not have luajit suppport which blocked my update to 5.0.3; > > I #ifdef'd the bits in src/scripting.c but afaik there were issues with > > dependent

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Klemens Nanni
On Thu, Feb 06, 2020 at 07:18:48PM +0100, Klemens Nanni wrote: > sparc64 does not have luajit suppport which blocked my update to 5.0.3; > I #ifdef'd the bits in src/scripting.c but afaik there were issues with > dependent ports on such recent redis versions -- rspamd was probably one > of them.

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Klemens Nanni
On Thu, Feb 06, 2020 at 04:12:29PM +, Stuart Henderson wrote: > When the topic came up before, there was some mention of 5.x not working > on some arches, I would like to see this tested on at least i386, sparc64, > aarch64 before it goes in. I can do some tests on i386 and probably > also

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Charlene Wendling
On Thu, 6 Feb 2020 16:12:29 + Stuart Henderson wrote: > On 2020/02/06 10:15, Daniel Jakots wrote: > > Hi Theo, > > > > Thanks for working on that! > > > > On Thu, 6 Feb 2020 15:21:23 +0100, Theo Buehler > > wrote: > > > > > First of all, despite the length of this mail, most of the update

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Charlene Wendling
On Thu, 6 Feb 2020 16:12:29 + Stuart Henderson wrote: > On 2020/02/06 10:15, Daniel Jakots wrote: > > Hi Theo, > > > > Thanks for working on that! > > > > On Thu, 6 Feb 2020 15:21:23 +0100, Theo Buehler > > wrote: > > > > > First of all, despite the length of this mail, most of the update

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Giovanni Bechis
On 2/6/20 4:15 PM, Daniel Jakots wrote: > Hi Theo, > > Thanks for working on that! > > On Thu, 6 Feb 2020 15:21:23 +0100, Theo Buehler > wrote: > >> First of all, despite the length of this mail, most of the update is >> straightforward. The diff is an in-place upgrade from 4.0.14 to 5.0.7. >>

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Theo Buehler
On Thu, Feb 06, 2020 at 10:15:20AM -0500, Daniel Jakots wrote: > > https://raw.githubusercontent.com/antirez/redis/5.0/00-RELEASENOTES > > Since Redis 5.0 is still able to read 4.0 mdb format, I assume for a > user there is nothing to do. I guess you don't plan to add anything to > current.html

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Stuart Henderson
On 2020/02/06 10:15, Daniel Jakots wrote: > Hi Theo, > > Thanks for working on that! > > On Thu, 6 Feb 2020 15:21:23 +0100, Theo Buehler > wrote: > > > First of all, despite the length of this mail, most of the update is > > straightforward. The diff is an in-place upgrade from 4.0.14 to

Re: [update] databases/redis-5.0.7

2020-02-06 Thread Daniel Jakots
Hi Theo, Thanks for working on that! On Thu, 6 Feb 2020 15:21:23 +0100, Theo Buehler wrote: > First of all, despite the length of this mail, most of the update is > straightforward. The diff is an in-place upgrade from 4.0.14 to 5.0.7. > > The release notes (which contain migration

[update] databases/redis-5.0.7

2020-02-06 Thread Theo Buehler
Here is an update for Redis to the latest stable version 5.0.7. I'd like to ask for tests, feedback and some advice. First of all, despite the length of this mail, most of the update is straightforward. The diff is an in-place upgrade from 4.0.14 to 5.0.7. The release notes (which contain