On Thu, Nov 24, 2005 at 11:33:39AM +0100, M. Schatzl wrote:
> Hi,
>
> this is a little gravity shooter game with cool graphics:
> http://highmoon.gerdsmeier.net/
>
> Since it is the first port I prepared, I'd be grateful for any feedback
> concerning the Makefile and patches. As far as I can say, it runs fine.
> Please test it nevertheless, for the above reason.
some quick feedback:
- you need a # in 1st line of makefile
- instead of patching the bundled makefile, try using ${INSTALL_DATA} and
friends in do-install in the port's makefile.
- you need to honor CXX, CXXFLAGS etc. which are passed by make
e.g. we do not use -O3 and there's no need for -g
- no need for your header locations patches, just make sure you get
"-I${LOCALBASE}/include" in CXXFLAGS
Disclaimer: http://www.kuleuven.be/cwis/email_disclaimer.htm
