Re: Remove textproc/glimpse?
On Sat, Sep 19, 2020 at 08:04:28PM +0200, Stefan Hagen wrote: > Hello, > > I noticed, that there is textproc/glimpse. Glimpse is functional, but > upstream is dead for years. Glimpse (the indexer) is completely gone > and can only be found on mirrors and archive.org. Webglimpse originally > was the webfrontend for glimpse, but is mentioned as homepage in the > port (which is not correct, the port does not contain the web part). > > Anyway, webglimpse.net is also gone. There is a backup version on > github (last commit 2014). https://github.com/gvelez17/webglimpse > > The gimpse version we're installing is from 1998. There is no more > recent one. > > Good source code indexers are rare, but this one might just be > too old by now. > > Also: > $ make 2>&1 | grep -i warning | wc -l > 970 misc/tkman no longer depends on glimpse, thus making it unused and ready for removal. Feedback? Objections? OK?
Re: Remove textproc/glimpse?
Hi Klemens,
Klemens Nanni wrote on Sat, Oct 03, 2020 at 02:21:42AM +0200:
> On Sun, Sep 20, 2020 at 02:48:26PM +0200, Ingo Schwarze wrote:
>> Judging from patch-Makefile, it ought to be trivial to remove the
>> dependency on glimpse.
> True, so let's do that and keep the port as you outlined potential use
> for it.
> Feedback? OK?
OK schwarze@, this is already a clear improvement.
After this, more work should be done:
* Remove the hidden dependency on textproc/groff and use mandoc(1)
instead. Fixing patch-Makefile is probably sufficient to achieve
that.
So far, i did not investigate how the following can be achieved,
but they are clearly needed and i'd be surprised if they were hard:
* Remove the requirement to set MANPATH.
Use the default instead.
Or even better, use /etc/man.conf if feasible.
* Remove the warning that the "whatis" file is missing
* Remove warning about stray cats
* And probably more.
Also, there *are* formatting problem with the output the program
produces, for example with respect to line breaks.
So there is still a lot of work to do, but even without all that,
the port is already partially useable.
Yours,
Ingo
> Index: Makefile
> ===
> RCS file: /cvs/ports/misc/tkman/Makefile,v
> retrieving revision 1.26
> diff -u -p -r1.26 Makefile
> --- Makefile 12 Jul 2019 20:47:54 - 1.26
> +++ Makefile 3 Oct 2020 00:14:57 -
> @@ -3,7 +3,7 @@
> COMMENT =Tcl/Tk-based manual browser
>
> DISTNAME = tkman-2.2
> -REVISION = 0
> +REVISION = 1
> CATEGORIES = misc
> HOMEPAGE = http://www.sourceforge.net/projects/tkman
> MAINTAINER = Stuart Cassoff
> @@ -15,8 +15,7 @@ MASTER_SITES = ${MASTER_SITE_SOURCEFORGE
> MODULES =x11/tk
>
> RUN_DEPENDS =${MODTK_RUN_DEPENDS} \
> - textproc/rman \
> - textproc/glimpse
> + textproc/rman
>
> NO_TEST =Yes
>
> Index: patches/patch-Makefile
> ===
> RCS file: /cvs/ports/misc/tkman/patches/patch-Makefile,v
> retrieving revision 1.4
> diff -u -p -r1.4 patch-Makefile
> --- patches/patch-Makefile5 Jan 2011 17:34:17 - 1.4
> +++ patches/patch-Makefile3 Oct 2020 00:19:14 -
> @@ -1,6 +1,7 @@
> $OpenBSD: patch-Makefile,v 1.4 2011/01/05 17:34:17 stu Exp $
> Makefile.origFri Dec 10 19:26:34 2010
> -+++ Makefile Fri Dec 10 19:35:54 2010
> +Index: Makefile
> +--- Makefile.orig
> Makefile
> @@ -25,7 +25,7 @@ mintk = 8.4
>
> ### you need to localize the paths on these lines
> @@ -57,25 +58,16 @@ $OpenBSD: patch-Makefile,v 1.4 2011/01/0
> # printing string for preformatted pages without [tn]roff source
> #catprint = lpr
> #catprint = "lpr -h"
> -@@ -201,14 +201,15 @@ shortnames = 0
> - # the right-topmost menu's Rebuild Database/Glimpse Index menu choice.
> -
> +@@ -203,7 +203,7 @@ shortnames = 0
> # BY DEFAULT OFF
> --glimpse = ""
> -+#glimpse = ""
> + glimpse = ""
> # Glimpse on, with Boolean scope set to entire file
> -glimpse = "glimpse -W"
> +#glimpse = "glimpse -W"
> # give the full path, if you'd like
> #glimpse = /usr/sww/bin/glimpse
> # variations (refer to the Glimpse manual page)
> - # no characters treated as meta characters:
> - #glimpse = "glimpse -Wk"
> -+glimpse = "glimpse -z"
> - # compressed manual pages are handled automatically; don't add -z to above
> -
> - # glimpseindex indexes the manual pages, for each component of one's
> MANPATH,
> -@@ -460,7 +461,7 @@ install: tkman retkman
> +@@ -460,7 +460,7 @@ install: tkman retkman
> chmod +rx $(BINDIR)/tkman
> $(CP) retkman $(BINDIR)
> chmod +rx $(BINDIR)/retkman
Re: Remove textproc/glimpse?
On Sun, Sep 20, 2020 at 02:48:26PM +0200, Ingo Schwarze wrote:
> Judging from patch-Makefile, it ought to be trivial to remove the
> dependency on glimpse.
True, so let's do that and keep the port as you outlined potential use
for it.
Feedback? OK?
Index: Makefile
===
RCS file: /cvs/ports/misc/tkman/Makefile,v
retrieving revision 1.26
diff -u -p -r1.26 Makefile
--- Makefile12 Jul 2019 20:47:54 - 1.26
+++ Makefile3 Oct 2020 00:14:57 -
@@ -3,7 +3,7 @@
COMMENT = Tcl/Tk-based manual browser
DISTNAME = tkman-2.2
-REVISION = 0
+REVISION = 1
CATEGORIES = misc
HOMEPAGE = http://www.sourceforge.net/projects/tkman
MAINTAINER = Stuart Cassoff
@@ -15,8 +15,7 @@ MASTER_SITES =${MASTER_SITE_SOURCEFORGE
MODULES = x11/tk
RUN_DEPENDS = ${MODTK_RUN_DEPENDS} \
- textproc/rman \
- textproc/glimpse
+ textproc/rman
NO_TEST = Yes
Index: patches/patch-Makefile
===
RCS file: /cvs/ports/misc/tkman/patches/patch-Makefile,v
retrieving revision 1.4
diff -u -p -r1.4 patch-Makefile
--- patches/patch-Makefile 5 Jan 2011 17:34:17 - 1.4
+++ patches/patch-Makefile 3 Oct 2020 00:19:14 -
@@ -1,6 +1,7 @@
$OpenBSD: patch-Makefile,v 1.4 2011/01/05 17:34:17 stu Exp $
Makefile.orig Fri Dec 10 19:26:34 2010
-+++ Makefile Fri Dec 10 19:35:54 2010
+Index: Makefile
+--- Makefile.orig
Makefile
@@ -25,7 +25,7 @@ mintk = 8.4
### you need to localize the paths on these lines
@@ -57,25 +58,16 @@ $OpenBSD: patch-Makefile,v 1.4 2011/01/0
# printing string for preformatted pages without [tn]roff source
#catprint = lpr
#catprint = "lpr -h"
-@@ -201,14 +201,15 @@ shortnames = 0
- # the right-topmost menu's Rebuild Database/Glimpse Index menu choice.
-
+@@ -203,7 +203,7 @@ shortnames = 0
# BY DEFAULT OFF
--glimpse = ""
-+#glimpse = ""
+ glimpse = ""
# Glimpse on, with Boolean scope set to entire file
-glimpse = "glimpse -W"
+#glimpse = "glimpse -W"
# give the full path, if you'd like
#glimpse = /usr/sww/bin/glimpse
# variations (refer to the Glimpse manual page)
- # no characters treated as meta characters:
- #glimpse = "glimpse -Wk"
-+glimpse = "glimpse -z"
- # compressed manual pages are handled automatically; don't add -z to above
-
- # glimpseindex indexes the manual pages, for each component of one's MANPATH,
-@@ -460,7 +461,7 @@ install: tkman retkman
+@@ -460,7 +460,7 @@ install: tkman retkman
chmod +rx $(BINDIR)/tkman
$(CP) retkman $(BINDIR)
chmod +rx $(BINDIR)/retkman
Re: Remove textproc/glimpse?
Hi Klemens, Klemens Nanni wrote on Sat, Sep 19, 2020 at 10:45:19PM +0200: > On Sat, Sep 19, 2020 at 08:08:43PM +0200, Stefan Hagen wrote: >> misc/tkman depends on textproc/glimpse. Judging from patch-Makefile, it ought to be trivial to remove the dependency on glimpse. >> This one would have to go too. >> I haven't found any other dependency. > Thanks for digging, tkman looks like a port we could zap: I can start > it with `MANPATH=/usr/share/man tkman' and the window appears for a few > seconds but then closes again without any error message or non-zero exit > code. I fail to reproduce the crash you report, but the window does contain lots of error messages when i start tkman(1): || Problems in component paths of MANPATH environment variable... || /usr/share/man -- no `whatis' file for apropos ||=> generate `whatis' with mkwhatis/makewhatis/catman The above basically means tkman is incompatible with OpenBSD at least in some respects, though patching that might be possible and perhaps even easy. It obviously requires an old-style "whatis" database which we deleted years ago. It doesn't respect our man.conf(5) either, instead hardcoding the manpath in patch-Makefile. Requiring MANPATH to be set is quite bad. People should *not* set MANPATH because that will sooner or later cause some manual pages to not be found. The MANPATH feature is only intended for rare and exotic tasks like reading non-English manual pages, like temporarily using non-standard trees (e.g. from the man-pages-posix port), or for debugging individual trees. || Stray cats (formatted pages in .../man/catN without corresponding || source in .../man/manN) || /usr/local/man/cat1 || mwm uil xmbind xwit That means it doesn't understand the concept of preformatted-only pages either (which is used for pages where the source code is of insufficient quality for installation, or unavailable in the first place). All that said, significant numbers of features (of which there are really many) work as advertised at least part-way, even some that i would have thought likely to fail outright. So even though i don't know how good the overall code quality really is, it does seem to be surprisingly robust. > Does anyone have a use for such an outdated manual browser/reader GUI > which does not work by default and requires another ancient port? There are some feature that may be interesting to some users, like * hypertext links * texinfo support * expandable/collapsable sections in manual pages * some fancy syntax highlighting (personally, i hate syntax highlighting, but i know many like it) * and several others At the very least, the port implements several interesting ideas that could inspire future development of manual page browsing tools, so it would seem a bit sad from where i stand to kill it. > OK to remove misc/tkman? I wouldn't very strongly object to deletion if porters think that the port makes their life harder or impedes progress, but given that it looks like the dependency on glimpse can easily be removed, i don't see which kind of trouble the port could cause. It could certainly benefit from an active maintainer who investigated and fixed issues. My impression is significant numbers of minor issues exist, but nothing that strikes me as making the port completely useless. Also, the patch-Makefile contains some very outdated decisions. For example, it explicitly uses groff for formatting rather than mandoc. Some work should be done on this one. I have to admit that personally, i care more about console support than about GUIs, but if somebody wants to improve GUI support for manual page display on OpenBSD, this port seems like child likely to reward some love shown to it. Also, i'm not aware of a better GUI to display manual pages. Yours, Ingo
Re: Remove textproc/glimpse?
On Sat, Sep 19, 2020 at 10:45:19PM +0200, Klemens Nanni wrote: > On Sat, Sep 19, 2020 at 08:08:43PM +0200, Stefan Hagen wrote: > > Stefan Hagen wrote: > > > Good source code indexers are rare, but this one might just be > > > too old by now. > > misc/tkman depends on textproc/glimpse. This one would have to go too. > > I haven't found any other dependency. > Thanks for digging, tkman looks like a port we could zap: I can start > it with `MANPATH=/usr/share/man tkman' and the window appears for a few > seconds but then closes again without any error message or non-zero exit > code. > Does anyone have a use for such an outdated manual browser/reader GUI > which does not work by default and requires another ancient port? > OK to remove misc/tkman? ok kmos --Kurt
Re: Remove textproc/glimpse?
On Sat, Sep 19, 2020 at 08:08:43PM +0200, Stefan Hagen wrote: > Stefan Hagen wrote: > > Good source code indexers are rare, but this one might just be > > too old by now. > > misc/tkman depends on textproc/glimpse. This one would have to go too. > I haven't found any other dependency. Thanks for digging, tkman looks like a port we could zap: I can start it with `MANPATH=/usr/share/man tkman' and the window appears for a few seconds but then closes again without any error message or non-zero exit code. Does anyone have a use for such an outdated manual browser/reader GUI which does not work by default and requires another ancient port? OK to remove misc/tkman?
Re: Remove textproc/glimpse?
Stefan Hagen wrote: > Good source code indexers are rare, but this one might just be > too old by now. misc/tkman depends on textproc/glimpse. This one would have to go too. I haven't found any other dependency. Best Regards, Stefan
Remove textproc/glimpse?
Hello, I noticed, that there is textproc/glimpse. Glimpse is functional, but upstream is dead for years. Glimpse (the indexer) is completely gone and can only be found on mirrors and archive.org. Webglimpse originally was the webfrontend for glimpse, but is mentioned as homepage in the port (which is not correct, the port does not contain the web part). Anyway, webglimpse.net is also gone. There is a backup version on github (last commit 2014). https://github.com/gvelez17/webglimpse The gimpse version we're installing is from 1998. There is no more recent one. Good source code indexers are rare, but this one might just be too old by now. Also: $ make 2>&1 | grep -i warning | wc -l 970 Best Regards, Stefan
