Re: bsd.port.mk: Add EXTRACT_FILES

2020-05-18 Thread Christian Weisgerber
On 2020-05-18, Klemens Nanni wrote: > Passing EXTRACT_FILES as is has the advantage of using sh(1)'s brace > expansion as shown in the diff, using make's :QL would have the > advantage of not preventing porters from passing bogus values, I'm undecided, but I will mention that brace expansion is

Re: bsd.port.mk: Add EXTRACT_FILES

2020-05-18 Thread Klemens Nanni
On Mon, May 18, 2020 at 03:13:07PM +0200, Marc Espie wrote: > > @@ -1726,6 +1726,18 @@ Used to set DISTFILES default value to $ > > The decompression tool needed will be automatically added as > > .Ev BUILD_DEPENDS . > > Default value is .tar.gz. > > +.It Ev EXTRACT_FILES > > +Set to the list

Re: bsd.port.mk: Add EXTRACT_FILES

2020-05-18 Thread Marc Espie
On Mon, May 18, 2020 at 01:46:38PM +0200, Klemens Nanni wrote: > On Mon, May 18, 2020 at 12:17:01PM +0100, Stuart Henderson wrote: > > I like it, can you work up something for the bsd.port.mk(5) manual please? > Diff below tries to lay out the inner workings without being too > specific; a bit

Re: bsd.port.mk: Add EXTRACT_FILES

2020-05-18 Thread Klemens Nanni
On Mon, May 18, 2020 at 12:17:01PM +0100, Stuart Henderson wrote: > I like it, can you work up something for the bsd.port.mk(5) manual please? Diff below tries to lay out the inner workings without being too specific; a bit tricky to prevent common pitfalls without explaining basic shell

Re: bsd.port.mk: Add EXTRACT_FILES

2020-05-18 Thread Stuart Henderson
On 2020/05/18 12:51, Klemens Nanni wrote: > Some ports have huge distfiles of which we only need a tiny fraction, > see the coreboot-utils thread. > > My idea was to pass a list of files to the extract phase and it works > just fine as seen in the diff below, based on this EXTRACT_FILES has no >

bsd.port.mk: Add EXTRACT_FILES

2020-05-18 Thread Klemens Nanni
Some ports have huge distfiles of which we only need a tiny fraction, see the coreboot-utils thread. My idea was to pass a list of files to the extract phase and it works just fine as seen in the diff below, based on this EXTRACT_FILES has no effect for .shar or .gz distfiles, but I don't see