Configure > Settings > Network has two confusing settings.

1. Privacy: Do not send OS information to Mumble servers and web servers
2. Mumble services: Submit anonymous statistics

This patch ensures that #1 is now checked and #2 still remains
unchecked. #1 is opt-out and #2 is opt-in. I am proposing this because
it seems similar to the patch's purpose of disabling submitting
anonymous statistics.

Source: https://github.com/mumble-voip/mumble/pull/3015

Feedback and tests are welcome.

Index: Makefile
===================================================================
RCS file: /cvs/ports/audio/mumble/Makefile,v
retrieving revision 1.41
diff -u -p -r1.41 Makefile
--- Makefile    21 Mar 2020 16:19:27 -0000      1.41
+++ Makefile    27 Mar 2020 07:25:30 -0000
@@ -3,7 +3,7 @@
 COMMENT =              low-latency voice chat client
 
 DISTNAME =             mumble-1.3.0
-REVISION =             1
+REVISION =             2
 
 CATEGORIES =           audio
 
Index: patches/patch-src_mumble_Settings_cpp
===================================================================
RCS file: /cvs/ports/audio/mumble/patches/patch-src_mumble_Settings_cpp,v
retrieving revision 1.3
diff -u -p -r1.3 patch-src_mumble_Settings_cpp
--- patches/patch-src_mumble_Settings_cpp       25 Feb 2020 05:14:52 -0000      
1.3
+++ patches/patch-src_mumble_Settings_cpp       27 Mar 2020 07:25:30 -0000
@@ -4,6 +4,8 @@ Disable Text-To-Speech
 
 Disable submitting anonymous statistics
 
+Do not send OS information to Mumble servers and web servers
+
 Index: src/mumble/Settings.cpp
 --- src/mumble/Settings.cpp.orig
 +++ src/mumble/Settings.cpp
@@ -25,3 +27,12 @@ Index: src/mumble/Settings.cpp
        bShowUserCount = false;
        bChatBarUseSelection = false;
        bFilterHidesEmptyChannels = true;
+@@ -363,7 +363,7 @@ Settings::Settings() {
+       iMaxImageHeight = 1024;
+       bSuppressIdentity = false;
+       qsSslCiphers = MumbleSSL::defaultOpenSSLCipherString();
+-      bHideOS = false;
++      bHideOS = true;
+ 
+       bShowTransmitModeComboBox = false;
+ 

Reply via email to