Re: clang6: x11/kde4/libs: some tentative fixes

Ingo Schwarze: > > > However, the dnssd/servicemodel.h patch changes an ABI. > > Indeed, you are right. That definitely requires a major bump, > which wasn't done earlier because it did not build yet. > > So, here is the hopefully final patch. I tested the full > build again, and it

Re: clang6: x11/kde4/libs: some tentative fixes

Hi Christian, Christian Weisgerber wrote on Thu, Apr 19, 2018 at 06:20:27AM +0200: > However, the dnssd/servicemodel.h patch changes an ABI. Indeed, you are right. That definitely requires a major bump, which wasn't done earlier because it did not build yet. So, here is the hopefully final

Re: clang6: x11/kde4/libs: some tentative fixes

Ingo Schwarze: > I don't think bumping the shared object major is required. The > patch only changes *unused* bits in a constant that confused the > type checking of the compiler. Even if a program passes the other > value to a library or vice versa, everything should still work as > expected.

Re: clang6: x11/kde4/libs: some tentative fixes

Hi, Theo de Raadt wrote on Wed, Apr 18, 2018 at 07:03:55PM -0600: > Ingo Schwarze wrote: >> I don't think bumping the shared object major is required. The >> patch only changes *unused* bits in a constant that confused the >> type checking of the compiler. Even if a program

Re: clang6: x11/kde4/libs: some tentative fixes

Ingo Schwarze wrote: > I don't think bumping the shared object major is required. The > patch only changes *unused* bits in a constant that confused the > type checking of the compiler. Even if a program passes the other > value to a library or vice versa, everything should

Re: clang6: x11/kde4/libs: some tentative fixes

Hi Christian, Christian Weisgerber wrote on Tue, Apr 17, 2018 at 06:52:14PM +0200: > Here are three further tentative fixes for x11/kde4/libs. There > are additional problems still, but I'm going to take a break now. Actually, you did *all* the work required and merely missed the fact that you

Re: clang6: x11/kde4/libs: some tentative fixes

Hi Christian, Christian Weisgerber wrote on Tue, Apr 17, 2018 at 06:52:14PM +0200: > Here are three further tentative fixes for x11/kde4/libs. > There are additional problems still, but I'm going to take > a break now. I checked that your patches are indeed needed, that they indeed solve the

clang6: x11/kde4/libs: some tentative fixes

Here are three further tentative fixes for x11/kde4/libs. There are additional problems still, but I'm going to take a break now. Some comments: * dnssd/servicemodel.h: The value of ServicePtrRole appears to be random number that would be unlikely to collide with the values already used in