[naddy: Re: shorten: chars not longs for ulaw]

2023-02-21 Thread Christian Weisgerber
[Oops, resending this to the list.] Jan Stary: > $ shorten -i file.shn > File 'file.shn' contains appended seek tables (revision 4294967295). > > That's 2^32 - 1 and I suspect that's not how they number revisions. Yeah, that's the -1 from when it can't find the seek table revision. This one is

Re: shorten: chars not longs for ulaw

2023-02-21 Thread Jan Stary
Aaargh, sorry, %ld vs %d, not %lu vs %u. While here: fuckery also appears to be afoot in $ sox -b 16 -n file.wav synth 10 gain -3 $ shorten file.wav $ shorten -i file.shn File 'file.shn' contains appended seek tables (revision 4294967295). That's 2^32 - 1 and I suspect that's not how they

shorten: chars not longs for ulaw

2023-02-21 Thread Jan Stary
This is a patch for audio/shorten. The utils/mkbshift.c emits bitshift.c which is later used in ulaw ancoding/decoding - it contains the arrays of ulaw constants. However, mkbshift.c prints them as %lu, resulting in e.g. schar ulaw_inward[13][256] = { {4294967169,4294967170,4294967171,... and