Hi Klemens,
since you Cc:ed me on this one, here is some quick feedback, even
though this feels so technical in both the compiler sense and the
ports sense that i'm hardly the right person to provide an OK.
Since you seem to care about technical details of the port quite
a bit, i wonder whether maybe you want to take MAINTAINER?
Klemens Nanni wrote on Sun, Oct 22, 2023 at 03:22:19PM +:
> Silence the wall of warnings on amd64 and other clang architectures.
> sparc64/ports-gcc doesn't print them, so don't suppress them there.
>
> Feedback? OK?
In general, i'm not convinced tweaking warning settings for individual
ports always makes maintenance easier, unless there are specific
reasons. Then again, this really reduces noise a lot, making
some potentially more relevant warnings stand out more, so if people
think it's worth the additional lines in the Makefile, i'm not opposed.
> Index: Makefile
> ===
> RCS file: /cvs/ports/textproc/xpdf/Makefile,v
> retrieving revision 1.98
> diff -u -p -r1.98 Makefile
> --- Makefile 22 Oct 2023 15:16:54 - 1.98
> +++ Makefile 22 Oct 2023 15:20:38 -
> @@ -47,3 +47,8 @@ do-install:
> ${PREFIX}/share/examples/xpdf/xpdfrc
>
> .include
> +
> +.if ${CHOSEN_COMPILER} == "base-clang"
> +# reduce warning spam, 86% less build log (1262 -> 179 lines)
For the full build log (make package 2>&1) i get 1530 -> 644 on amd64,
but i doubt this discrepancy matters.
Yours,
Ingo
> +CXXFLAGS+= -Wno-writable-strings
> +.endif
