Re: NEW: sysutils/vifm

2016-06-24 Thread Stuart Henderson
BTW, if anyone plans on committing vifm, be aware that there's a quirks entry from when it was last in the tree, and you will probably want to do 'cvs add's rather than 'cvs import' to avoid having to deal with merge conflicts.

Re: NEW: sysutils/vifm

2016-06-12 Thread Dmitrij D. Czarkoff
Dmitrij D. Czarkoff said: > Here is a tarball with another attempt at vifm port: > > - uses waitpid(2) to reap spawned processes > - in mime detection code uses pledge(2) + libmagic(3) as first choice >and execl(3) + file(1) as second > - same in filetype detection

Re: NEW: sysutils/vifm

2016-06-12 Thread Dmitrij D. Czarkoff
Stuart Henderson said: > > - in mime detection code uses pledge(2) + libmagic(3) as first choice > >and execl(3) + file(1) as second > > er, we were trying to get rid of libmagic use... As I see it, we are trying to solve security issues related to the fact that libmagic may be tricked into

Re: NEW: sysutils/vifm

2016-06-12 Thread Stuart Henderson
On 2016/06/12 11:03, Dmitrij D. Czarkoff wrote: > Here is a tarball with another attempt at vifm port: > > - uses waitpid(2) to reap spawned processes > - in mime detection code uses pledge(2) + libmagic(3) as first choice >and execl(3) + file(1) as second er, we were tr

Re: NEW: sysutils/vifm

2016-06-12 Thread Dmitrij D. Czarkoff
Here is a tarball with another attempt at vifm port: - uses waitpid(2) to reap spawned processes - in mime detection code uses pledge(2) + libmagic(3) as first choice and execl(3) + file(1) as second - same in filetype detection (in previous ports was just popen(3)) - does nothing to one

Re: NEW: sysutils/vifm

2016-06-09 Thread Dmitrij D. Czarkoff
Rafael Sadowski said: > here is a third and last try to push vifm in ports tree. Now that we have pledge(2), it would probably be a better idea to use libmagic with fork+pledge. | + /* replace single quotes with double */ | + if (strchr(filename, '\'')) | { | - ret

Re: NEW: sysutils/vifm

2016-06-09 Thread Stuart Henderson
On 2016/06/09 20:39, Landry Breuil wrote: > So, fwiw, the attached version is ok for me to import - stuff can still > be fixed in-tree if more issues arise. Let's stop the bikeshedding, and > thank Rafael for his perseverance. Kill the patch.orig and OK with me. Though the desktop-file-utils dep

Re: NEW: sysutils/vifm

2016-06-09 Thread Landry Breuil
On Wed, Jun 08, 2016 at 11:00:21PM +0200, Rafael Sadowski wrote: > On Wed Jun 08, 2016 at 09:34:50PM +0200, Landry Breuil wrote: > > On Tue, Jun 07, 2016 at 09:28:37PM +0200, Rafael Sadowski wrote: > > > Hi ports@ and vifm friends, > > > > > > here is a thir

Re: NEW: sysutils/vifm

2016-06-08 Thread Rafael Sadowski
On Wed Jun 08, 2016 at 09:34:50PM +0200, Landry Breuil wrote: > On Tue, Jun 07, 2016 at 09:28:37PM +0200, Rafael Sadowski wrote: > > Hi ports@ and vifm friends, > > > > here is a third and last try to push vifm in ports tree. > > > > port core features: >

Re: NEW: sysutils/vifm

2016-06-08 Thread Landry Breuil
On Tue, Jun 07, 2016 at 09:28:37PM +0200, Rafael Sadowski wrote: > Hi ports@ and vifm friends, > > here is a third and last try to push vifm in ports tree. > > port core features: > - The same as: http://marc.info/?l=openbsd-ports=145647165914163=2 > - new: remove pope

Re: NEW: sysutils/vifm

2016-06-07 Thread Uwe Werler
Am 07.06.2016 21:28:37, schrieb Rafael Sadowski: > Hi ports@ and vifm friends, > > here is a third and last try to push vifm in ports tree. > > port core features: > - The same as: > http://marc.info/?l=openbsd-ports=145647165914163=2 > - new: remove popen(2) call and re

NEW: sysutils/vifm

2016-06-07 Thread Rafael Sadowski
Hi ports@ and vifm friends, here is a third and last try to push vifm in ports tree. port core features: - The same as: http://marc.info/?l=openbsd-ports=145647165914163=2 - new: remove popen(2) call and replace with fork(2)(execl(3) pkg/DESCR: Vifm is a two panel ncurses based vi[m] like file

Re: NEW: sysutils/vifm

2016-03-13 Thread Dmitrij D. Czarkoff
Rafael Sadowski said: > - czarkoff@'s file(1)-based mime type detection patch. My patch was actually bad. It does not fix vulnerability it is supposed to fix. | + if (strchr(filename, '\'')) | + { | + qp = quoted_filename; | + | + do { | + if

Re: NEW: sysutils/vifm

2016-03-13 Thread Rafael Sadowski
On Fri Feb 26, 2016 at 08:26:47AM +0100, Rafael Sadowski wrote: > hey @ports and vifm friends, > > here is a second try to push vifm in ports tree. > > port core features: > > - default build without libmagic > - czarkoff@'s file(1)-based mime type detection patch

NEW: sysutils/vifm

2016-02-25 Thread Rafael Sadowski
hey @ports and vifm friends, here is a second try to push vifm in ports tree. port core features: - default build without libmagic - czarkoff@'s file(1)-based mime type detection patch. -- I'll pull request upstream with czarkoff's okay. - add "no_x11" flavor (from czarkoff@). -- no_

Re: NEW: sysutils/vifm

2016-02-03 Thread Dmitrij D. Czarkoff
ons and use file(1) from base > > > > > as the only detection method, it is *loads* safer. > > > > > > > > Well, the actual code is: > > > > > > > > | snprintf(command, sizeof(command), "file \"%s\" -b --mime-type",

Re: NEW: sysutils/vifm

2016-02-02 Thread Landry Breuil
On Tue, Feb 02, 2016 at 05:09:34PM +0100, Tobias Ulmer wrote: > What's the point when it requires half of GNOME? You should call the > package gvifm... > > CONFIGURE_ARGS += --without-gtk --without-libmagic --without-X11 > --without-dyn-X11 As the one who originally ported vifm

Re: NEW: sysutils/vifm

2016-02-02 Thread Landry Breuil
On Tue, Feb 02, 2016 at 08:56:35PM +0100, Rafael Sadowski wrote: > On Tue Feb 02, 2016 at 05:09:34PM +0100, Tobias Ulmer wrote: > > What's the point when it requires half of GNOME? You should call the > > package gvifm... > > Is that my fault!? If you don't like, it don't u

Re: NEW: sysutils/vifm

2016-02-02 Thread Rafael Sadowski
On Tue Feb 02, 2016 at 05:09:34PM +0100, Tobias Ulmer wrote: > What's the point when it requires half of GNOME? You should call the > package gvifm... Is that my fault!? If you don't like, it don't use it. I'm NOT a vifm developer. I only port for my friend Uwe. That's it! > > CO

Re: NEW: sysutils/vifm

2016-02-02 Thread Dmitrij D. Czarkoff
Landry Breuil said: > Im not sure 'feature-set-wise' that it's worth adding the complexity of > a FLAVOR. Flavors were supposed to address the "half GNOME" issue. -- Dmitrij D. Czarkoff

Re: NEW: sysutils/vifm

2016-02-02 Thread Landry Breuil
On Tue, Feb 02, 2016 at 09:34:13PM +0100, Dmitrij D. Czarkoff wrote: > Landry Breuil said: > > Im not sure 'feature-set-wise' that it's worth adding the complexity of > > a FLAVOR. > > Flavors were supposed to address the "half GNOME" issue. Sure, but in that particular case it turned into 'do

Re: NEW: sysutils/vifm

2016-02-02 Thread Stuart Henderson
> On Tue, Feb 02, 2016 at 05:09:34PM +0100, Tobias Ulmer wrote: > > (libmagic is a security disaster waiting to happen in a file manager) > On 2016/02/02 19:22, Landry Breuil wrote: > sqlite> select distinct(fullpkgpath) from depends where dependspath like > '%libmagic%'; [..] >

Re: NEW: sysutils/vifm

2016-02-02 Thread Dmitrij D. Czarkoff
Landry Breuil said: > Doing a FLAVOR for this is just overkill, as 99% of the users wont know > which one to choose (shall we build both by default?), Idea is that people should install package with no FLAVOR. If they really, really want to have as little dependencies as possible, they install

Re: NEW: sysutils/vifm

2016-02-02 Thread Tobias Ulmer
On Tue, Feb 02, 2016 at 08:56:35PM +0100, Rafael Sadowski wrote: > On Tue Feb 02, 2016 at 05:09:34PM +0100, Tobias Ulmer wrote: > > What's the point when it requires half of GNOME? You should call the > > package gvifm... > > Is that my fault!? If you don't like, it don't u

Re: NEW: sysutils/vifm

2016-02-02 Thread Stefan Sperling
On Tue, Feb 02, 2016 at 10:41:12PM +0100, Rafael Sadowski wrote: > Yes, if we disable GTK+ and libmagic we fallback to file(1). Easy choice. Just use file(1) and disable the others. file(1) is satisfied by the base install (no extra deps) and is also the most secure option of the bunch.

Re: NEW: sysutils/vifm

2016-02-02 Thread Stuart Henderson
On 2016/02/02 21:58, Landry Breuil wrote: > Oh, and the code in src/int/file_magic.c even has a fallback to use file > %s -b --mime-type called via popen().. It would be nice to kill the other options and use file(1) from base as the only detection method, it is *loads* safer.

Re: NEW: sysutils/vifm

2016-02-02 Thread Landry Breuil
On Tue, Feb 02, 2016 at 09:44:52PM +0100, Landry Breuil wrote: > On Tue, Feb 02, 2016 at 09:34:13PM +0100, Dmitrij D. Czarkoff wrote: > > Landry Breuil said: > > > Im not sure 'feature-set-wise' that it's worth adding the complexity of > > > a FLAVOR. > > > > Flavors were supposed to address the

Re: NEW: sysutils/vifm

2016-02-02 Thread Rafael Sadowski
On Tue Feb 02, 2016 at 10:16:47PM +0100, Dmitrij D. Czarkoff wrote: > Landry Breuil said: > > Doing a FLAVOR for this is just overkill, as 99% of the users wont know > > which one to choose (shall we build both by default?), > > Idea is that people should install package with no FLAVOR. If they

Re: NEW: sysutils/vifm

2016-02-02 Thread Landry Breuil
On Tue, Feb 02, 2016 at 10:52:45PM +0100, Stefan Sperling wrote: > On Tue, Feb 02, 2016 at 10:41:12PM +0100, Rafael Sadowski wrote: > > Yes, if we disable GTK+ and libmagic we fallback to file(1). > > Easy choice. Just use file(1) and disable the others. file(1) is satisfied > by the base install

Re: NEW: sysutils/vifm

2016-02-02 Thread Dmitrij D. Czarkoff
he only detection method, it is *loads* safer. Well, the actual code is: | snprintf(command, sizeof(command), "file \"%s\" -b --mime-type", filename); Note double quotes. Of course no quoting is performed on filename. Thus: 1. If filename contains double quote, vifm sigfaults.

Re: NEW: sysutils/vifm

2016-02-02 Thread Dmitrij D. Czarkoff
ot;file \"%s\" -b --mime-type", > > filename); > > > > Note double quotes. Of course no quoting is performed on filename. > > Thus: > > > > 1. If filename contains double quote, vifm sigfaults. > > 2. If filename is nasty, nasty things h

Re: NEW: sysutils/vifm

2016-02-02 Thread Stuart Henderson
quotes. Of course no quoting is performed on filename. > Thus: > > 1. If filename contains double quote, vifm sigfaults. > 2. If filename is nasty, nasty things happen. Eg. I renamed a png image >to "$(echo text)", and vifm opened it in vi. I guess filename >"`doas rm -Rf $HOME/*`" will also pleasantly surprise user. Ugh. I have seen CVEs assigned for smaller problems than that!

Re: NEW: sysutils/vifm

2016-02-02 Thread Dmitrij D. Czarkoff
ect mimetype was found and the best > handler was proposed. I guess that's what you get for using file from > base which is ... basic. I somehow overlooked the fact that vifm only uses X11 to set window title. I bet people may live without this feature. (I thought it uses X11 for clipboard.) Pro

Re: NEW: sysutils/vifm

2016-02-02 Thread Landry Breuil
ion method, it is *loads* safer. > > > > > > Well, the actual code is: > > > > > > | snprintf(command, sizeof(command), "file \"%s\" -b --mime-type", > > > filename); > > > > > > Note double quotes. Of course

Re: NEW: sysutils/vifm

2016-02-02 Thread Tobias Ulmer
On Tue, Feb 02, 2016 at 05:18:13PM +0100, Dmitrij D. Czarkoff wrote: > Tobias Ulmer said: > > What's the point when it requires half of GNOME? You should call the > > package gvifm... > > GTK+ is not half of GNOME. Is this supposed to make me feel better? :p > > -- > Dmitrij D. Czarkoff >

Re: NEW: sysutils/vifm

2016-02-02 Thread Dmitrij D. Czarkoff
Tobias Ulmer said: > What's the point when it requires half of GNOME? You should call the > package gvifm... GTK+ is not half of GNOME. -- Dmitrij D. Czarkoff

Re: NEW: sysutils/vifm

2016-02-02 Thread Dmitrij D. Czarkoff
Tobias Ulmer said: > On Tue, Feb 02, 2016 at 05:18:13PM +0100, Dmitrij D. Czarkoff wrote: > > Tobias Ulmer said: > > > What's the point when it requires half of GNOME? You should call the > > > package gvifm... > > > > GTK+ is not half of GNOME. > > Is this supposed to make me feel better? :p

Re: NEW: sysutils/vifm

2016-02-02 Thread Tobias Ulmer
Sadowski wrote: > hey @ports and vifm friends, > > here is an up-to-date vifm port. Tested on amd64 by me and positive test > feedback from Uwe Werler. Port request by Uwe. > > I found a thread on ports@: > https://marc.info/?l=openbsd-ports=144944041505080=2 > > I can n

Re: NEW: sysutils/vifm

2016-01-29 Thread Uwe Werler
> hey @ports and vifm friends, > > here is an up-to-date vifm port. Tested on amd64 by me and positive test > feedback from Uwe Werler. Port request by Uwe. > > I found a thread on ports@: > https://marc.info/?l=openbsd-ports=144944041505080=2 > > I can not confirm

Re: NEW: sysutils/vifm

2016-01-29 Thread Erling Westenvik
On Thu, Jan 28, 2016 at 06:18:59PM +0100, Rafael Sadowski wrote: > here is an up-to-date vifm port. Tested on amd64 by me and positive > test feedback from Uwe Werler. Port request by Uwe. Tested positive on amd64. Love it! Thank you very much. Hope it gets imported. Regards, Erling >

NEW: sysutils/vifm

2016-01-28 Thread Rafael Sadowski
hey @ports and vifm friends, here is an up-to-date vifm port. Tested on amd64 by me and positive test feedback from Uwe Werler. Port request by Uwe. I found a thread on ports@: https://marc.info/?l=openbsd-ports=144944041505080=2 I can not confirm runtime problems or memory usage oversize

Re: vifm

2015-12-06 Thread Anthony J. Bentley
Predrag Punosevac writes: > I noticed that vifm has been removed from the OpenBSD port three prior > to 5.8 release. Are there technical reasons for such decision (I > remember pains to initial import vifm into the port three due to the > code quality)? It looks like vifm got many

vifm

2015-12-06 Thread Predrag Punosevac
I noticed that vifm has been removed from the OpenBSD port three prior to 5.8 release. Are there technical reasons for such decision (I remember pains to initial import vifm into the port three due to the code quality)? It looks like vifm got many new features which might have triggered

Re: New: misc/vifm

2009-08-09 Thread Landry Breuil
file_name[view-window_width -2]; - and accessing : file_name[view-window_width +1] is no good.. but the code does indeed lots of scarier things :) While here, install vifmrc to share/vifm to remove the annoying warning upon first startup, where it tried to copy the file from there to ~/.vifm. Comments/oks

Re: New: misc/vifm

2009-08-09 Thread Aaron Stellman
(basic testing) @macppc/sparc64/i386/alpha/amd64 - allocating : char file_name[view-window_width -2]; - and accessing : file_name[view-window_width +1] is no good.. but the code does indeed lots of scarier things :) While here, install vifmrc to share/vifm to remove the annoying warning

Re: New: misc/vifm

2009-08-08 Thread Landry Breuil
On Fri, Aug 07, 2009 at 04:06:53PM -0700, Aaron Stellman wrote: Hello ports@, attached is the ports of vifm -- ncurses file manager with vi keybindings. cat pkg/DESCR Vifm is a ncurses based file manager with vi like keybindings. If you use vi, vifm gives you complete keyboard control over

Re: New: misc/vifm

2009-08-08 Thread Tobias Ulmer
On Sat, Aug 08, 2009 at 11:12:02AM +0200, Landry Breuil wrote: On Fri, Aug 07, 2009 at 04:06:53PM -0700, Aaron Stellman wrote: Hello ports@, attached is the ports of vifm -- ncurses file manager with vi keybindings. cat pkg/DESCR Vifm is a ncurses based file manager with vi like

Re: New: misc/vifm

2009-08-08 Thread Tobias Ulmer
First try that doesn't crash on amd64 within seconds. Removes the most evil things gcc warns about and moves malloc out of the signal handler. There is without a doubt, much more to repair... vifm2.tar.gz Description: application/tar-gz

Re: New: misc/vifm

2009-08-08 Thread Landry Breuil
On Sat, Aug 08, 2009 at 04:22:08PM +0200, Tobias Ulmer wrote: First try that doesn't crash on amd64 within seconds. Removes the most evil things gcc warns about and moves malloc out of the signal handler. There is without a doubt, much more to repair... For sure.. with your patches, it still

Re: New: misc/vifm

2009-08-08 Thread Predrag Punosevac
to repair... For sure.. with your patches, it still explodes on sparc64 at the same point.. volunteers for code reading fixing forwarding patches upstream needed :) Landry I would like to bring to your attention two facts: 1. Somebody did try to port vifm to OpenBSD few years ago

Re: New: misc/vifm

2009-08-08 Thread Landry Breuil
two facts: 1. Somebody did try to port vifm to OpenBSD few years ago. There is the reason vifm is still not in ports. Funny, looking at the archives... i found out it was myself who already ported it :) 2. Good luck with fixing things upstream. My fellow Tucsonian who coded vifm did

Re: [new] vifm

2007-11-20 Thread Paul Irofti
On Mon, Nov 19, 2007 at 04:27:59PM +0100, Landry Breuil wrote: Hi, a small port for vifm, a ncurses based file manager with vi like keybindings. Works fine for me on i386, it's rather basic but may be useful to someone.. cf http://vifm.sourceforge.net/docs.html for default keybindings

[new] vifm

2007-11-19 Thread Landry Breuil
Hi, a small port for vifm, a ncurses based file manager with vi like keybindings. Works fine for me on i386, it's rather basic but may be useful to someone.. cf http://vifm.sourceforge.net/docs.html for default keybindings. port is here : http://gcu.info/~gaston/ports/vifm.tar.gz Comments

Re: [new] vifm

2007-11-19 Thread Pea
Le Mon, 19 Nov 2007 16:27:59 +0100, Landry Breuil [EMAIL PROTECTED] a écrit : Hi, a small port for vifm, a ncurses based file manager with vi like keybindings. Works fine for me on i386, it's rather basic but may be useful to someone.. cf http://vifm.sourceforge.net/docs.html

Re: [new] vifm

2007-11-19 Thread Mike Erdely
On Mon, Nov 19, 2007 at 04:27:59PM +0100, Landry Breuil wrote: a small port for vifm, a ncurses based file manager with vi like keybindings. Works fine for me on i386, it's rather basic but may be useful to someone.. Works for me on i386 and macppc. It dumps core on sparc64. On both

Re: [new] vifm

2007-11-19 Thread Landry Breuil
On Mon, Nov 19, 2007 at 01:20:34PM -0500, Mike Erdely wrote: On Mon, Nov 19, 2007 at 04:27:59PM +0100, Landry Breuil wrote: a small port for vifm, a ncurses based file manager with vi like keybindings. Works fine for me on i386, it's rather basic but may be useful to someone.. Works

Re: Request for new port: vifm

2005-11-26 Thread Andreas Bihlmaier
Hello ports@ again, sorry for answering my own mail, but I did some more research: To make vifm compile you just have to install automake 1.7 (I used 1.9) change the links in vifm/ to point to /usr/local/share/automake-1.9/{depcomp,install-sh,missing,mkinstalldirs} The patch I posted before has

Request for new port: vifm

2005-11-23 Thread Andreas Bihlmaier
Hello ports@, I would really like to see vifm [1] in the ports tree, because it is a really nice and comfortable file manager (like mc), but with vi key bindings. I basically downloaded the source, untared it, fixed all the symlinks in the vifm directory and had to comment out one line in vimfm