Re: [NEW] LXAppearance 0.6.3

2017-08-06 Thread Landry Breuil
On Sat, Aug 05, 2017 at 09:32:22PM +0100, Stuart Henderson wrote:
> On 2017/08/05 21:43, Vadim Zhukov wrote:
> > 2017-08-05 1:28 GMT+03:00 Андрей Болконский :
> > > I fixed the port
> > >
> > > portcheck now passed
> > > OK?
> > 
> > With a few tweaks by me (attached) it's fully okay for me. Anyone else
> > to okay, or to commit?
> > 
> > > 2017-08-04 23:22 GMT+03:00 Florian Stinglmayr :
> > >
> > >> Hi
> > >>
> > >> On Fri, Aug 04, 2017 at 06:20:17PM +0300, Андрей Болконский wrote:
> > >> > I created this port.
> > >> >
> > >> > LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
> > >> > Users are able to change the theme, icons, and fonts used by
> > >> > applications easily. Starting at version 0.6.1 it also allows
> > >> > to enable the accessibility features.
> > >> >
> > >> > OK?
> > >>
> > >> You should run portcheck [1] on your port, it has a few hints on what
> > >> you need to improve. For example the missing OpenBSD header line, or
> > >> the @exec, @unexec-delete lines that are missing from PLIST.
> > 
> > --
> >   WBR,
> >   Vadim Zhukov
> 
> Please add a blank line after $OpenBSD$ and move WANTLIB to the
> usual place after PERMIT_* (I guess this port was not based on
> /usr/ports/infrastructure/templates/Makefile.template ..)
> 
> : LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
> : Users are able to change the theme, icons, and fonts used by
> : applications easily. Starting at version 0.6.1 it also allows
> : to enable the accessibility features.
> 
> I don't think DESCR needs to talk about version history, I'd
> prefer just rolling it into the features list, something like:
> 
>   LXAppearance is LXDE's GTK+ v2 and v3 theme switcher.
>   Users are able to change the theme, icons, fonts used by
>   applications, and enable accessibility features.
> 
> Apart from this the port reads ok. It doesn't seem very convenient
> though, is it expected that you need to restart applications to get
> them to accept changes made via this? I was really expecting a GUI
> theme switcher to result in things being updated live..

I havent tested lxappearance, but i think it might depend on a
full-blown desktop running. Using xfce, when i change the gtk theme via
xfce4-appearance-settings, all gtk apps immediately update to the new
theme..

Landry



Re: [NEW] LXAppearance 0.6.3

2017-08-06 Thread Андрей Болконский
hello! I fixed all  remarks.
not requested restart apps.

2017-08-05 23:32 GMT+03:00 Stuart Henderson :
>
>
> Please add a blank line after $OpenBSD$ and move WANTLIB to the
> usual place after PERMIT_* (I guess this port was not based on
> /usr/ports/infrastructure/templates/Makefile.template ..)
>
> : LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
> : Users are able to change the theme, icons, and fonts used by
> : applications easily. Starting at version 0.6.1 it also allows
> : to enable the accessibility features.
>
> I don't think DESCR needs to talk about version history, I'd
> prefer just rolling it into the features list, something like:
>
>   LXAppearance is LXDE's GTK+ v2 and v3 theme switcher.
>   Users are able to change the theme, icons, fonts used by
>   applications, and enable accessibility features.
>
> Apart from this the port reads ok. It doesn't seem very convenient
> though, is it expected that you need to restart applications to get
> them to accept changes made via this? I was really expecting a GUI
> theme switcher to result in things being updated live..
>
>


lxappearance_zhuk.tar.gz
Description: GNU Zip compressed data


Re: [NEW] LXAppearance 0.6.3

2017-08-05 Thread Андрей Болконский
ok-ok.

2017-08-05 21:43 GMT+03:00 Vadim Zhukov :

> 2017-08-05 1:28 GMT+03:00 Андрей Болконский :
> > I fixed the port
> >
> > portcheck now passed
> > OK?
>
> With a few tweaks by me (attached) it's fully okay for me. Anyone else
> to okay, or to commit?
>
> > 2017-08-04 23:22 GMT+03:00 Florian Stinglmayr :
> >
> >> Hi
> >>
> >> On Fri, Aug 04, 2017 at 06:20:17PM +0300, Андрей Болконский wrote:
> >> > I created this port.
> >> >
> >> > LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
> >> > Users are able to change the theme, icons, and fonts used by
> >> > applications easily. Starting at version 0.6.1 it also allows
> >> > to enable the accessibility features.
> >> >
> >> > OK?
> >>
> >> You should run portcheck [1] on your port, it has a few hints on what
> >> you need to improve. For example the missing OpenBSD header line, or
> >> the @exec, @unexec-delete lines that are missing from PLIST.
>
> --
>   WBR,
>   Vadim Zhukov
>


Re: [NEW] LXAppearance 0.6.3

2017-08-05 Thread Stuart Henderson
On 2017/08/05 21:43, Vadim Zhukov wrote:
> 2017-08-05 1:28 GMT+03:00 Андрей Болконский :
> > I fixed the port
> >
> > portcheck now passed
> > OK?
> 
> With a few tweaks by me (attached) it's fully okay for me. Anyone else
> to okay, or to commit?
> 
> > 2017-08-04 23:22 GMT+03:00 Florian Stinglmayr :
> >
> >> Hi
> >>
> >> On Fri, Aug 04, 2017 at 06:20:17PM +0300, Андрей Болконский wrote:
> >> > I created this port.
> >> >
> >> > LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
> >> > Users are able to change the theme, icons, and fonts used by
> >> > applications easily. Starting at version 0.6.1 it also allows
> >> > to enable the accessibility features.
> >> >
> >> > OK?
> >>
> >> You should run portcheck [1] on your port, it has a few hints on what
> >> you need to improve. For example the missing OpenBSD header line, or
> >> the @exec, @unexec-delete lines that are missing from PLIST.
> 
> --
>   WBR,
>   Vadim Zhukov

Please add a blank line after $OpenBSD$ and move WANTLIB to the
usual place after PERMIT_* (I guess this port was not based on
/usr/ports/infrastructure/templates/Makefile.template ..)

: LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
: Users are able to change the theme, icons, and fonts used by
: applications easily. Starting at version 0.6.1 it also allows
: to enable the accessibility features.

I don't think DESCR needs to talk about version history, I'd
prefer just rolling it into the features list, something like:

  LXAppearance is LXDE's GTK+ v2 and v3 theme switcher.
  Users are able to change the theme, icons, fonts used by
  applications, and enable accessibility features.

Apart from this the port reads ok. It doesn't seem very convenient
though, is it expected that you need to restart applications to get
them to accept changes made via this? I was really expecting a GUI
theme switcher to result in things being updated live..



Re: [NEW] LXAppearance 0.6.3

2017-08-05 Thread Vadim Zhukov
2017-08-05 1:28 GMT+03:00 Андрей Болконский :
> I fixed the port
>
> portcheck now passed
> OK?

With a few tweaks by me (attached) it's fully okay for me. Anyone else
to okay, or to commit?

> 2017-08-04 23:22 GMT+03:00 Florian Stinglmayr :
>
>> Hi
>>
>> On Fri, Aug 04, 2017 at 06:20:17PM +0300, Андрей Болконский wrote:
>> > I created this port.
>> >
>> > LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
>> > Users are able to change the theme, icons, and fonts used by
>> > applications easily. Starting at version 0.6.1 it also allows
>> > to enable the accessibility features.
>> >
>> > OK?
>>
>> You should run portcheck [1] on your port, it has a few hints on what
>> you need to improve. For example the missing OpenBSD header line, or
>> the @exec, @unexec-delete lines that are missing from PLIST.

--
  WBR,
  Vadim Zhukov


lxappearance_zhuk.tar.gz
Description: GNU Zip compressed data


Re: [NEW] LXAppearance 0.6.3

2017-08-04 Thread Андрей Болконский
I fixed the port

portcheck now passed
OK?

2017-08-04 23:22 GMT+03:00 Florian Stinglmayr :

> Hi
>
> On Fri, Aug 04, 2017 at 06:20:17PM +0300, Андрей Болконский wrote:
> > I created this port.
> >
> > LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
> > Users are able to change the theme, icons, and fonts used by
> > applications easily. Starting at version 0.6.1 it also allows
> > to enable the accessibility features.
> >
> > OK?
>
> You should run portcheck [1] on your port, it has a few hints on what
> you need to improve. For example the missing OpenBSD header line, or
> the @exec, @unexec-delete lines that are missing from PLIST.
>
>
> Regards,
> Florian
>
> [1]  /usr/ports/infrastructure/bin/portcheck
>


lxappearance.tar.gz
Description: GNU Zip compressed data


Re: [NEW] LXAppearance 0.6.3

2017-08-04 Thread Андрей Болконский
Please send private mall again. I accidentally deleted the letter (sorry)...

2017-08-04 18:20 GMT+03:00 Андрей Болконский :

> I created this port.
>
> LXAppearance is the standard GTK+ v2 and v3 theme switcher of LXDE.
> Users are able to change the theme, icons, and fonts used by
> applications easily. Starting at version 0.6.1 it also allows
> to enable the accessibility features.
>
> OK?
>