NEW/UPDATE:net/sic-1.1

2010-08-22 Thread Predrag Punosevac
Hello ports@

sic is minimalistic irc client. This port has been submitted at least
four or five times in the past couple of years by various people but
never committed. The only new thing here is that sic has a new version
1.1. I am resubmitting the port to create Internet archive. If somebody
cares to commit even better.

Cheers,
Predrag


sic-1.1.tgz
Description: Binary data


Re: NEW/UPDATE:net/sic-1.1

2010-08-22 Thread Matthias Kilian
Hi,

On Sun, Aug 22, 2010 at 12:04:07PM -0400, Predrag Punosevac wrote:
 sic is minimalistic irc client. This port has been submitted at least
 four or five times in the past couple of years by various people but
 never committed. The only new thing here is that sic has a new version
 1.1. I am resubmitting the port to create Internet archive. If somebody
 cares to commit even better.

- Don't patch the makefile or config.mk (unless you completely replace
  it by something that works ;-) Instead, you can force some settings via
  MAKE_FLAGS. For example, I did this:

  V =   .1
  DISTNAME =sic-$V
  ...
  CFLAGS += -I. -DVERSION=\\\$V\\\ -D_GNU_SOURCE
  MAKE_FLAGS =  CC=${CC} \
CFLAGS=${CFLAGS} \
LDFLAGS=${LDFLAGS}

  This will also allow to override CC (in case one wants to experiment
  with a different compiler).

- The suckless install target sucks (as always). Better write your own
  do-install: that uses ${INSTALL_PROGRAM} resp. ${INSTALL_MAN},
  which has the additional benefit that ${INSTALL_PROGRAM} automatically
  strips the program unless DEBUG is defined. However, you also
  have to get the version number into sic.1 (using a post-patch
  target, for example).

- The man page claims that the default port is 6667, but actually sic
  initializes the port variable to ircd and passes that as servname
  to getaddrinfo(3) later. This doesn't work unless you have a
  matching entry in services(5).

- Furthermore, if getaddrinfo(3) fails, sic uses strerror(3) instead of
  gai_strerror(3) to produce an error message. This leads to totally
  confusing error messages, like in:

$ sic -h 127.0.0.1
error: cannot resolve hostname '127.0.0.1': Invalid argument

Ciao,
Kili



Re: NEW/UPDATE:net/sic-1.1

2010-08-22 Thread Predrag Punosevac
Matthias Kilian k...@outback.escape.de wrote:

 Hi,

 On Sun, Aug 22, 2010 at 12:04:07PM -0400, Predrag Punosevac wrote:
  sic is minimalistic irc client. This port has been submitted at least
  four or five times in the past couple of years by various people but
  never committed. The only new thing here is that sic has a new version
  1.1. I am resubmitting the port to create Internet archive. If somebody
  cares to commit even better.

 - Don't patch the makefile or config.mk (unless you completely replace
   it by something that works ;-) Instead, you can force some settings via
   MAKE_FLAGS. For example, I did this:

   V = .1
   DISTNAME =  sic-$V
   ...
   CFLAGS +=   -I. -DVERSION=\\\$V\\\ -D_GNU_SOURCE
   MAKE_FLAGS =CC=${CC} \
   CFLAGS=${CFLAGS} \
   LDFLAGS=${LDFLAGS}

   This will also allow to override CC (in case one wants to experiment
   with a different compiler).

 - The suckless install target sucks (as always). Better write your own
   do-install: that uses ${INSTALL_PROGRAM} resp. ${INSTALL_MAN},
   which has the additional benefit that ${INSTALL_PROGRAM} automatically
   strips the program unless DEBUG is defined. However, you also
   have to get the version number into sic.1 (using a post-patch
   target, for example).

 - The man page claims that the default port is 6667, but actually sic
   initializes the port variable to ircd and passes that as servname
   to getaddrinfo(3) later. This doesn't work unless you have a
   matching entry in services(5).

 - Furthermore, if getaddrinfo(3) fails, sic uses strerror(3) instead of
   gai_strerror(3) to produce an error message. This leads to totally
   confusing error messages, like in:

   $ sic -h 127.0.0.1
   error: cannot resolve hostname '127.0.0.1': Invalid argument

 Ciao,
   Kili

Great suggestions!!! I will try to get back to it in next two-three
days if for no other reason but play little bit more with Makefile which
is about as simple as it gets.  

I wrote the patch for config.mk almost two years ago when I was
originally learning about porting software from 

http://www.openbsd.org/papers/opencon07-portstutorial/index.html

I learnt quite a bit more about Make utility in the mean time and your
e-mail make so much sense. 

Cheers,
Predrag



Re: NEW/UPDATE:net/sic-1.1

2010-08-22 Thread Matthias Kilian
On Sun, Aug 22, 2010 at 09:59:19PM -0400, Predrag Punosevac wrote:
 Great suggestions!!! I will try to get back to it in next two-three
 days if for no other reason but play little bit more with Makefile which
 is about as simple as it gets.  

For the getaddrinfo(3) bits and the port default, you may also want
to send patches to upstream.

Ciao,
Kili