Re: [NEW] converters/p5-Sereal-Encoder
On Mon, Mar 19, 2018 at 10:47:20PM +0100, Frederic Cambus wrote: > Again, thanks for this. I applied the same changes to p5-Sereal-Decoder, > attaching updated tarballs. The Makefile in p5-Sereal-Encoder.tar.gz has permissions 600, please change to 644 before commiting. The LGPL file is only in Encoder, remove LGPLv2.1 from Decoder Makefile. otherwise OK bluhm@
Re: [NEW] converters/p5-Sereal-Encoder
On Tue, Mar 06, 2018 at 02:28:12PM +0100, Alexander Bluhm wrote: > On Sun, Feb 25, 2018 at 04:13:38PM +0100, Frederic Cambus wrote: > > Here is a new port: converters/p5-Sereal-Encoder > > I had some problems with linking -lzstd especially when this package > was installed. I would recommend to add archivers/zstd as lib > dependency and always use the library from the existing package. > > Also for the included Devel::CheckLib we have a package. I prefer > to add dependencies and remove the included stuff. Then I am sure > which software is used after all this build magic. That makes sense to me, thanks for pointing this out. > I think the following things should change: > - There are some source files with different license, the comment > should include them. > - add zstd to wantlib > - depend on devel/p5-Devel-CheckLib and archivers/zstd > - according to Makefile.PL p5-Sereal-Decoder version >=4.002 is > needed for testing. I prefer to keep the version in sync with > our test dependecies. > - remove the unused Devel/CheckLib and zstd > - patch to search for libraries in /usr/local > > I have included my proposed changes for p5-Sereal-Encoder. Again, thanks for this. I applied the same changes to p5-Sereal-Decoder, attaching updated tarballs. p5-Sereal-Encoder.tar.gz Description: application/tar-gz p5-Sereal-Decoder.tar.gz Description: application/tar-gz
Re: [NEW] converters/p5-Sereal-Encoder
On Sun, Feb 25, 2018 at 04:13:38PM +0100, Frederic Cambus wrote: > Here is a new port: converters/p5-Sereal-Encoder I had some problems with linking -lzstd especially when this package was installed. I would recommend to add archivers/zstd as lib dependency and always use the library from the existing package. Also for the included Devel::CheckLib we have a package. I prefer to add dependencies and remove the included stuff. Then I am sure which software is used after all this build magic. I think the following things should change: - There are some source files with different license, the comment should include them. - add zstd to wantlib - depend on devel/p5-Devel-CheckLib and archivers/zstd - according to Makefile.PL p5-Sereal-Decoder version >=4.002 is needed for testing. I prefer to keep the version in sync with our test dependecies. - remove the unused Devel/CheckLib and zstd - patch to search for libraries in /usr/local I have included my proposed changes for p5-Sereal-Encoder. bluhm # $OpenBSD$ COMMENT = fast, compact, powerful binary serialization DISTNAME = Sereal-Encoder-4.005 CATEGORIES =converters MAINTAINER =Frederic Cambus # Perl, BSD, LGPLv2.1 PERMIT_PACKAGE_CDROM = Yes WANTLIB = c perl zstd MODULES = cpan BUILD_DEPENDS = devel/p5-Devel-CheckLib LIB_DEPENDS = archivers/zstd TEST_DEPENDS = converters/p5-Sereal-Decoder>=4.002 \ devel/p5-Test-Deep \ devel/p5-Test-Differences \ devel/p5-Test-LongString \ devel/p5-Test-Warn CPAN_AUTHOR = YVES post-extract: rm -r -- ${WRKSRC}/inc/Devel ${WRKSRC}/zstd pre-configure: ${SUBST_CMD} ${WRKSRC}/Makefile.PL .include $OpenBSD$ Index: Makefile.PL --- Makefile.PL.orig +++ Makefile.PL @@ -91,9 +91,9 @@ inc::Sereal::BuildTools::WriteMakefile( LICENSE => 'perl', ABSTRACT_FROM => 'lib/Sereal/Encoder.pm', AUTHOR => 'Steffen Mueller , Yves Orton ', -LIBS => [$libs], # e.g., '-lm' +LIBS => ["-L${LOCALBASE}/lib $libs"], # e.g., '-lm' DEFINE=> $defines, -INC => '-I.', # e.g., '-I. -I/usr/include/other' +INC => "-I. -I${LOCALBASE}/include", # e.g., '-I. -I/usr/include/other' OPTIMIZE => $optimize, DIR => $subdirs, OBJECT=> $objects,
Re: [NEW] converters/p5-Sereal-Encoder
On Sun, Feb 25, 2018 at 04:13:38PM +0100, Frederic Cambus wrote: > Here is a new port: converters/p5-Sereal-Encoder > > Also attaching converters/p5-Sereal-Decoder which does deserialization > operations for this format and is also needed as a TEST_DEPENDS. > > This is a dependency for an upcoming port. Ping. Anyone willing to have a look at this?