On Wed, Jul 11, 2018 at 12:43:35PM +0100, Stuart Henderson wrote:
> On 2018/07/10 23:16, Matthew Martin wrote:
> > Few signed char fixes.
>
> Was this a build failure before (in which case OK), or did it build but
> misbehave (in which case it needs a bump)?
Build failure [1]. Same reasoning as in bcallah's games/scid patch:
doesn't build on unsigned char arches (as there are negative values) and
no change on signed char arches.
1: http://build-failures.rhaalovely.net/aarch64/2018-06-21/geo/garmindev.log
> > diff --git patches/patch-src_EtrexH_CDevice_cpp
> > patches/patch-src_EtrexH_CDevice_cpp
> > new file mode 100644
> > index 000..4b0c1a0f437
> > --- /dev/null
> > +++ patches/patch-src_EtrexH_CDevice_cpp
> > @@ -0,0 +1,14 @@
> > +$OpenBSD$
> > +
> > +Index: src/EtrexH/CDevice.cpp
> > +--- src/EtrexH/CDevice.cpp.orig
> > src/EtrexH/CDevice.cpp
> > +@@ -47,7 +47,7 @@ callback ( state,0,cancel,0,message )
> > +
> > + namespace EtrexH
> > + {
> > +-static const char _clrtbl[1024]= {
> > ++static const signed char _clrtbl[1024]= {
> > + -127,-127,-127,0,-60,-60,-60,0,90,90,90,0,0,0,0,0,-117,0,0,0,
> > + -76,0,0,0,-43,0,0,0,-1,0,0,0,0,48,0,0,32,48,0,0,
> > + 65,48,0,0,106,48,0,0,-117,48,0,0,-76,48,0,0,-43,48,0,0,
> > diff --git patches/patch-src_EtrexLegendC_CDevice_cpp
> > patches/patch-src_EtrexLegendC_CDevice_cpp
> > new file mode 100644
> > index 000..d8eb9dde223
> > --- /dev/null
> > +++ patches/patch-src_EtrexLegendC_CDevice_cpp
> > @@ -0,0 +1,14 @@
> > +$OpenBSD$
> > +
> > +Index: src/EtrexLegendC/CDevice.cpp
> > +--- src/EtrexLegendC/CDevice.cpp.orig
> > src/EtrexLegendC/CDevice.cpp
> > +@@ -37,7 +37,7 @@ using namespace std;
> > + namespace EtrexLegendC
> > + {
> > +
> > +-static const char _clrtbl[1024]= {
> > ++static const signed char _clrtbl[1024]= {
> > + 0,0,0,0,32,0,0,0,65,0,0,0,106,0,0,0,-117,0,0,0,
> > + -76,0,0,0,-43,0,0,0,-1,0,0,0,0,48,0,0,32,48,0,0,
> > + 65,48,0,0,106,48,0,0,-117,48,0,0,-76,48,0,0,-43,48,0,0,
> > diff --git patches/patch-src_GPSMap60CSx_CDevice_cpp
> > patches/patch-src_GPSMap60CSx_CDevice_cpp
> > new file mode 100644
> > index 000..40789131168
> > --- /dev/null
> > +++ patches/patch-src_GPSMap60CSx_CDevice_cpp
> > @@ -0,0 +1,14 @@
> > +$OpenBSD$
> > +
> > +Index: src/GPSMap60CSx/CDevice.cpp
> > +--- src/GPSMap60CSx/CDevice.cpp.orig
> > src/GPSMap60CSx/CDevice.cpp
> > +@@ -43,7 +43,7 @@ using namespace std;
> > + namespace GPSMap60CSx
> > + {
> > +
> > +-static const char _clrtbl[1024]= {
> > ++static const signed char _clrtbl[1024]= {
> > + 0,0,0,0,32,0,0,0,65,0,0,0,106,0,0,0,-117,0,0,0,
> > + -76,0,0,0,-43,0,0,0,-1,0,0,0,0,48,0,0,32,48,0,0,
> > + 65,48,0,0,106,48,0,0,-117,48,0,0,-76,48,0,0,-43,48,0,0,
> >
>
