Re: [update] net/dnscontrol to 3.14.0
portno12 writes: > ping Thanks! committed! > > --- Original Message --- > > On Wednesday, February 23rd, 2022 at 3:09 PM, portno12 > wrote: > >> ping on import while the make target is worked out independently? >> >> --- Original Message --- >> >> On Tuesday, February 15th, 2022 at 2:50 PM, Aaron Bieber >> aa...@bolddaemon.com wrote: >> >> > Daniel Jakots d...@chown.me writes: >> > >> > > On Mon, 14 Feb 2022 17:30:19 +, Klemens Nanni k...@openbsd.org >> > > >> > > wrote: >> > > >> > > > > MODGO_VERSION shouldn't be in modules.inc, only in Makefile >> > > > >> > > > It comes out of `modgo-gen-modules' like this, should we fix that? >> > > >> > > yes please! >> > >> > Originally the version was spit out there to ensure that the porter was >> > >> > aware of what version the list was for. >> > >> > This is specifically useful if upstream produces release candidates as >> > >> > "latest" will point to that version. >> > >> > If we remove it from there, we should explicitly pass MODGO_VERSION to >> > >> > the helper.. but i don't know what we would do in cases where the >> > >> > MODGO_VERSION is not set. > > [2. text/x-patch; dnscontrol.diff]...
Re: [update] net/dnscontrol to 3.14.0
Daniel Jakots writes: > On Mon, 14 Feb 2022 17:30:19 +, Klemens Nanni > wrote: > >> > MODGO_VERSION shouldn't be in modules.inc, only in Makefile >> >> It comes out of `modgo-gen-modules' like this, should we fix that? > > yes please! Originally the version was spit out there to ensure that the porter was aware of what version the list was for. This is specifically useful if upstream produces release candidates as "latest" will point to that version. If we remove it from there, we should explicitly pass MODGO_VERSION to the helper.. but i don't know what we would do in cases where the MODGO_VERSION is not set.
Re: [update] net/dnscontrol to 3.14.0
On Mon, 14 Feb 2022 17:30:19 +, Klemens Nanni wrote: > > MODGO_VERSION shouldn't be in modules.inc, only in Makefile > > It comes out of `modgo-gen-modules' like this, should we fix that? yes please!
Re: [update] net/dnscontrol to 3.14.0
On 2022/02/14 17:30, Klemens Nanni wrote: > On Mon, Feb 14, 2022 at 05:25:57PM +, Stuart Henderson wrote: > > On 2022/02/14 17:20, portno12 wrote: > > > updates add a couple new providers, many fixes/improvements for existing > > > ones, and upgrades dependencies. > > > no breaking changes listed in the changelog. > > > > > > was my first go port update. can i please get feedback on if i > > > regenerated the module lists right with modgo-gen-modules? > > > > MODGO_VERSION shouldn't be in modules.inc, only in Makefile > > It comes out of `modgo-gen-modules' like this, should we fix that? Might be something that portgen could do, but modgo-gen-modules just writes on stdout so it doesn't really have a great way to split the bits going to modules.inc and those going to Makefile ..
Re: [update] net/dnscontrol to 3.14.0
On Mon, Feb 14, 2022 at 05:25:57PM +, Stuart Henderson wrote: > On 2022/02/14 17:20, portno12 wrote: > > updates add a couple new providers, many fixes/improvements for existing > > ones, and upgrades dependencies. > > no breaking changes listed in the changelog. > > > > was my first go port update. can i please get feedback on if i regenerated > > the module lists right with modgo-gen-modules? > > MODGO_VERSION shouldn't be in modules.inc, only in Makefile It comes out of `modgo-gen-modules' like this, should we fix that? > > Otherwise LGTM > > > https://github.com/StackExchange/dnscontrol/releases > >
Re: [update] net/dnscontrol to 3.14.0
On 2022/02/14 17:20, portno12 wrote: > updates add a couple new providers, many fixes/improvements for existing > ones, and upgrades dependencies. > no breaking changes listed in the changelog. > > was my first go port update. can i please get feedback on if i regenerated > the module lists right with modgo-gen-modules? MODGO_VERSION shouldn't be in modules.inc, only in Makefile Otherwise LGTM > https://github.com/StackExchange/dnscontrol/releases
