Re: NEW: libtheoraplay & libtheorafile - ports for videoplayback in FNA games

2018-02-20 Thread Stuart Henderson
On 2018/02/19 18:05, Thomas Frohwein wrote: > On Tue, Feb 13, 2018 at 09:21:48PM +, Stuart Henderson wrote: > > Bad distfile name for libtheoraplay, please use the > > DISTFILES=sensible-name-1.00{commithash}${EXTRACT_SUFX} mechanism to > > rename it. > > Upstream unfortunately doesn't do

Re: NEW: libtheoraplay & libtheorafile - ports for videoplayback in FNA games

2018-02-19 Thread Thomas Frohwein
On Tue, Feb 13, 2018 at 09:21:48PM +, Stuart Henderson wrote: > Bad distfile name for libtheoraplay, please use the > DISTFILES=sensible-name-1.00{commithash}${EXTRACT_SUFX} mechanism to > rename it. Upstream unfortunately doesn't do real versions, only number of the changeset. Question is if

Re: NEW: libtheoraplay & libtheorafile - ports for videoplayback in FNA games

2018-02-13 Thread Stuart Henderson
On 2018/02/13 10:09, Thomas Frohwein wrote: > Thanks for feedback from bentley@ > > - moved flags out of CFLAGS/LDFLAGS for libtheoraplay to not mess with mk.conf > - removed TMI from libtheoraplay/pkg/DESCR > - made libtheorafile honor CFLAGS and LDFLAGS (will send PR to upstream) > - make

Re: NEW: libtheoraplay & libtheorafile - ports for videoplayback in FNA games

2018-02-13 Thread Thomas Frohwein
Thanks for feedback from bentley@ - moved flags out of CFLAGS/LDFLAGS for libtheoraplay to not mess with mk.conf - removed TMI from libtheoraplay/pkg/DESCR - made libtheorafile honor CFLAGS and LDFLAGS (will send PR to upstream) - make indent white space of variable assignments more economical -

Re: NEW: libtheoraplay & libtheorafile - ports for videoplayback in FNA games

2018-02-12 Thread Anthony J. Bentley
Thomas Frohwein writes: > ping For libtheoraplay: - Breaks if CFLAGS is set in mk.conf. No need to add to CFLAGS, just add -shared and -I to do-build directly - Ditto for LDFLAGS - Nit: it's okay and often looks better for variable assignments to have different indentation levels to

Re: NEW: libtheoraplay & libtheorafile - ports for videoplayback in FNA games

2018-02-12 Thread Thomas Frohwein
ping On Sun, Jan 21, 2018 at 07:29:06PM -0800, Thomas Frohwein wrote: > Hi ports@, > > Attached are two ports that fulfill the same function in FNA games, but are > used > in different products: libtheoraplay and libtheorafile. Both are essentially > small libraries that are called by those