On Tue, Aug 23, 2016 at 12:55:52PM -0500, Kent R. Spillner wrote:
> > timewarrior is a new command line time tracking util from the same
> > people behind taskwarrior. Attached & included below is a port for
> > the newly released v1.0.0.beta1. I think it makes sense to wait
> > to import until the final release, but would appreciate feedback in
> > the meantime.
>
> timewarrior v1.0.0 was just released. Ok?
As a taskwarrior user, I would be happy to have timewarrior in the
ports tree as well.
I havent looked at the PLIST, but here are some comments / tweaks
inline to bring the port more on part with what we are doing for
taskwarrior.
> +DISTNAME = timew-1.0.0
-DISTNAME = timew-1.0.0
+VERSION = 1.0.0
+DISTNAME = timew-${VERSION}
+PKGNAME = timewarrior-${VERSION}
> +MASTER_SITES = ${HOMEPAGE}/download/
-MASTER_SITES = ${HOMEPAGE}/download/
+MASTER_SITES = ${HOMEPAGE}download/
> +WANTLIB += c gnutls m pthread
-WANTLIB += c gnutls m pthread
+WANTLIB += c m
> +LIB_DEPENDS = security/gnutls
This should be removed, timewarrior doesn't depend on gnutls.
> +CONFIGURE_ARGS += -DTIMEW_DOCDIR=share/timewarrior \
> + -DTIMEW_MAN1DIR=man/man1 \
> + -DTIMEW_MAN5DIR=man/man5
The line containing '-DTIMEW_MAN5DIR=man/man5' should be dropped, as
nothing gets installed in man5.
> +CONFIGURE_ENV += CFLAGS="-I${LOCALBASE}/include" \
> + LDFLAGS="-L${LOCALBASE}/lib"
It seems this can be dropped.
