Re: UPDATE: www/node 0.6.3 to 0.6.5
Hi Stuart, Stuart Henderson wrote on Fri, Dec 16, 2011 at 11:22:02AM +: On 2011-12-14, Aaron Bieber def...@gmail.com wrote: On Sat, Dec 10, 2011 at 02:04:44PM +0100, Ingo Schwarze wrote: Aaron Bieber wrote on Fri, Dec 09, 2011 at 08:01:38AM -0700: On Fri, Dec 09, 2011 at 01:54:12PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Dec 07, 2011 at 09:00:26AM -0700, Aaron wrote: This patch updates nodejs from 0.6.3 to 0.6.5. Tested on i386/amd64 Shouldn't the manpages be installed to a more generic path? I assume you are talking about the pages in /usr/local/lib/node_modules/npm/man/man3/ . They are specific to npm, which was just recently added to node, and are generally accessed from the npm command ( npm help json for example ). Moving them will likely cause problems as npm expects them to be in its node_module directory. Well, that could probably be fixed, no? But the names of these pages are too generic. So they either have to stay well well out of the way, in some non-generic path, as you proposed. Of course, then they are of rather limited usefulness, because man(1) and apropos(1) will not find them. Given the bad naming scheme, telling people to add that path to man.conf(5) would be a bad idea. Or alternatively, to make it possible to put them into /usr/local/man/, they have to be renamed to something sensible, like npm-init(1), npm-link(1), and so on, and npm has to be changed to cope. But probably that's beyond the scope of a port and should be fixed upstream instead. I agree, I don't think we should maintain a local patch for this. It's for sure harder than just passing a flag to configure. I will look into how feasible it is. I'm pretty happy to commit the diff as-is. Does anyone object? Just to avoid misunderstandings, i do not object. I'm explicitly OK with how Aaron handled the probably less-than-ideal upstream decisions regarding the manuals. I consider improving all that a question of helping upstream, and completely optional from a ports perspective. Obviously, i can't provide a real OK for a port like this one. Yours, Ingo
Re: UPDATE: www/node 0.6.3 to 0.6.5
On 2011-12-14, Aaron Bieber def...@gmail.com wrote: On Sat, Dec 10, 2011 at 02:04:44PM +0100, Ingo Schwarze wrote: Hi, Aaron Bieber wrote on Fri, Dec 09, 2011 at 08:01:38AM -0700: On Fri, Dec 09, 2011 at 01:54:12PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Dec 07, 2011 at 09:00:26AM -0700, Aaron wrote: This patch updates nodejs from 0.6.3 to 0.6.5. Tested on i386/amd64 Shouldn't the manpages be installed to a more generic path? I assume you are talking about the pages in /usr/local/lib/node_modules/npm/man/man3/ . They are specific to npm, which was just recently added to node, and are generally accessed from the npm command ( npm help json for example ). Moving them will likely cause problems as npm expects them to be in its node_module directory. Well, that could probably be fixed, no? But the names of these pages are too generic. So they either have to stay well well out of the way, in some non-generic path, as you proposed. Of course, then they are of rather limited usefulness, because man(1) and apropos(1) will not find them. Given the bad naming scheme, telling people to add that path to man.conf(5) would be a bad idea. Or alternatively, to make it possible to put them into /usr/local/man/, they have to be renamed to something sensible, like npm-init(1), npm-link(1), and so on, and npm has to be changed to cope. But probably that's beyond the scope of a port and should be fixed upstream instead. I agree, I don't think we should maintain a local patch for this. It's for sure harder than just passing a flag to configure. I will look into how feasible it is. I'm pretty happy to commit the diff as-is. Does anyone object?
Re: UPDATE: www/node 0.6.3 to 0.6.5
On Sat, Dec 10, 2011 at 02:04:44PM +0100, Ingo Schwarze wrote: Hi, Aaron Bieber wrote on Fri, Dec 09, 2011 at 08:01:38AM -0700: On Fri, Dec 09, 2011 at 01:54:12PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Dec 07, 2011 at 09:00:26AM -0700, Aaron wrote: This patch updates nodejs from 0.6.3 to 0.6.5. Tested on i386/amd64 Shouldn't the manpages be installed to a more generic path? I assume you are talking about the pages in /usr/local/lib/node_modules/npm/man/man3/ . They are specific to npm, which was just recently added to node, and are generally accessed from the npm command ( npm help json for example ). Moving them will likely cause problems as npm expects them to be in its node_module directory. Well, that could probably be fixed, no? But the names of these pages are too generic. So they either have to stay well well out of the way, in some non-generic path, as you proposed. Of course, then they are of rather limited usefulness, because man(1) and apropos(1) will not find them. Given the bad naming scheme, telling people to add that path to man.conf(5) would be a bad idea. Or alternatively, to make it possible to put them into /usr/local/man/, they have to be renamed to something sensible, like npm-init(1), npm-link(1), and so on, and npm has to be changed to cope. But probably that's beyond the scope of a port and should be fixed upstream instead. Yours, Ingo It's for sure harder than just passing a flag to configure. I will look into how feasible it is.
Re: UPDATE: www/node 0.6.3 to 0.6.5
Hi, Aaron Bieber wrote on Fri, Dec 09, 2011 at 08:01:38AM -0700: On Fri, Dec 09, 2011 at 01:54:12PM +0100, Jasper Lievisse Adriaanse wrote: On Wed, Dec 07, 2011 at 09:00:26AM -0700, Aaron wrote: This patch updates nodejs from 0.6.3 to 0.6.5. Tested on i386/amd64 Shouldn't the manpages be installed to a more generic path? I assume you are talking about the pages in /usr/local/lib/node_modules/npm/man/man3/ . They are specific to npm, which was just recently added to node, and are generally accessed from the npm command ( npm help json for example ). Moving them will likely cause problems as npm expects them to be in its node_module directory. Well, that could probably be fixed, no? But the names of these pages are too generic. So they either have to stay well well out of the way, in some non-generic path, as you proposed. Of course, then they are of rather limited usefulness, because man(1) and apropos(1) will not find them. Given the bad naming scheme, telling people to add that path to man.conf(5) would be a bad idea. Or alternatively, to make it possible to put them into /usr/local/man/, they have to be renamed to something sensible, like npm-init(1), npm-link(1), and so on, and npm has to be changed to cope. But probably that's beyond the scope of a port and should be fixed upstream instead. Yours, Ingo
Re: UPDATE: www/node 0.6.3 to 0.6.5
On Wed, Dec 07, 2011 at 09:00:26AM -0700, Aaron wrote:
This patch updates nodejs from 0.6.3 to 0.6.5. Tested on i386/amd64
Shouldn't the manpages be installed to a more generic path?
Index: Makefile
===
RCS file: /cvs/ports/www/node/Makefile,v
retrieving revision 1.19
diff -N -u -p Makefile
--- Makefile7 Dec 2011 12:18:01 - 1.19
+++ Makefile7 Dec 2011 15:11:26 -
@@ -8,7 +8,7 @@ ONLY_FOR_ARCHS= amd64 i386
COMMENT= V8 JavaScript for clients and servers
-NODE_VERSION= v0.6.3
+NODE_VERSION= v0.6.5
DISTNAME= node-${NODE_VERSION}
PKGNAME= ${DISTNAME:S/v//g}
Index: distinfo
===
RCS file: /cvs/ports/www/node/distinfo,v
retrieving revision 1.8
diff -N -u -p distinfo
--- distinfo7 Dec 2011 12:18:01 - 1.8
+++ distinfo7 Dec 2011 15:11:26 -
@@ -1,5 +1,5 @@
-MD5 (node-v0.6.3.tar.gz) = 6ccggcKhFBEo5T+E3Lo/Dg==
-RMD160 (node-v0.6.3.tar.gz) = vkLbJDlMkHq/dHAFF28ifRdauxU=
-SHA1 (node-v0.6.3.tar.gz) = UWIYCFHI6SSdGuCj0cEYA2zFao0=
-SHA256 (node-v0.6.3.tar.gz) = /lZC0m0EzH59R9qkJtoqeeJEvcuuFZShJXjw1v4DCC4=
-SIZE (node-v0.6.3.tar.gz) = 10048403
+MD5 (node-v0.6.5.tar.gz) = Cqrn6/NXtKZ9zxkW38JQ+g==
+RMD160 (node-v0.6.5.tar.gz) = GOdF42NqVo9TQ2Q3ZTAIMQy+IQQ=
+SHA1 (node-v0.6.5.tar.gz) = DgE4qgyxgjVUthYdCzgDKocYseE=
+SHA256 (node-v0.6.5.tar.gz) = cjZNJA+2HmeIl8CZ328pE4V8WTGqmx9E5z5DLUYpyi8=
+SIZE (node-v0.6.5.tar.gz) = 10195654
Index: pkg/PLIST
===
RCS file: /cvs/ports/www/node/pkg/PLIST,v
retrieving revision 1.3
diff -N -u -p pkg/PLIST
--- pkg/PLIST 7 Dec 2011 12:18:01 - 1.3
+++ pkg/PLIST 7 Dec 2011 15:11:26 -
@@ -86,7 +86,6 @@ lib/node_modules/npm/
lib/node_modules/npm/.gitmodules
lib/node_modules/npm/.npmignore
lib/node_modules/npm/AUTHORS
-lib/node_modules/npm/CHANGES
lib/node_modules/npm/LICENSE
lib/node_modules/npm/Makefile
lib/node_modules/npm/README.md
@@ -101,7 +100,6 @@ lib/node_modules/npm/cli.js
lib/node_modules/npm/configure
lib/node_modules/npm/doc/
lib/node_modules/npm/doc/api/
-lib/node_modules/npm/doc/api/author.md
lib/node_modules/npm/doc/api/bin.md
lib/node_modules/npm/doc/api/bugs.md
lib/node_modules/npm/doc/api/commands.md
@@ -110,15 +108,10 @@ lib/node_modules/npm/doc/api/deprecate.md
lib/node_modules/npm/doc/api/docs.md
lib/node_modules/npm/doc/api/edit.md
lib/node_modules/npm/doc/api/explore.md
-lib/node_modules/npm/doc/api/find.md
-lib/node_modules/npm/doc/api/get.md
lib/node_modules/npm/doc/api/help-search.md
-lib/node_modules/npm/doc/api/home.md
lib/node_modules/npm/doc/api/init.md
lib/node_modules/npm/doc/api/install.md
lib/node_modules/npm/doc/api/link.md
-lib/node_modules/npm/doc/api/list.md
-lib/node_modules/npm/doc/api/ln.md
lib/node_modules/npm/doc/api/load.md
lib/node_modules/npm/doc/api/ls.md
lib/node_modules/npm/doc/api/npm.md
@@ -130,11 +123,9 @@ lib/node_modules/npm/doc/api/prune.md
lib/node_modules/npm/doc/api/publish.md
lib/node_modules/npm/doc/api/rebuild.md
lib/node_modules/npm/doc/api/restart.md
-lib/node_modules/npm/doc/api/rm.md
lib/node_modules/npm/doc/api/root.md
lib/node_modules/npm/doc/api/run-script.md
lib/node_modules/npm/doc/api/search.md
-lib/node_modules/npm/doc/api/set.md
lib/node_modules/npm/doc/api/start.md
lib/node_modules/npm/doc/api/stop.md
lib/node_modules/npm/doc/api/submodule.md
@@ -148,7 +139,6 @@ lib/node_modules/npm/doc/api/view.md
lib/node_modules/npm/doc/api/whoami.md
lib/node_modules/npm/doc/cli/
lib/node_modules/npm/doc/cli/adduser.md
-lib/node_modules/npm/doc/cli/author.md
lib/node_modules/npm/doc/cli/bin.md
lib/node_modules/npm/doc/cli/bugs.md
lib/node_modules/npm/doc/cli/build.md
@@ -164,20 +154,15 @@ lib/node_modules/npm/doc/cli/docs.md
lib/node_modules/npm/doc/cli/edit.md
lib/node_modules/npm/doc/cli/explore.md
lib/node_modules/npm/doc/cli/faq.md
-lib/node_modules/npm/doc/cli/find.md
lib/node_modules/npm/doc/cli/folders.md
-lib/node_modules/npm/doc/cli/get.md
-lib/node_modules/npm/doc/cli/global.md
lib/node_modules/npm/doc/cli/help-search.md
lib/node_modules/npm/doc/cli/help.md
-lib/node_modules/npm/doc/cli/home.md
+lib/node_modules/npm/doc/cli/index.md
lib/node_modules/npm/doc/cli/init.md
lib/node_modules/npm/doc/cli/install.md
lib/node_modules/npm/doc/cli/json.md
lib/node_modules/npm/doc/cli/link.md
lib/node_modules/npm/doc/cli/list.md
-lib/node_modules/npm/doc/cli/ln.md
-lib/node_modules/npm/doc/cli/ls.md
lib/node_modules/npm/doc/cli/npm.md
lib/node_modules/npm/doc/cli/outdated.md
lib/node_modules/npm/doc/cli/owner.md
@@ -189,13 +174,11 @@ lib/node_modules/npm/doc/cli/rebuild.md
lib/node_modules/npm/doc/cli/registry.md
lib/node_modules/npm/doc/cli/removing-npm.md
lib/node_modules/npm/doc/cli/restart.md
Re: UPDATE: www/node 0.6.3 to 0.6.5
On Fri, Dec 09, 2011 at 01:54:12PM +0100, Jasper Lievisse Adriaanse wrote:
On Wed, Dec 07, 2011 at 09:00:26AM -0700, Aaron wrote:
This patch updates nodejs from 0.6.3 to 0.6.5. Tested on i386/amd64
Shouldn't the manpages be installed to a more generic path?
I assume you are talking about the pages in
/usr/local/lib/node_modules/npm/man/man3/ .
They are specific to npm, which was just recently added to node, and
are generally accessed from the npm command ( npm help json for
example ).
Moving them will likely cause problems as npm expects them to be in its
node_module directory.
On a side note - I started working on a MULTI_PACKAGES patch that will
have a no_npm option.
Index: Makefile
===
RCS file: /cvs/ports/www/node/Makefile,v
retrieving revision 1.19
diff -N -u -p Makefile
--- Makefile7 Dec 2011 12:18:01 - 1.19
+++ Makefile7 Dec 2011 15:11:26 -
@@ -8,7 +8,7 @@ ONLY_FOR_ARCHS= amd64 i386
COMMENT= V8 JavaScript for clients and servers
-NODE_VERSION= v0.6.3
+NODE_VERSION= v0.6.5
DISTNAME= node-${NODE_VERSION}
PKGNAME= ${DISTNAME:S/v//g}
Index: distinfo
===
RCS file: /cvs/ports/www/node/distinfo,v
retrieving revision 1.8
diff -N -u -p distinfo
--- distinfo7 Dec 2011 12:18:01 - 1.8
+++ distinfo7 Dec 2011 15:11:26 -
@@ -1,5 +1,5 @@
-MD5 (node-v0.6.3.tar.gz) = 6ccggcKhFBEo5T+E3Lo/Dg==
-RMD160 (node-v0.6.3.tar.gz) = vkLbJDlMkHq/dHAFF28ifRdauxU=
-SHA1 (node-v0.6.3.tar.gz) = UWIYCFHI6SSdGuCj0cEYA2zFao0=
-SHA256 (node-v0.6.3.tar.gz) = /lZC0m0EzH59R9qkJtoqeeJEvcuuFZShJXjw1v4DCC4=
-SIZE (node-v0.6.3.tar.gz) = 10048403
+MD5 (node-v0.6.5.tar.gz) = Cqrn6/NXtKZ9zxkW38JQ+g==
+RMD160 (node-v0.6.5.tar.gz) = GOdF42NqVo9TQ2Q3ZTAIMQy+IQQ=
+SHA1 (node-v0.6.5.tar.gz) = DgE4qgyxgjVUthYdCzgDKocYseE=
+SHA256 (node-v0.6.5.tar.gz) = cjZNJA+2HmeIl8CZ328pE4V8WTGqmx9E5z5DLUYpyi8=
+SIZE (node-v0.6.5.tar.gz) = 10195654
Index: pkg/PLIST
===
RCS file: /cvs/ports/www/node/pkg/PLIST,v
retrieving revision 1.3
diff -N -u -p pkg/PLIST
--- pkg/PLIST 7 Dec 2011 12:18:01 - 1.3
+++ pkg/PLIST 7 Dec 2011 15:11:26 -
@@ -86,7 +86,6 @@ lib/node_modules/npm/
lib/node_modules/npm/.gitmodules
lib/node_modules/npm/.npmignore
lib/node_modules/npm/AUTHORS
-lib/node_modules/npm/CHANGES
lib/node_modules/npm/LICENSE
lib/node_modules/npm/Makefile
lib/node_modules/npm/README.md
@@ -101,7 +100,6 @@ lib/node_modules/npm/cli.js
lib/node_modules/npm/configure
lib/node_modules/npm/doc/
lib/node_modules/npm/doc/api/
-lib/node_modules/npm/doc/api/author.md
lib/node_modules/npm/doc/api/bin.md
lib/node_modules/npm/doc/api/bugs.md
lib/node_modules/npm/doc/api/commands.md
@@ -110,15 +108,10 @@ lib/node_modules/npm/doc/api/deprecate.md
lib/node_modules/npm/doc/api/docs.md
lib/node_modules/npm/doc/api/edit.md
lib/node_modules/npm/doc/api/explore.md
-lib/node_modules/npm/doc/api/find.md
-lib/node_modules/npm/doc/api/get.md
lib/node_modules/npm/doc/api/help-search.md
-lib/node_modules/npm/doc/api/home.md
lib/node_modules/npm/doc/api/init.md
lib/node_modules/npm/doc/api/install.md
lib/node_modules/npm/doc/api/link.md
-lib/node_modules/npm/doc/api/list.md
-lib/node_modules/npm/doc/api/ln.md
lib/node_modules/npm/doc/api/load.md
lib/node_modules/npm/doc/api/ls.md
lib/node_modules/npm/doc/api/npm.md
@@ -130,11 +123,9 @@ lib/node_modules/npm/doc/api/prune.md
lib/node_modules/npm/doc/api/publish.md
lib/node_modules/npm/doc/api/rebuild.md
lib/node_modules/npm/doc/api/restart.md
-lib/node_modules/npm/doc/api/rm.md
lib/node_modules/npm/doc/api/root.md
lib/node_modules/npm/doc/api/run-script.md
lib/node_modules/npm/doc/api/search.md
-lib/node_modules/npm/doc/api/set.md
lib/node_modules/npm/doc/api/start.md
lib/node_modules/npm/doc/api/stop.md
lib/node_modules/npm/doc/api/submodule.md
@@ -148,7 +139,6 @@ lib/node_modules/npm/doc/api/view.md
lib/node_modules/npm/doc/api/whoami.md
lib/node_modules/npm/doc/cli/
lib/node_modules/npm/doc/cli/adduser.md
-lib/node_modules/npm/doc/cli/author.md
lib/node_modules/npm/doc/cli/bin.md
lib/node_modules/npm/doc/cli/bugs.md
lib/node_modules/npm/doc/cli/build.md
@@ -164,20 +154,15 @@ lib/node_modules/npm/doc/cli/docs.md
lib/node_modules/npm/doc/cli/edit.md
lib/node_modules/npm/doc/cli/explore.md
lib/node_modules/npm/doc/cli/faq.md
-lib/node_modules/npm/doc/cli/find.md
lib/node_modules/npm/doc/cli/folders.md
-lib/node_modules/npm/doc/cli/get.md
-lib/node_modules/npm/doc/cli/global.md
lib/node_modules/npm/doc/cli/help-search.md
lib/node_modules/npm/doc/cli/help.md
-lib/node_modules/npm/doc/cli/home.md
