Re: ncmpcpp dumps core when fetching lyrics

[Ashlen]

On 2020/09/12 12:36, Erling Westenvik wrote:
> Thanks for the diff. Ncmpcpp still crashes when trying to fetch lyrics though.
> Gdb output with last version and after rebuilding with debug flags:

Yep, same here. Needed `-l` to patch(1) the diff, not sure if it's an
issue with the diff or PEBCAK. Probably the second one.

On 20/09/12 12:42PM, Stuart Henderson wrote:
> Since the problem still exists in git head, I think it would be worth
> reporting this upstream.

Added a comment referencing this thread here[1] with my dummy account (I
don't trust M$). I figured it wasn't worth creating a separate issue.

[1] https://github.com/ncmpcpp/ncmpcpp/issues/394

--
https://amissing.link

Re: ncmpcpp dumps core when fetching lyrics

[Stuart Henderson]

On 2020/09/12 12:36, Erling Westenvik wrote:
> On Fri, Sep 11, 2020 at 10:09:25PM +0100, Stuart Henderson wrote:
> > [moving to ports@openbsd.org list]
> > On 2020-09-11, Ashlen  wrote:
> > > Sorry Stuart, I think I accidentally replied to you directly the first
> > > time I sent this. I'm still getting used to neomutt.
> > 
> > No problem, for mailing lists you usually want 'group-reply'
> > (by default this is bound to 'g' in mutt/neomutt).
> 
> And I accidentally sent my previous reply as 'list-reply' ('L') to @misc..
> 
> > This is likely a bug in ncmpcpp. Not sure if it's the same
> > thing but I found https://github.com/ncmpcpp/ncmpcpp/issues/394
> > which referenced https://github.com/ncmpcpp/ncmpcpp/issues/396
> > so I think the first step is to try a newer version.
> > Here's a ports diff to update it to git head, it builds OK but
> > I don't have any mpd setup so no idea how well/if it works.
> 
> Thanks for the diff. Ncmpcpp still crashes when trying to fetch lyrics though.
> Gdb output with last version and after rebuilding with debug flags:

Since the problem still exists in git head, I think it would be worth
reporting this upstream.

> [...]
> Program terminated with signal SIGBUS, Bus error.
> #0  _libc_pthread_mutex_unlock (mutexp=) at 
> /usr/src/lib/libc/thread/rthread_mutex.c:246
> 246 (void *)mutex->owner);
> (gdb) bt
> #0  _libc_pthread_mutex_unlock (mutexp=) at 
> /usr/src/lib/libc/thread/rthread_mutex.c:246
> #1  0x0f7389525277 in std::__1::__libcpp_mutex_unlock (__m=0xf73b8ff2d18) 
> at /usr/src/lib/libcxx/include/__threading_support:266
> #2  std::__1::mutex::unlock (this=0xf73b8ff2d18) at 
> /usr/src/lib/libcxx/src/mutex.cpp:45
> #3  0x0f713119422d in 
> std::__1::unique_lock::~unique_lock (this=) 
> at /usr/include/c++/v1/__mutex_base:153
> #4  Shared >::Resource::~Resource (this= out>) at ./utility/shared_resource.h:29
> #5  Lyrics::update (this=0xf740afb5c00) at screens/lyrics.cpp:236
> #6  0x0f71311f2215 in std::__1::__function::__value_func (BaseScreen*)>::operator()(BaseScreen*&&) const (this=0x7f7d4500,
> __args=) at /usr/include/c++/v1/functional:1799
> #7  std::__1::function::operator()(BaseScreen*) const 
> (this=0x7f7d4500, __arg=0xf740afb5c00) at 
> /usr/include/c++/v1/functional:2347
> #8  applyToVisibleWindows(std::__1::function) (f=...) at 
> screens/screen.cpp:135
> #9  0x0f71312d8ad8 in Status::trace (update_timer=, 
> update_window_timeout=) at status.cpp:236
> #10 0x0f7131249a13 in Actions::UpdateEnvironment::run 
> (this=0x7f7d48c8, update_timer=24, refresh_window=, 
> mpd_sync=)
> at actions.cpp:338
> #11 0x0f71312ae220 in main (argc=, argv=) 
> at ncmpcpp.cpp:217
> (gdb)
> 
> Erling

Re: ncmpcpp dumps core when fetching lyrics

[Erling Westenvik]

On Fri, Sep 11, 2020 at 10:09:25PM +0100, Stuart Henderson wrote:
> [moving to ports@openbsd.org list]
> On 2020-09-11, Ashlen  wrote:
> > Sorry Stuart, I think I accidentally replied to you directly the first
> > time I sent this. I'm still getting used to neomutt.
> 
> No problem, for mailing lists you usually want 'group-reply'
> (by default this is bound to 'g' in mutt/neomutt).

And I accidentally sent my previous reply as 'list-reply' ('L') to @misc..

> This is likely a bug in ncmpcpp. Not sure if it's the same
> thing but I found https://github.com/ncmpcpp/ncmpcpp/issues/394
> which referenced https://github.com/ncmpcpp/ncmpcpp/issues/396
> so I think the first step is to try a newer version.
> Here's a ports diff to update it to git head, it builds OK but
> I don't have any mpd setup so no idea how well/if it works.

Thanks for the diff. Ncmpcpp still crashes when trying to fetch lyrics though.
Gdb output with last version and after rebuilding with debug flags:

[...]
Program terminated with signal SIGBUS, Bus error.
#0  _libc_pthread_mutex_unlock (mutexp=) at 
/usr/src/lib/libc/thread/rthread_mutex.c:246
246 (void *)mutex->owner);
(gdb) bt
#0  _libc_pthread_mutex_unlock (mutexp=) at 
/usr/src/lib/libc/thread/rthread_mutex.c:246
#1  0x0f7389525277 in std::__1::__libcpp_mutex_unlock (__m=0xf73b8ff2d18) 
at /usr/src/lib/libcxx/include/__threading_support:266
#2  std::__1::mutex::unlock (this=0xf73b8ff2d18) at 
/usr/src/lib/libcxx/src/mutex.cpp:45
#3  0x0f713119422d in std::__1::unique_lock::~unique_lock 
(this=) at /usr/include/c++/v1/__mutex_base:153
#4  Shared >::Resource::~Resource (this=) 
at ./utility/shared_resource.h:29
#5  Lyrics::update (this=0xf740afb5c00) at screens/lyrics.cpp:236
#6  0x0f71311f2215 in std::__1::__function::__value_func::operator()(BaseScreen*&&) const (this=0x7f7d4500,
__args=) at /usr/include/c++/v1/functional:1799
#7  std::__1::function::operator()(BaseScreen*) const 
(this=0x7f7d4500, __arg=0xf740afb5c00) at 
/usr/include/c++/v1/functional:2347
#8  applyToVisibleWindows(std::__1::function) (f=...) at 
screens/screen.cpp:135
#9  0x0f71312d8ad8 in Status::trace (update_timer=, 
update_window_timeout=) at status.cpp:236
#10 0x0f7131249a13 in Actions::UpdateEnvironment::run (this=0x7f7d48c8, 
update_timer=24, refresh_window=, mpd_sync=)
at actions.cpp:338
#11 0x0f71312ae220 in main (argc=, argv=) at 
ncmpcpp.cpp:217
(gdb)

Erling

Re: ncmpcpp dumps core when fetching lyrics

[Stuart Henderson]

[moving to ports@openbsd.org list]

On 2020-09-11, Ashlen  wrote:
> Sorry Stuart, I think I accidentally replied to you directly the first
> time I sent this. I'm still getting used to neomutt.

No problem, for mailing lists you usually want 'group-reply'
(by default this is bound to 'g' in mutt/neomutt).

> On 20/09/11 09:09AM, Stuart Henderson wrote:
>> First thing to look for when there's a core dump is to see if you can
>> get a useful backtrace. How does the output look from this?
>>
>> pkg_add gdb
>> egdb ncmpcpp ncmpcpp.core
>> bt
>>
>> If the lines output from "bt" don't have function names in,
>> rebuild ncmpcpp with "make clean; DEBUG=-g make repackage reinstall"
>> and try again.
>
> Hey, thanks for the prompt reply and for explaining what I needed to
> do. Out of curiosity, why did you want me to install gdb as opposed to
> using the version included in the base system? I did so, yet am unaware
> of the difference between them.

The gdb version in the base system is pretty old and doesn't
work well with newer compilers, especially with C++ software.

> Here's the output from egdb after recompiling:
>
> GNU gdb (GDB) 7.12.1
> Copyright (C) 2017 Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later 
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
> and "show warranty" for details.
> This GDB was configured as "x86_64-unknown-openbsd6.8".
> Type "show configuration" for configuration details.
> For bug reporting instructions, please see:
>.
> Find the GDB manual and other documentation resources online at:
>.
> For help, type "help".
> Type "apropos word" to search for commands related to "word"...
> Reading symbols from ncmpcpp...done.
> [New process 190872]
> Core was generated by `ncmpcpp'.
> Program terminated with signal SIGBUS, Bus error.
> #0  _libc_pthread_mutex_unlock (mutexp=) at 
> /usr/src/lib/libc/thread/rthread_mutex.c:246
> 246   /usr/src/lib/libc/thread/rthread_mutex.c: No such file or directory.
> (gdb) bt
> #0  _libc_pthread_mutex_unlock (mutexp=) at 
> /usr/src/lib/libc/thread/rthread_mutex.c:246
> #1  0x05595695fb27 in std::__1::__libcpp_mutex_unlock (__m=0x55a00cce818)
> at /usr/src/lib/libcxx/include/__threading_support:266
> #2  std::__1::mutex::unlock (this=0x55a00cce818) at 
> /usr/src/lib/libcxx/src/mutex.cpp:45
> #3  0x05572d3b623d in 
> std::__1::unique_lock::~unique_lock (this=)
> at /usr/include/c++/v1/__mutex_base:153
> #4  Shared >::Resource::~Resource (this= out>) at ./utility/shared_resource.h:29
> #5  Lyrics::update (this=0x559775d4400) at screens/lyrics.cpp:236
> #6  0x05572d4137d5 in std::__1::__function::__value_func (BaseScreen*)>::operator()(BaseScreen*&&) const (
> this=0x7f7eef80, __args=) at 
> /usr/include/c++/v1/functional:1799
> #7  std::__1::function::operator()(BaseScreen*) const 
> (this=0x7f7eef80, __arg=0x559775d4400)
> at /usr/include/c++/v1/functional:2347
> #8  applyToVisibleWindows(std::__1::function) (f=...) at 
> screens/screen.cpp:135
> #9  0x05572d4f9848 in Status::trace (update_timer=, 
> update_window_timeout=)
> at status.cpp:233
> #10 0x05572d46ae33 in Actions::UpdateEnvironment::run 
> (this=0x7f7ef348, update_timer=24,
> refresh_window=, mpd_sync=) at 
> actions.cpp:338
> #11 0x05572d4cf110 in main (argc=, argv=) 
> at ncmpcpp.cpp:217
>
> --
> https://amissing.link
>
>

Yep that's a usable backtrace.

This is likely a bug in ncmpcpp. Not sure if it's the same
thing but I found https://github.com/ncmpcpp/ncmpcpp/issues/394
which referenced https://github.com/ncmpcpp/ncmpcpp/issues/396
so I think the first step is to try a newer version.
Here's a ports diff to update it to git head, it builds OK but
I don't have any mpd setup so no idea how well/if it works.

Index: Makefile
===
RCS file: /cvs/ports/audio/ncmpcpp/Makefile,v
retrieving revision 1.72
diff -u -p -r1.72 Makefile
--- Makefile12 Jul 2019 20:43:37 -  1.72
+++ Makefile11 Sep 2020 21:07:31 -
@@ -5,10 +5,11 @@ BROKEN-hppa = bindings.h:85:4: error: t
 
 COMMENT =  ncurses mpd client inspired by ncmpc
 
-DISTNAME = ncmpcpp-0.8.2
-REVISION = 1
+GH_ACCOUNT =   ncmpcpp
+GH_PROJECT =   ncmpcpp
+GH_COMMIT =7ee6de39a1540f87854335d5b226018276ce9ef9
 
-EXTRACT_SUFX = .tar.bz2
+DISTNAME = ncmpcpp-0.9pre20200803
 
 CATEGORIES =   audio
 
@@ -23,8 +24,6 @@ WANTLIB += boost_thread-mt c crypto curl
 WANTLIB += curses nghttp2 pthread ssl ${LIBCXX} tag z
 WANTLIB += ${COMPILER_LIBCXX}
 
-MASTER_SITES = ${HOMEPAGE}stable/
-
 LIB_DEPENDS =  audio/libmpdclient>=2.4 \
audio/taglib \