Hello Stuart, thanks for the review.
On Thu, Aug 03, 2017 at 06:43:11PM +0100, Stuart Henderson wrote:
>
> clang is already used as the compiler on i386/amd64/aarch64. Just using
> "COMPILER=clang" means this won't build on some arch which do have c++11
> support from ports gcc.
>
> For most things "COMPILER=gcc" is generally now the best option for c++11
> ports, this means "build with clang if it's in base, otherwise build with
> ports gcc".
>
Thank you for the information. I will use "gcc" instead.
> > * Use /var/run/kea instead of /tmp for the UNIX domain control sockets
> > introduced in 1.2.0.
>
> Please subst with ${LOCALSTATEDIR} instead of hardcoding /var.
>
Sorry about that. While using ${LOCALSTATEDIR} directly in the .pre
files does not work, I have used the @localstatedir@ markers instead
(which is used in other places in the files already).
>
> It's no longer LIBCXX but COMPILER_LIBCXX, which made me spot that your cvs
> diff is against Makefile r1.7 (post-6.1 but pre-current) .. so your ports tree
> (which includes portcheck) needs an update.
>
Thanks for spotting that. New diff against fresh ports tree below (and
now portcheck is happy as well).
I also noticed something I had missed in the configure output previously:
===
./configure[16315]: test: >: unexpected operator/operand
===
I opened a PR for that:
https://github.com/isc-projects/kea/pull/53
I dont feel that warrants a port patch though as I don't think the
outcome matters on OpenBSD.
--
Patrik Lundin
Index: Makefile
===
RCS file: /cvs/ports/net/kea/Makefile,v
retrieving revision 1.9
diff -u -p -u -r1.9 Makefile
--- Makefile26 Jul 2017 22:45:27 - 1.9
+++ Makefile3 Aug 2017 20:17:26 -
@@ -2,29 +2,30 @@
COMMENT= high-performance and extensible DHCP server engine from ISC
-VERSION= 1.1.0
+VERSION= 1.2.0
DISTNAME= kea-${VERSION}
PKGNAME= ${DISTNAME:S/-P/pl/}
-REVISION= 0
SHARED_LIBS += kea-asiodns 0.0 # 0.0
-SHARED_LIBS += kea-asiolink 1.0 # 3.0
-SHARED_LIBS += kea-cc0.0 # 1.0
-SHARED_LIBS += kea-cfgclient 0.1 # 2.1
-SHARED_LIBS += kea-cryptolink0.0 # 1.0
-SHARED_LIBS += kea-dhcp++1.0 # 4.1
-SHARED_LIBS += kea-dhcp_ddns 0.1 # 1.1
-SHARED_LIBS += kea-dhcpsrv 1.0 # 6.0
-SHARED_LIBS += kea-dns++ 0.0 # 2.0
-SHARED_LIBS += kea-eval 1.0 # 4.0
+SHARED_LIBS += kea-asiolink 2.0 # 4.0
+SHARED_LIBS += kea-cc1.0 # 2.0
+SHARED_LIBS += kea-cfgclient 1.0 # 3.0
+SHARED_LIBS += kea-cryptolink1.0 # 2.0
+SHARED_LIBS += kea-dhcp++2.0 # 5.0
+SHARED_LIBS += kea-dhcp_ddns 0.2 # 1.2
+SHARED_LIBS += kea-dhcpsrv 2.0 # 7.0
+SHARED_LIBS += kea-dns++ 1.0 # 1.1
+SHARED_LIBS += kea-eval 2.0 # 5.0
SHARED_LIBS += kea-exceptions0.0 # 0.0
-SHARED_LIBS += kea-hooks 1.0 # 2.0
-SHARED_LIBS += kea-log 1.0 # 2.0
+SHARED_LIBS += kea-hooks 2.0 # 3.0
+SHARED_LIBS += kea-http 0.0 # 0.0
+SHARED_LIBS += kea-log 2.0 # 3.0
+SHARED_LIBS += kea-process 0.0 # 0.0
SHARED_LIBS += kea-stats 0.0 # 1.0
SHARED_LIBS += kea-threads 1.0 # 1.0
SHARED_LIBS += kea-util-io 0.0 # 0.0
-SHARED_LIBS += kea-util 1.0 # 2.0
+SHARED_LIBS += kea-util 1.1 # 2.1
CATEGORIES=net
@@ -50,6 +51,9 @@ CONFIGURE_ARGS+= --with-openssl=/usr \
--with-boost-lib-dir=${LOCALBASE}/lib
LIBTOOL_FLAGS= --tag=disable-static
+
+# configure: error: std::unique_ptr (a C++11 feature) is not supported
+COMPILER= gcc
FLAVORS= mysql postgresql
FLAVOR?=
Index: distinfo
===
RCS file: /cvs/ports/net/kea/distinfo,v
retrieving revision 1.3
diff -u -p -u -r1.3 distinfo
--- distinfo13 Nov 2016 14:58:18 - 1.3
+++ distinfo3 Aug 2017 20:17:26 -
@@ -1,2 +1,2 @@
-SHA256 (kea-1.1.0.tar.gz) = w9l67k+qGWU//m0355fi+/YyEkzQuYu1Avm5e1o4PC0=
-SIZE (kea-1.1.0.tar.gz) = 4934875
+SHA256 (kea-1.2.0.tar.gz) = ItFZRbE2ALVsNyE3l8ofPumFHmEZEgrq4IAzxMxS0Sk=
+SIZE (kea-1.2.0.tar.gz) = 5720941
Index: patches/patch-src_bin_dhcp4_tests_dhcp4_process_tests_sh_in
===
RCS file: patches/patch-src_bin_dhcp4_tests_dhcp4_process_tests_sh_in
diff -N patches/patch-src_bin_dhcp4_tests_dhcp4_process_tests_sh_in
--- patches/patch-src_bin_dhcp4_tests_dhcp4_process_tests_sh_in 28 Feb 2017
08:57:12 - 1.1
+++ /dev/null 1 Jan 1970 00:00:00 -
@@ -1,12 +0,0 @@
-$OpenBSD: patch-src_bin_dhcp4_tests_dhcp4_process_tests_sh_in,v 1.1 2017/02/28
