Re: remove rsync from devel/git

2019-08-20 Thread Marc Espie
On Tue, Aug 20, 2019 at 01:47:15PM +0100, Stuart Henderson wrote:
> On 2019/08/20 14:39, Marc Espie wrote:
> > On Fri, Aug 16, 2019 at 12:48:09AM +0200, Jan Stary wrote:
> > > On Aug 15 18:30:20, j...@wxcvbn.org wrote:
> > > > Committed, thanks!
> > > 
> > > So now, with openrsync in base (thank you Kristaps),
> > > rsync can finaly go.
> > 
> > As of now, the main point of openrsync is to be able to test
> > interoperability of the protocol itself.
> > 
> > There's still a lot of work to be done before it can actually
> > replace full-featured rsync.
> > 
> 
> And it currently only speaks a really old protocol version that, amongst
> other things, doesn't do incremental filelist updates, so it is likely to use
> a bunch more RAM if you are transferring large numbers of files. Please 
> consider
> that if you are fetching anything from public rsync servers..

Ouch, it's even worse than I expected :(



Re: remove rsync from devel/git

2019-08-20 Thread Stuart Henderson
On 2019/08/20 14:39, Marc Espie wrote:
> On Fri, Aug 16, 2019 at 12:48:09AM +0200, Jan Stary wrote:
> > On Aug 15 18:30:20, j...@wxcvbn.org wrote:
> > > Committed, thanks!
> > 
> > So now, with openrsync in base (thank you Kristaps),
> > rsync can finaly go.
> 
> As of now, the main point of openrsync is to be able to test
> interoperability of the protocol itself.
> 
> There's still a lot of work to be done before it can actually
> replace full-featured rsync.
> 

And it currently only speaks a really old protocol version that, amongst
other things, doesn't do incremental filelist updates, so it is likely to use
a bunch more RAM if you are transferring large numbers of files. Please consider
that if you are fetching anything from public rsync servers..



Re: remove rsync from devel/git

2019-08-20 Thread Marc Espie
On Fri, Aug 16, 2019 at 12:48:09AM +0200, Jan Stary wrote:
> On Aug 15 18:30:20, j...@wxcvbn.org wrote:
> > Committed, thanks!
> 
> So now, with openrsync in base (thank you Kristaps),
> rsync can finaly go.

As of now, the main point of openrsync is to be able to test
interoperability of the protocol itself.

There's still a lot of work to be done before it can actually
replace full-featured rsync.



Re: remove rsync from devel/git

2019-08-15 Thread Jan Stary
On Aug 15 16:49:17, dera...@openbsd.org wrote:
> Jan Stary  wrote:
> 
> > On Aug 15 18:30:20, j...@wxcvbn.org wrote:
> > > Committed, thanks!
> > 
> > So now, with openrsync in base (thank you Kristaps),
> > rsync can finaly go.
> 
> Sadly, that is very far from true.  openrsync is still missing a large
> pile of important elements.

I mean on my machines; excuse the excitement :-)

(A thing I miss is rsync's --exclude
- often I find the need to sync a /backup dir
except the 200G dump of /dload or such.)



Re: remove rsync from devel/git

2019-08-15 Thread Theo de Raadt
Jan Stary  wrote:

> On Aug 15 18:30:20, j...@wxcvbn.org wrote:
> > Committed, thanks!
> 
> So now, with openrsync in base (thank you Kristaps),
> rsync can finaly go.

Sadly, that is very far from true.  openrsync is still missing a large
pile of important elements.



Re: remove rsync from devel/git

2019-08-15 Thread Jan Stary
On Aug 15 18:30:20, j...@wxcvbn.org wrote:
> Committed, thanks!

So now, with openrsync in base (thank you Kristaps),
rsync can finaly go.



Re: remove rsync from devel/git

2019-08-15 Thread Klemens Nanni
On Thu, Aug 15, 2019 at 04:44:38PM +0200, Jeremie Courreges-Anglas wrote:
> ritchie /tmp$ git clone rsync://host.xz/path/to/repo.git/
> Cloning into 'repo'...
> fatal: git-over-rsync is no longer supported
> 
> Here's a tweaked diff that only bumps -main, since only RUN_DEPENDS-main
> is changed.
> 
> Benoit & others: ok?
OK kn, thanks.



Re: remove rsync from devel/git

2019-08-15 Thread Benoit Lecocq




On 8/15/19 4:44 PM, Jeremie Courreges-Anglas wrote:


+cc maintainer

On Wed, Aug 14 2019, Jan Stary  wrote:

If I read
https://github.com/git/git/blob/master/Documentation/RelNotes/2.8.0.txt
right, rsync support was removed from git about three years ago.


Indeed.

ritchie /tmp$ git clone rsync://host.xz/path/to/repo.git/
Cloning into 'repo'...
fatal: git-over-rsync is no longer supported

Here's a tweaked diff that only bumps -main, since only RUN_DEPENDS-main
is changed.

Benoit & others: ok?


ok benoit@




Index: Makefile
===
RCS file: /cvs/ports/devel/git/Makefile,v
retrieving revision 1.201
diff -u -p -r1.201 Makefile
--- Makefile16 Jul 2019 09:56:55 -  1.201
+++ Makefile15 Aug 2019 14:39:03 -
@@ -6,6 +6,7 @@ COMMENT-x11 =   GIT - graphical tools
  
  V =		2.22.0

  REVISION =0
+REVISION-main =1
  DISTNAME =git-${V}
  PKGNAME-main =${DISTNAME}
  PKGNAME-svn = git-svn-${V}
@@ -45,8 +46,7 @@ MULTI_PACKAGES =  -main -svn -x11
  WANTLIB-main =c crypto curl expat iconv intl nghttp2 pthread 
ssl z
  
  RUN_DEPENDS-main =	devel/cvsps \

-   devel/p5-Error \
-   net/rsync
+   devel/p5-Error
  LIB_DEPENDS-main =devel/gettext,-runtime \
net/curl \
www/nghttp2






Re: remove rsync from devel/git

2019-08-15 Thread Jeremie Courreges-Anglas


+cc maintainer

On Wed, Aug 14 2019, Jan Stary  wrote:
> If I read
> https://github.com/git/git/blob/master/Documentation/RelNotes/2.8.0.txt
> right, rsync support was removed from git about three years ago.

Indeed.

ritchie /tmp$ git clone rsync://host.xz/path/to/repo.git/
Cloning into 'repo'...
fatal: git-over-rsync is no longer supported

Here's a tweaked diff that only bumps -main, since only RUN_DEPENDS-main
is changed.

Benoit & others: ok?


Index: Makefile
===
RCS file: /cvs/ports/devel/git/Makefile,v
retrieving revision 1.201
diff -u -p -r1.201 Makefile
--- Makefile16 Jul 2019 09:56:55 -  1.201
+++ Makefile15 Aug 2019 14:39:03 -
@@ -6,6 +6,7 @@ COMMENT-x11 =   GIT - graphical tools
 
 V =2.22.0
 REVISION = 0
+REVISION-main =1
 DISTNAME = git-${V}
 PKGNAME-main = ${DISTNAME}
 PKGNAME-svn =  git-svn-${V}
@@ -45,8 +46,7 @@ MULTI_PACKAGES =  -main -svn -x11
 WANTLIB-main = c crypto curl expat iconv intl nghttp2 pthread ssl z
 
 RUN_DEPENDS-main = devel/cvsps \
-   devel/p5-Error \
-   net/rsync
+   devel/p5-Error
 LIB_DEPENDS-main = devel/gettext,-runtime \
net/curl \
www/nghttp2


-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE