Re: security/opendnssec: replace /etc with ${SYSCONFDIR}

2015-12-22 Thread Patrik Lundin 
On Tue, Dec 22, 2015 at 08:03:29AM +0100, Antoine Jacoutot wrote:
> 
> That part is not, rc.subr is part of base and is always found under 
> /etc/rc.d/rc.subr
> 

I was not aware of that gotcha, thanks for the information :).

>
> I committed the first part (with a bump).
> Thanks.
> 

Great, thanks!

-- 
Patrik Lundin

Re: security/opendnssec: replace /etc with ${SYSCONFDIR}

2015-12-21 Thread Antoine Jacoutot 
On Mon, Dec 21, 2015 at 07:08:55PM +0100, Patrik Lundin wrote:
> Hello,
> 
> I noticed I was still using some '/etc' locations in PLIST and rc
> script, diff below.
> 
> -- 
> Patrik Lundin
> 
> Index: pkg/PLIST
> ===
> RCS file: /cvs/ports/security/opendnssec/pkg/PLIST,v
> retrieving revision 1.1.1.1
> diff -u -p -u -r1.1.1.1 PLIST
> --- pkg/PLIST 13 Oct 2015 17:03:55 -  1.1.1.1
> +++ pkg/PLIST 21 Dec 2015 18:04:59 -
> @@ -24,7 +24,7 @@ sbin/ods-control
>  @bin sbin/ods-signerd
>  @mode 0750
>  @group _opendnssec
> -@sample /etc/opendnssec/
> +@sample ${SYSCONFDIR}/opendnssec/

That part is correct.

>  @mode
>  @group
>  share/doc/opendnssec/
> Index: pkg/opendnssec.rc
> ===
> RCS file: /cvs/ports/security/opendnssec/pkg/opendnssec.rc,v
> retrieving revision 1.1.1.1
> diff -u -p -u -r1.1.1.1 opendnssec.rc
> --- pkg/opendnssec.rc 13 Oct 2015 17:03:55 -  1.1.1.1
> +++ pkg/opendnssec.rc 21 Dec 2015 18:04:59 -
> @@ -4,7 +4,7 @@
>  
>  daemon="${TRUEPREFIX}/sbin/ods-control"
>  
> -. /etc/rc.d/rc.subr
> +. ${SYSCONFDIR}/rc.d/rc.subr

That part is not, rc.subr is part of base and is always found under 
/etc/rc.d/rc.subr

I committed the first part (with a bump).
Thanks.

-- 
Antoine