Re: games/vegastrike/engine clang6 fix

[David CARLIER]

Would this version fits better ?

Regards.

On 13 April 2018 at 11:55, Jonathan Gray  wrote:

> On Fri, Apr 13, 2018 at 11:05:58AM +0100, David CARLIER wrote:
> > Hi,
> >
> > here a simple fix turning to C++03 mode.
>
> This will break gcc archs. --std only goes to c++98 with 4.2.1.
>
> >
> > Regards.
>
> > Index: engine/Makefile
> > ===
> > RCS file: /cvs/ports/games/vegastrike/engine/Makefile,v
> > retrieving revision 1.10
> > diff -u -p -r1.10 Makefile
> > --- engine/Makefile   26 Dec 2017 19:18:57 -  1.10
> > +++ engine/Makefile   13 Apr 2018 10:02:23 -
> > @@ -41,7 +41,8 @@ CONFIGURE_ARGS +=   --with-python-version=
> >   --disable-ffmpeg \
> >   --with-data-dir="${TRUEPREFIX}/share/vegastrike"
> >
> > -CXXFLAGS +=  -Wno-undefined-var-template -Wno-unused-volatile-lvalue
> > +CXXFLAGS +=  -Wno-undefined-var-template -Wno-unused-volatile-lvalue \
> > + -std=c++03
> >
> >  CONFIGURE_ENV =  \
> >   CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include
> -I${LOCALBASE}/include/libpng" \
>
>
Index: engine/Makefile
===
RCS file: /cvs/ports/games/vegastrike/engine/Makefile,v
retrieving revision 1.10
diff -u -p -r1.10 Makefile
--- engine/Makefile	26 Dec 2017 19:18:57 -	1.10
+++ engine/Makefile	13 Apr 2018 12:18:41 -
@@ -41,7 +41,12 @@ CONFIGURE_ARGS +=	--with-python-version=
 			--disable-ffmpeg \
 			--with-data-dir="${TRUEPREFIX}/share/vegastrike"
 
+.include 
+
 CXXFLAGS +=	-Wno-undefined-var-template -Wno-unused-volatile-lvalue
+.if ${PROPERTIES:Mclang}
+CXXFLAGS +=	-std=c++03
+.endif
 
 CONFIGURE_ENV =	\
 	CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include -I${LOCALBASE}/include/libpng" \

Re: games/vegastrike/engine clang6 fix

[Jonathan Gray]

On Fri, Apr 13, 2018 at 11:05:58AM +0100, David CARLIER wrote:
> Hi,
> 
> here a simple fix turning to C++03 mode.

This will break gcc archs. --std only goes to c++98 with 4.2.1.

> 
> Regards.

> Index: engine/Makefile
> ===
> RCS file: /cvs/ports/games/vegastrike/engine/Makefile,v
> retrieving revision 1.10
> diff -u -p -r1.10 Makefile
> --- engine/Makefile   26 Dec 2017 19:18:57 -  1.10
> +++ engine/Makefile   13 Apr 2018 10:02:23 -
> @@ -41,7 +41,8 @@ CONFIGURE_ARGS +=   --with-python-version=
>   --disable-ffmpeg \
>   --with-data-dir="${TRUEPREFIX}/share/vegastrike"
>  
> -CXXFLAGS +=  -Wno-undefined-var-template -Wno-unused-volatile-lvalue
> +CXXFLAGS +=  -Wno-undefined-var-template -Wno-unused-volatile-lvalue \
> + -std=c++03
>  
>  CONFIGURE_ENV =  \
>   CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include 
> -I${LOCALBASE}/include/libpng" \

games/vegastrike/engine clang6 fix

[David CARLIER]

Hi,

here a simple fix turning to C++03 mode.

Regards.
Index: engine/Makefile
===
RCS file: /cvs/ports/games/vegastrike/engine/Makefile,v
retrieving revision 1.10
diff -u -p -r1.10 Makefile
--- engine/Makefile	26 Dec 2017 19:18:57 -	1.10
+++ engine/Makefile	13 Apr 2018 10:02:23 -
@@ -41,7 +41,8 @@ CONFIGURE_ARGS +=	--with-python-version=
 			--disable-ffmpeg \
 			--with-data-dir="${TRUEPREFIX}/share/vegastrike"
 
-CXXFLAGS +=	-Wno-undefined-var-template -Wno-unused-volatile-lvalue
+CXXFLAGS +=	-Wno-undefined-var-template -Wno-unused-volatile-lvalue \
+			-std=c++03
 
 CONFIGURE_ENV =	\
 	CPPFLAGS="-I${X11BASE}/include -I${LOCALBASE}/include -I${LOCALBASE}/include/libpng" \