Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-22 Thread Thorsten Habich
On 8/22/2020 7:02 AM, Viktor Dukhovni wrote: > On Fri, Aug 21, 2020 at 05:38:42PM -0400, Wietse Venema wrote: > >> thorsten.hab...@findichgut.net: >>> Any chance to backport the patch to 3.4/3.5? >> This is more change than is allowed in a stable release. Postfix >> 3.6 drops support for OpenSSL

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Viktor Dukhovni
On Fri, Aug 21, 2020 at 05:38:42PM -0400, Wietse Venema wrote: > thorsten.hab...@findichgut.net: > > Any chance to backport the patch to 3.4/3.5? > > This is more change than is allowed in a stable release. Postfix > 3.6 drops support for OpenSSL < 1.1.1, deletes o(thousand) lines > of DANE

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Wietse Venema
Viktor Dukhovni: > On Fri, Aug 21, 2020 at 03:11:50PM -0400, Wietse Venema wrote: > > > Viktor Dukhovni: > > > On Fri, Aug 21, 2020 at 10:59:11AM -0400, Wietse Venema wrote: > > > > > > > > Viktor Dukhovni: > > > > > > - &_DANE_BASED(state->client_start_props->tls_level)) > > > > > > + &&

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Viktor Dukhovni
> On Aug 21, 2020, at 5:21 PM, thorsten.hab...@findichgut.net wrote: > > By the way I already applied your last patch on the testing environment. > No problems found so far. tafile and CApath based mandatory TLS delivery > work just fine. Thanks for the confirmation. Fortunately, the good news

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Wietse Venema
thorsten.hab...@findichgut.net: > Any chance to backport the patch to 3.4/3.5? This is more change than is allowed in a stable release. Postfix 3.6 drops support for OpenSSL < 1.1.1, deletes o(thousand) lines of DANE support from the Postfix TLS library, and replaces it with o(hundred) lines to

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Viktor Dukhovni
On Fri, Aug 21, 2020 at 03:11:50PM -0400, Wietse Venema wrote: > Viktor Dukhovni: > > On Fri, Aug 21, 2020 at 10:59:11AM -0400, Wietse Venema wrote: > > > > > > Viktor Dukhovni: > > > > > - &_DANE_BASED(state->client_start_props->tls_level)) > > > > > + &&

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Wietse Venema
Viktor Dukhovni: > On Fri, Aug 21, 2020 at 10:59:11AM -0400, Wietse Venema wrote: > > > > Viktor Dukhovni: > > > > - &_DANE_BASED(state->client_start_props->tls_level)) > > > > + && TLS_DANE_HASTA(state->client_start_props->dane)) > > > > msg_warn("%s: DANE requested, but not

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Viktor Dukhovni
On Fri, Aug 21, 2020 at 10:59:11AM -0400, Wietse Venema wrote: > > Viktor Dukhovni: > > > - &_DANE_BASED(state->client_start_props->tls_level)) > > > + && TLS_DANE_HASTA(state->client_start_props->dane)) > > > msg_warn("%s: DANE requested, but not available", > > >

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Wietse Venema
I have more questions. Wietse Venema: > Viktor Dukhovni: > > state->client_start_props->fd = state->ciphertext_fd; > > /* These predicates and warning belong inside tls_client_start(). */ > > if (!tls_dane_avail() /* mandatory side effects!! */ > > -

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-21 Thread Viktor Dukhovni
On Fri, Aug 21, 2020 at 10:32:10AM +0300, Thorsten Habich wrote: > > This is relevant, but probably not 100% accurate, likely some domains > > also intermittently failed routine CAfile-based validation. > > Thanks for the patch.  There was no higher number of certificate > verification failures

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-20 Thread Wietse Venema
Viktor Dukhovni: > On Thu, Aug 20, 2020 at 01:20:00PM -0400, Wietse Venema wrote: > > > Viktor Dukhovni: > > > > > - &_DANE_BASED(state->client_start_props->tls_level)) > > > + && TLS_DANE_HASTA(state->client_start_props->dane)) > > > @@ -1427,7 +1427,7 @@ static void tlsp_get_request_event(int

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-20 Thread Viktor Dukhovni
On Thu, Aug 20, 2020 at 01:20:00PM -0400, Wietse Venema wrote: > Viktor Dukhovni: > > > - &_DANE_BASED(state->client_start_props->tls_level)) > > + && TLS_DANE_HASTA(state->client_start_props->dane)) > > @@ -1427,7 +1427,7 @@ static void tlsp_get_request_event(int event, void > > *context) >

Re: PATCH #3 (Postfix 3.4 + 3.5): TLS connection_reuse with "tafile"

2020-08-20 Thread Wietse Venema
Viktor Dukhovni: > state->client_start_props->fd = state->ciphertext_fd; > /* These predicates and warning belong inside tls_client_start(). */ > if (!tls_dane_avail()/* mandatory side effects!! */ > - &_DANE_BASED(state->client_start_props->tls_level)) > +