Thanks for the feedback, I will make the changes and test with VALGRIND.
Duncan
> On 27 Feb 2021, at 23:20, Wietse Venema wrote:
>
> Duncan Bellamy:
>> Hi,
>>
>> This patch is based on the original code by Titus Jose on GitHub, I
>> updated it to work with the development branch and have adde
Hi,
Please see latest version of the patch, I tried testing with valgrind under
Alpine Linux in a Docker container and it didn’t report any errors. But a
“postfix stop” exits postfix/valgrind without a summary.
Duncan
postfix-redis-all.patch
Description: Binary data
> On 27 Feb 2021, at 23:2
Okay, thanks.
Will try that and get the output
Duncan
> On 10 Mar 2021, at 19:55, Wietse Venema wrote:
>
> Dunk:
>> Hi,
>> Please see latest version of the patch, I tried testing with valgrind under
>> Alpine Linux in a Docker container and it didn?t report any
Hi,I triedsh postfix-env.sh valgrind --tool=memcheck src/global/mail_dict redis:$(pwd)/redis.cf read<<'EOF'With redis.cfhost = 127.0.0.1port = 6379
prefix = TEST:With “get foo”, or any command like postmap I get segmentation fault (see attached output)So I created test.sh with:#!/bin/shpostfix st
gt; On 11 Mar 2021, at 20:29, Wietse Venema wrote:
>
> Dunk:
>> ?Hi,
>> I tried
>>
>> sh postfix-env.sh valgrind --tool=memcheck src/global/mail_dict
>> redis:$(pwd)/redis.cf read<<'EOF'
>>
>> With redis.cf
>>
>> hos
Thanks, I have tested in on a low volume email server.
Duncan
> On 11 Mar 2021, at 22:32, Wietse Venema wrote:
>
> Dunk:
>> Hi,
>> Okay, attached is output from test.sh that calls valgrind twice.
>>
>> Duncan
>
> Thanks, this looks good.
>
>
Thanks very much, I will have a look.
I can look at the TODOs. I am more familiar with how it works now, but need to
understand the memcache code as well.
Duncan
> On 13 Mar 2021, at 22:34, Wietse Venema wrote:
>
> Wietse Venema:
>> Dunk:
>>> Thanks, I have tested
I have compiled the new version, but it has an extra “#endif” in dict_redis.h
Looking at dict_mysql.c it looks like it is missing “#ifdef SNAPSHOT” in
dict_redis.h
Duncan
> On 13 Mar 2021, at 22:58, Dunk wrote:
>
> Thanks very much, I will have a look.
>
> I can look at t
Ok, thanks. Will leave it out then.
Duncan
> On 14 Mar 2021, at 13:07, Wietse Venema wrote:
>
> Dunk:
>> I have compiled the new version, but it has an extra ?#endif? in dict_redis.h
>
> I forgot to delete that.
>
>Wietes
>
>> Looking at dict_mysql.c